* bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type
@ 2013-11-20 20:07 Ivan Shmakov
2013-11-21 16:19 ` Ted Zlatanov
0 siblings, 1 reply; 5+ messages in thread
From: Ivan Shmakov @ 2013-11-20 20:07 UTC (permalink / raw)
To: 15939
Given that Debbugs is used for Emacs development itself, it
seems quite appropriate to add Debbugs .log file support to the
nndoc Gnus’ select method. Please thus consider the following
patch.
An example Debbugs .log file to test the patched nndoc against
could be retrieved with, say:
$ rsync -t -- \
rsync://bugs-mirror.debian.org/bts-spool-db/83/688283.log \
688283.log
(Then: G f 688283.log RET in the *Group* buffer.)
--- lisp/gnus/nndoc.el.~1~
+++ lisp/gnus/nndoc.el 2013-11-20 19:58:04.000000000 +0000
@@ -56,6 +56,10 @@ from the document.")
`((mmdf
(article-begin . "^\^A\^A\^A\^A\n")
(body-end . "^\^A\^A\^A\^A\n"))
+ (debbugs-db
+ (file-begin . "^\005")
+ (article-begin . "^[\005\007]\n")
+ (body-end . "^\003"))
(mime-digest
(article-begin . "")
(head-begin . "^ ?\n")
@@ -460,6 +464,10 @@ from the document.")
(when (looking-at "\^A\^A\^A\^A$")
t))
+(defun nndoc-debbugs-db-type-p ()
+ (when (looking-at "\006$")
+ t))
+
(defun nndoc-news-type-p ()
(when (looking-at "^Path:.*\n")
t))
--
FSF associate member #7257
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type
2013-11-20 20:07 bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type Ivan Shmakov
@ 2013-11-21 16:19 ` Ted Zlatanov
2013-11-21 16:27 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Ted Zlatanov @ 2013-11-21 16:19 UTC (permalink / raw)
To: Ivan Shmakov; +Cc: 15939
On Wed, 20 Nov 2013 20:07:54 +0000 Ivan Shmakov <ivan@siamics.net> wrote:
IS> Given that Debbugs is used for Emacs development itself, it
IS> seems quite appropriate to add Debbugs .log file support to the
IS> nndoc Gnus’ select method. Please thus consider the following
IS> patch.
This looks good to me. I don't know if this qualifies as a tiny change,
though. I see only one tiny change from you (from an older address, I
assume):
lisp/ChangeLog.14:2008-11-21 Ivan Shmakov <oneingray@gmail.com> (tiny change)
so I need to know if this is a tiny change and if not, if you have
assignment papers on file.
Thanks
Ted
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type
2013-11-21 16:19 ` Ted Zlatanov
@ 2013-11-21 16:27 ` Glenn Morris
2013-11-21 17:14 ` Ted Zlatanov
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2013-11-21 16:27 UTC (permalink / raw)
To: Ivan Shmakov; +Cc: 15939
Ted Zlatanov wrote:
> I don't know if this qualifies as a tiny change, though.
By itself, it does. (It's 7 fairly trivial lines of code, surely this is
obvious?)
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type
2013-11-21 16:27 ` Glenn Morris
@ 2013-11-21 17:14 ` Ted Zlatanov
2013-11-21 18:52 ` Ted Zlatanov
0 siblings, 1 reply; 5+ messages in thread
From: Ted Zlatanov @ 2013-11-21 17:14 UTC (permalink / raw)
To: Glenn Morris; +Cc: 15939, Ivan Shmakov
On Thu, 21 Nov 2013 11:27:52 -0500 Glenn Morris <rgm@gnu.org> wrote:
GM> Ted Zlatanov wrote:
>> I don't know if this qualifies as a tiny change, though.
GM> By itself, it does. (It's 7 fairly trivial lines of code, surely this is
GM> obvious?)
Thanks for confirming, I wasn't sure. Pushed to the Gnus Git repo, from
where it will be synchronized to Emacs.
Thanks!
Ted
commit 852d65fb565743a193d30838cc8e5dde64bbbb3c
Author: Ted Zlatanov <tzz@lifelogs.com>
Date: Thu Nov 21 12:11:43 2013 -0500
* nndoc.el (nndoc-type-alist): Support debbugs .log files.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-21 18:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-20 20:07 bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type Ivan Shmakov
2013-11-21 16:19 ` Ted Zlatanov
2013-11-21 16:27 ` Glenn Morris
2013-11-21 17:14 ` Ted Zlatanov
2013-11-21 18:52 ` Ted Zlatanov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).