bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type

bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type

[Ivan Shmakov]

	Given that Debbugs is used for Emacs development itself, it
	seems quite appropriate to add Debbugs .log file support to the
	nndoc Gnus’ select method.  Please thus consider the following
	patch.

	An example Debbugs .log file to test the patched nndoc against
	could be retrieved with, say:

$ rsync -t -- \
      rsync://bugs-mirror.debian.org/bts-spool-db/83/688283.log \
      688283.log 

	(Then: G f 688283.log RET in the *Group* buffer.)

--- lisp/gnus/nndoc.el.~1~
+++ lisp/gnus/nndoc.el	2013-11-20 19:58:04.000000000 +0000
@@ -56,6 +56,10 @@ from the document.")
   `((mmdf
      (article-begin .  "^\^A\^A\^A\^A\n")
      (body-end .  "^\^A\^A\^A\^A\n"))
+    (debbugs-db
+     (file-begin    . "^\005")
+     (article-begin . "^[\005\007]\n")
+     (body-end      . "^\003"))
     (mime-digest
      (article-begin . "")
      (head-begin . "^ ?\n")
@@ -460,6 +464,10 @@ from the document.")
   (when (looking-at "\^A\^A\^A\^A$")
     t))
 
+(defun nndoc-debbugs-db-type-p ()
+  (when (looking-at "\006$")
+    t))
+
 (defun nndoc-news-type-p ()
   (when (looking-at "^Path:.*\n")
     t))

-- 
FSF associate member #7257

bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type

[Ted Zlatanov]

On Wed, 20 Nov 2013 20:07:54 +0000 Ivan Shmakov <ivan@siamics.net> wrote: 

IS> Given that Debbugs is used for Emacs development itself, it
IS> seems quite appropriate to add Debbugs .log file support to the
IS> nndoc Gnus’ select method.	Please thus consider the following
IS> patch.

This looks good to me.  I don't know if this qualifies as a tiny change,
though.  I see only one tiny change from you (from an older address, I
assume):

lisp/ChangeLog.14:2008-11-21  Ivan Shmakov  <oneingray@gmail.com>  (tiny change)

so I need to know if this is a tiny change and if not, if you have
assignment papers on file.

Thanks
Ted

bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type

[Glenn Morris]

Ted Zlatanov wrote:

> I don't know if this qualifies as a tiny change, though.

By itself, it does. (It's 7 fairly trivial lines of code, surely this is
obvious?)

bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type

[Ted Zlatanov]

On Thu, 21 Nov 2013 11:27:52 -0500 Glenn Morris <rgm@gnu.org> wrote: 

GM> Ted Zlatanov wrote:
>> I don't know if this qualifies as a tiny change, though.

GM> By itself, it does. (It's 7 fairly trivial lines of code, surely this is
GM> obvious?)

Thanks for confirming, I wasn't sure.  Pushed to the Gnus Git repo, from
where it will be synchronized to Emacs.

Thanks!
Ted

commit 852d65fb565743a193d30838cc8e5dde64bbbb3c
Author: Ted Zlatanov <tzz@lifelogs.com>
Date:   Thu Nov 21 12:11:43 2013 -0500

    * nndoc.el (nndoc-type-alist): Support debbugs .log files.

bug#15939: [PATCH] nndoc.el: Add new debbugs-db nndoc type

[Ted Zlatanov]

Marking as done.