From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source... Date: Thu, 22 Jan 2015 08:00:30 +0100 Message-ID: <87lhkvz4dt.fsf@gnu.org> References: <87sif4txdv.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421910077 26636 80.91.229.3 (22 Jan 2015 07:01:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 Jan 2015 07:01:17 +0000 (UTC) Cc: 19645-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 22 08:01:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YEBlQ-0007aN-FR for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Jan 2015 08:01:12 +0100 Original-Received: from localhost ([::1]:51414 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEBlP-0002nk-R3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Jan 2015 02:01:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEBlL-0002nU-Pt for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 02:01:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEBlH-00040m-1D for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 02:01:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEBlG-00040e-V3 for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 02:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YEBlG-0002T7-Qz for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 02:01:02 -0500 Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jan 2015 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 19645 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 19645@debbugs.gnu.org, tsdh@gnu.org, tsdh@gnu.org Original-Received: via spool by 19645-done@debbugs.gnu.org id=D19645.14219100399451 (code D ref 19645); Thu, 22 Jan 2015 07:01:02 +0000 Original-Received: (at 19645-done) by debbugs.gnu.org; 22 Jan 2015 07:00:39 +0000 Original-Received: from localhost ([127.0.0.1]:52259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEBks-0002SN-F5 for submit@debbugs.gnu.org; Thu, 22 Jan 2015 02:00:38 -0500 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:55438) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEBkn-0002SA-Sw for 19645-done@debbugs.gnu.org; Thu, 22 Jan 2015 02:00:35 -0500 Original-Received: from thinkpad-t440p (dhcp08.uni-koblenz.de [141.26.71.8]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 960911A8464; Thu, 22 Jan 2015 08:00:32 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Wed, 21 Jan 2015 11:03:34 -0500") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98576 Archived-At: Stefan Monnier writes: >> helm-bbdb.el:22:1:Error: No next method for %S: helm--setup-source, >> nil, [eieio-class-tag--helm-type-file... > > It appears that you're calling helm--setup-source with an object of > type helm-type-file, but the only method that matches is a ":before" > method, so after running the before method, you get an error because > there's no primary. > > IIUC the error should be `cl-no-primary-method' instead of > `cl-no-next-method' (according to > http://www.cliki.net/Proposed%20ANSI%20Revisions%20and%20Clarifications). > > From what I can tell, the older EIEIO code just silently did nothing > in this case, treating the missing primary as a function that just > returns nil, but I think this is a mistake. > > I'm not sure how to preserve the compatibility with this mistake. > I'll see if I can come up with something, but in any case I think you > should fix Helm by making sure there is some primary method defined in > this case as well. No if it's a usage error on the helm side which the older EIEIO simply ignored, then I'd suggest not to reinstall compatibility with that older version but with CLOS, i.e., signal `cl-no-primary-method' instead of `cl-no-next-method'. Oh, and I see that Thierry (the helm dev) already added primary methods in https://github.com/emacs-helm/helm/commit/1eb07354f50ec26aa8be1290233696656b8dca32 So I'm closing this bug. Bye, Tassilo