bug#20688: "make check" fails on Fedora 21 x86-64

bug#20688: "make check" fails on Fedora 21 x86-64

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

I hardly ever run "make check", as it always fails for me and always has on 
Fedora 21 x86-64.  I'm tempted to remove the offending tests as I don't 
understand them and haven't had the patience to figure out why they fail.  Plus, 
the tests take too long.  Anyway, attached are the failures for the current master.

[-- Attachment #2: xx.txt --]
[-- Type: text/plain, Size: 1806 bytes --]

Test vc-test-rcs04-checkout-model backtrace:
  vc-test--checkout-model(RCS)
  (lambda nil (let ((fn-53215 (function ert-test-passed-p)) (args-5321
  ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
  ert-run-test([cl-struct-ert-test vc-test-rcs04-checkout-model "Check
  ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test v
  ert-run-tests(t #[385 "\306\x02\307\"\203G\0\211\211G\310U\203\x14\0\211@\20
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" ":." "-l" "ert" "-l" "vc-tests.elc" "-f" "ert-r
  command-line()
  normal-top-level()
Test vc-test-rcs04-checkout-model condition:
    (ert-test-failed
     ((should
       (memq
	(vc-checkout-model backend default-directory)
	'...))
      :form
      (memq nil
	    (announce implicit locking))
      :value nil))
   FAILED  20/25  vc-test-rcs04-checkout-model

...

Test file-notify-test03-autorevert-remote backtrace:
  #[nil "\306\307\x18\x19\310\x1a\307^[\3111\x19\0\312\216\313\"\211\x12)0\202^[\0\210\
  #[nil \x19\306\307!\x1a\310\311^[\x1c\312\x1d\311\x1e\x16\3131 \0\314\216\315\f\v\"\211
  ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
  ert-run-test([cl-struct-ert-test file-notify-test03-autorevert-remot
  ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test f
  ert-run-tests(t #[385 "\306\x02\307\"\203G\0\211\211G\310U\203\x14\0\211@\20
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" ":." "-l" "ert" "-l" "file-notify-tests.elc" "-
  command-line()
  normal-top-level()
Test file-notify-test03-autorevert-remote condition:
    (ert-test-failed
     ((should
       (string-match "another text"
		     (buffer-string)))
      :form
      (string-match "another text" "any text")
      :value nil))
   FAILED  8/8  file-notify-test03-autorevert-remote

bug#20688: "make check" fails on Fedora 21 x86-64

[Glenn Morris]

Paul Eggert wrote:

> I hardly ever run "make check", as it always fails for me and always
> has on Fedora 21 x86-64.  I'm tempted to remove the offending tests as
> I don't understand them and haven't had the patience to figure out why
> they fail.

vc-test-rcs04-checkout-model has never passed, even when it was introduced.
If it was an attempt to motivate some VC progress, it hasn't worked.
IMO it should be marked as expected-failure, or commented out.

file-notify-test03-autorevert sometimes works for me and sometimes it
doesn't. I don't know why. Anyway, that's http://debbugs.gnu.org/20392 .

> Plus, the tests take too long.

And they smell bad!

Less flippantly, IME it's one or two tramp tests that are slow (almost
as slow as all the others put together). Perhaps some tests should be
labelled as slow somehow and not run by a standard `make check',
only by `make check-all' or somesuch.

bug#20688: "make check" fails on Fedora 21 x86-64

[Glenn Morris]

Glenn Morris wrote:

> vc-test-rcs04-checkout-model has never passed, even when it was introduced.
> If it was an attempt to motivate some VC progress, it hasn't worked.
> IMO it should be marked as expected-failure.

I just did that.

Since there already is a bug report about file-notify-test03-autorevert,
I don't see what's left to do here.

bug#20688: "make check" fails on Fedora 21 x86-64

[Paul Eggert]

On 05/29/2015 12:13 AM, Glenn Morris wrote:
> Glenn Morris wrote:
>
>> vc-test-rcs04-checkout-model has never passed, even when it was introduced.
>> If it was an attempt to motivate some VC progress, it hasn't worked.
>> IMO it should be marked as expected-failure.
> I just did that.
>
> Since there already is a bug report about file-notify-test03-autorevert,
> I don't see what's left to do here.

Thanks for fixing the one and mentioning the other bug report. Perhaps 
I'll just remove the other test, if I find the time, since its bug seems 
to be low priority.  Anyway, I'll close this bug.

bug#20688: "make check" fails on Fedora 21 x86-64

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

>> I hardly ever run "make check", as it always fails for me and always
>> has on Fedora 21 x86-64.  I'm tempted to remove the offending tests as
>> I don't understand them and haven't had the patience to figure out why
>> they fail.
>
> vc-test-rcs04-checkout-model has never passed, even when it was introduced.
> If it was an attempt to motivate some VC progress, it hasn't worked.

Yes, I hoped that Eric would handle it. This attempt failed.

> file-notify-test03-autorevert sometimes works for me and sometimes it
> doesn't. I don't know why. Anyway, that's http://debbugs.gnu.org/20392 .

It's on my todo. As said already, due to health problems I still make
slow progress :-(

Best regards, Michael.