From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Richard Newsgroups: gmane.emacs.bugs Subject: bug#21201: 25.0.50; (buffer-modified-p) errors inside cl-letf Date: Thu, 06 Aug 2015 22:07:13 +0200 Message-ID: <87lhdo41vy.fsf@members.fsf.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1438891716 25755 80.91.229.3 (6 Aug 2015 20:08:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Aug 2015 20:08:36 +0000 (UTC) Cc: 21201@debbugs.gnu.org To: Artur Malabarba Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 06 22:08:24 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZNRSi-000842-6T for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Aug 2015 22:08:24 +0200 Original-Received: from localhost ([::1]:46506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNRSh-0002Pv-7a for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Aug 2015 16:08:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNRSY-0002OG-5i for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2015 16:08:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNRSM-0002Z2-Gq for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2015 16:08:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNRSM-0002Yp-DY for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2015 16:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZNRSM-00081D-5z for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2015 16:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Aug 2015 20:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21201-submit@debbugs.gnu.org id=B21201.143889164030772 (code B ref 21201); Thu, 06 Aug 2015 20:08:02 +0000 Original-Received: (at 21201) by debbugs.gnu.org; 6 Aug 2015 20:07:20 +0000 Original-Received: from localhost ([127.0.0.1]:41433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZNRRg-00080G-04 for submit@debbugs.gnu.org; Thu, 06 Aug 2015 16:07:20 -0400 Original-Received: from mxin.ulb.ac.be ([164.15.128.112]:36964) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZNRRd-000805-Fb for 21201@debbugs.gnu.org; Thu, 06 Aug 2015 16:07:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ag0FAM69w1WkD4Xx/2dsb2JhbABbgkmCD4JVpxEGmzECghQBAQEBAQGBC4QkAQEDASdSBQsIAw4TJQ8BBA08E4gZAwoIyQ4NhSwBAQEBAQUBAQEBHoYfhTCCT4I6B4QsAQSHHIU1iDCKbIo7iW6HMSaDfzwxAYJLAQEB Original-Received: from mathsrv4.ulb.ac.be (HELO localhost) ([164.15.133.241]) by smtp.ulb.ac.be with ESMTP; 06 Aug 2015 22:07:15 +0200 In-Reply-To: (Artur Malabarba's message of "Thu, 6 Aug 2015 20:47:34 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105334 Archived-At: Artur Malabarba writes: > From emacs -Q, run the following: > > (cl-letf (((buffer-modified-p))) > (insert "ookok")) > > You'll get an error from trying to set a nil buffer. Here is a fix: --8<---------------cut here---------------start------------->8--- modified lisp/emacs-lisp/cl-lib.el @@ -634,8 +634,10 @@ If ALIST is non-nil, the new pairs are prepended to it." ;; Some more Emacs-related place types. (gv-define-simple-setter buffer-file-name set-visited-file-name t) (gv-define-setter buffer-modified-p (flag &optional buf) - `(with-current-buffer ,buf - (set-buffer-modified-p ,flag))) + (if buf + `(with-current-buffer ,buf + (set-buffer-modified-p ,flag)) + `(set-buffer-modified-p ,flag))) (gv-define-simple-setter buffer-name rename-buffer t) (gv-define-setter buffer-string (store) `(insert (prog1 ,store (erase-buffer)))) --8<---------------cut here---------------end--------------->8--- -- Nico