From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24815: 25.1; emacs could hang whith hs-minor-mode and python-mode Date: Tue, 01 Nov 2016 23:57:54 -0400 Message-ID: <87lgx2pm7x.fsf@users.sourceforge.net> References: <1234264807.1473759.1477672511527.JavaMail.zimbra@laposte.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1478059109 1348 195.159.176.226 (2 Nov 2016 03:58:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 Nov 2016 03:58:29 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24815@debbugs.gnu.org To: gilles.naulin@laposte.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 02 04:58:25 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1mgk-0006FB-Fp for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Nov 2016 04:58:10 +0100 Original-Received: from localhost ([::1]:52418 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1mgn-0003kX-84 for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Nov 2016 23:58:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1mgg-0003iW-5M for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2016 23:58:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1mgd-00023k-4D for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2016 23:58:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52498) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1mgd-00023Z-05 for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2016 23:58:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c1mgc-00038z-Gj for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2016 23:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2016 03:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24815-submit@debbugs.gnu.org id=B24815.147805903912026 (code B ref 24815); Wed, 02 Nov 2016 03:58:02 +0000 Original-Received: (at 24815) by debbugs.gnu.org; 2 Nov 2016 03:57:19 +0000 Original-Received: from localhost ([127.0.0.1]:39664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1mfv-00037p-AI for submit@debbugs.gnu.org; Tue, 01 Nov 2016 23:57:19 -0400 Original-Received: from mail-it0-f54.google.com ([209.85.214.54]:37556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1mft-00037V-ND; Tue, 01 Nov 2016 23:57:18 -0400 Original-Received: by mail-it0-f54.google.com with SMTP id u205so13624534itc.0; Tue, 01 Nov 2016 20:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Qu2bM1+eYVLrp2Sq4xzL4LgZbtISBJEBdD7YybGglcs=; b=CJo39xM8H/2FcUrwKxeBF2lr8a2fqe4NTk8XpTzRr4m4t7SXVWTsJ2BT9I14S1fbx2 dv325Sx4kwjlwgRgmtoENORX8dHF62ReqK4vU9F7XdoDzHzjhgIt4H/vbVjjFXCd3SJ4 rxc8SZWF9xfMTr1mIkcfHUOJFvgLmmZ5j5DgRIS8XVn9qRllHrTU2mckn6eCbYsHOCug IirBiQYJ4JMUa+pKbKH3KXVP6SO4xdVgKCfyfeTmNqAgo3m7RMKKFexzDVJ6E3WKXJVK IEqAlyUgyZi2zSWWuJTCkIGqxwMJmK2Bux3SdiPcO1/ejgxMtfdMNfZHP8J5zbC5vvar JlZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Qu2bM1+eYVLrp2Sq4xzL4LgZbtISBJEBdD7YybGglcs=; b=VLorWP2Qw52GEEprSzxrZL34At8naebz/Zs7qE55E3Dk1H0b+4/Wd92b2R49bMyA17 jDD5qYlPUREUDyGPy3F6n5U3/KYAWCWGZGpgnkmG0XlJqfrFkoSrrqaUC8QQRoWm1usn Xb/r0r4WkdhUX4eZi5tC2fGMTuJAI1qeJZqDtwBO1RPinhVBvDNUregh5h5GCGXHZ2Sq YfnOpe9s+iJlvY2nCAML9tC7PGCuU59tP4FfSoxzw5bXsTdNuTiUOZ2fCBMb0oo4U8tT MYHM0ODBt3amRRqRvav39i/E2tO6s2gaIjdqc82O6+URE4L21/7LwiwrEIOM3cUFhcah YNkQ== X-Gm-Message-State: ABUngvchCpK2fnybbj2jmDuiP1UjodojSB/pmDPjYcU6lOUZi78gXo5pmYnhq+89FmMKaw== X-Received: by 10.36.103.201 with SMTP id u192mr993548itc.3.1478059032010; Tue, 01 Nov 2016 20:57:12 -0700 (PDT) Original-Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id c34sm11761611itd.3.2016.11.01.20.57.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Nov 2016 20:57:11 -0700 (PDT) In-Reply-To: <1234264807.1473759.1477672511527.JavaMail.zimbra@laposte.net> (gilles naulin's message of "Fri, 28 Oct 2016 18:35:11 +0200 (CEST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125254 Archived-At: --=-=-= Content-Type: text/plain tags 24815 patch quit gilles.naulin@laposte.net writes: > gives > "\\s-*\\(?:def\\|class\\)\\>" in version 25.1 > instead of > "^\\s-*\\(?:def\\|class\\)\\>" in version 24.5 > > if I change it by "^\\s-*\\(?:def\\|class\\)\\>" or by > "\\_<\\(?:def\\|class\\)\\_>" > hs-minor-mode works fine with python-mode I guess removing the ^ would cause the issue described in #19761 to recur, but adding \\_< makes sense. I will apply the following patch to emacs-25 in a few days unless there are objections. --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=v1-0001-Fix-python-mode-hideshow-regexp.patch Content-Description: patch >From df7501fbb0b076bdc9a033c0cce239adfc74560a Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Tue, 1 Nov 2016 23:24:33 -0400 Subject: [PATCH v1] Fix python-mode hideshow regexp 2015-02-07 "Fix hideshow integration[...]" changed the regexp added to `hs-special-modes-alist' so that it worked when not searching from the beginning of the line. However, this allows matching tokens ending in "def" or "class", not just those keywords. This results in an infinite loop in hs-hide-all (Bug #24815). * lisp/progmodes/python.el (python-mode): Add symbol boundaries around the def|class matching part of the regexp added to hs-special-modes-alist. --- lisp/progmodes/python.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index 49f7bcf..e5efc2b 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -5136,7 +5136,7 @@ python-mode (add-to-list 'hs-special-modes-alist `(python-mode - "\\s-*\\(?:def\\|class\\)\\>" + "\\s-*\\_<\\(?:def\\|class\\)\\_>" ;; Use the empty string as end regexp so it doesn't default to ;; "\\s)". This way parens at end of defun are properly hidden. "" -- 2.9.3 --=-=-=--