From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Politz Newsgroups: gmane.emacs.bugs Subject: bug#26126: 26.0.50; file-notify-rm-watch removes arbitrary watches Date: Sat, 18 Mar 2017 14:32:08 +0100 Message-ID: <87lgs2sobr.fsf@luca> References: <87r31x9ulw.fsf@luca> <87shmcney8.fsf@detlef> <87efxw7xvc.fsf@luca> <87mvcjophx.fsf@detlef> <87tw6rssoi.fsf@luca> <87pohfkmvh.fsf@detlef> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489843998 21877 195.159.176.226 (18 Mar 2017 13:33:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Mar 2017 13:33:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 26126@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 18 14:33:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpETi-0004Vy-Ul for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Mar 2017 14:33:07 +0100 Original-Received: from localhost ([::1]:53372 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpETo-0007wJ-OH for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Mar 2017 09:33:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpETi-0007w2-6s for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 09:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpETf-0003H9-2b for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 09:33:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cpETe-0003H5-ON for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 09:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cpETe-0004hN-HX for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 09:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Politz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2017 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26126-submit@debbugs.gnu.org id=B26126.148984395018021 (code B ref 26126); Sat, 18 Mar 2017 13:33:02 +0000 Original-Received: (at 26126) by debbugs.gnu.org; 18 Mar 2017 13:32:30 +0000 Original-Received: from localhost ([127.0.0.1]:33353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpET7-0004gb-Va for submit@debbugs.gnu.org; Sat, 18 Mar 2017 09:32:30 -0400 Original-Received: from gateway-a.fh-trier.de ([143.93.54.181]:58917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpET6-0004gO-Iq for 26126@debbugs.gnu.org; Sat, 18 Mar 2017 09:32:29 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Original-Received: from localhost (unknown [95.91.222.207]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id C7809179B3AD; Sat, 18 Mar 2017 14:32:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1489843928; bh=h50xmUXB5pZpPhlPD0d2UMXzT9g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=OMn7r3hZw3OGHE8Od9Z2/ZdF7+amj6eR6cgUIxb7hq98ZMAzeX5FJzCyyy52yn31I MJAz88jwsQqfxiVVx5XwGfknBiNT/N3vN6Of8GeYgvjU8q6u1XJ6IRTXf6t0vQmGB8 zjwe/AbiO1FL2ksQ8yM1N+rDtSPSuPzYJT2je8xs= In-Reply-To: <87pohfkmvh.fsf@detlef> (Michael Albinus's message of "Sat, 18 Mar 2017 09:30:42 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130692 Archived-At: Michael Albinus writes: > Andreas Politz writes: >> A different question is, whether file-notify-add-watch should behave >> like add-hook [...] > > I believe adding the *same* function twice for the same file/directory > doesn't make sense. Maybe we should document this in the Elisp manual, > and test it also in `file-notify-test01-add-watch'. There is a check for this in file-notify-add-watch: (unless (member entry (cdr registered)) (puthash desc ... file-notify-descriptors)) So, I should probably stay this way. (Even so, one might favor it being differently, because file-notify-add-watch returns a cookie and thus has more like a transactional semantics, for lack of a better word). I took a deeper look filenotify.el and found some problems/have some further questions. Note that I use inotify. + A watched hard-link for some other file may not receive its events, due to string-equal being used for file-comparisons. Shouldn't file-equal be used instead ? + Watching a /dir/file may receive events (e.g. touch /dir) for dir. + Why the seemingly arbitrary exclusion of backup-files in file-notify-callback ? What if someone wants to track the creation of said files ? + Why is the existence of kqueue checked for the handler in file-notify-add-watch ? After all we don't know how this handler will operate. -ap