From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#26070: 26.0.50; js-mode slash insertion bug Date: Wed, 22 Mar 2017 16:18:22 -0600 Message-ID: <87lgrx0xch.fsf@tromey.com> References: <87wpbt8ev3.fsf@pokyo> <87fuig86ed.fsf@pokyo> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490221161 26434 195.159.176.226 (22 Mar 2017 22:19:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Mar 2017 22:19:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 26070@debbugs.gnu.org, Tom Tromey , Dmitry Gutov To: Richard Copley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 22 23:19:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqob0-0005l5-Ag for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Mar 2017 23:19:10 +0100 Original-Received: from localhost ([::1]:53511 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqob5-0000eF-Vg for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Mar 2017 18:19:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqoay-0000dV-CZ for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2017 18:19:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqoas-0001rO-HH for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2017 18:19:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cqoas-0001r7-EW for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2017 18:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cqoas-0005Ds-1m for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2017 18:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Mar 2017 22:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26070 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26070-submit@debbugs.gnu.org id=B26070.149022112420039 (code B ref 26070); Wed, 22 Mar 2017 22:19:01 +0000 Original-Received: (at 26070) by debbugs.gnu.org; 22 Mar 2017 22:18:44 +0000 Original-Received: from localhost ([127.0.0.1]:39876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqoaZ-0005D9-Uh for submit@debbugs.gnu.org; Wed, 22 Mar 2017 18:18:44 -0400 Original-Received: from gproxy8-pub.mail.unifiedlayer.com ([67.222.33.93]:43071) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cqoaY-0005Cx-Ox for 26070@debbugs.gnu.org; Wed, 22 Mar 2017 18:18:43 -0400 Original-Received: (qmail 24092 invoked by uid 0); 22 Mar 2017 22:18:31 -0000 Original-Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy8.mail.unifiedlayer.com with SMTP; 22 Mar 2017 22:18:31 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id zAJS1u00S2f2jeq01AJVca; Wed, 22 Mar 2017 16:18:31 -0600 X-Authority-Analysis: v=2.1 cv=WOnsABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=6Iz7jQTuP9IA:10 a=WiVod9pSvdkA:10 a=pGLkceISAAAA:8 a=YIav_BNCZuY3VWfh3wwA:9 a=6kGIvZw6iX1k4Y-7sg4_:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=41bBYHIPdfBdjlq+fpZoFj+qxGXWaz4ZsMRdbFLwAGI=; b=PBSpGWaX+RATDBw9yRRrjuwyoM tCNLtHyHm6XC6xExDKLS1/qZ+YqvCQpdohSR/bbsCshu1RDh11zlz567AujRw1xWMIEmwTfsd0u6l Jxk5xKPIfRuWL4PgSxdc3eXu4; Original-Received: from 97-118-172-192.hlrn.qwest.net ([97.118.172.192]:52446 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cqoaI-0007cA-45; Wed, 22 Mar 2017 16:18:26 -0600 X-Attribution: Tom In-Reply-To: (Richard Copley's message of "Sun, 19 Mar 2017 11:22:32 +0000") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.172.192 X-Exim-ID: 1cqoaI-0007cA-45 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-172-192.hlrn.qwest.net (bapiya) [97.118.172.192]:52446 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130829 Archived-At: >>>>> "Richard" == Richard Copley writes: Richard> Caught one! Thank you. Richard> Insert the text below in a JS-mode buffer, go to the beginning of the Richard> blank first line in function h() and type "/". There is an infloop. How did you find this? I'm very curious. Anyway, please try this patch on top of the previous one I sent. Or if you'd prefer I can send a combined patch. Tom diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index fa865db..c220353 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -1722,12 +1722,13 @@ js-syntax-propertize-regexp (when (eq (nth 3 ppss) ?/) ;; A /.../ regexp. (goto-char (nth 8 ppss)) - (when (and (looking-at js--syntax-propertize-regexp-regexp) - ;; Don't touch text after END. - (or (not (match-end 1)) (<= (match-end 1) end))) - (put-text-property (match-beginning 1) (or (match-end 1) (match-end 0)) + (when (looking-at js--syntax-propertize-regexp-regexp) + ;; Don't touch text after END. + (when (> end (match-end 1)) + (setq end (match-end 1))) + (put-text-property (match-beginning 1) end 'syntax-table (string-to-syntax "\"/")) - (goto-char (match-end 0)))))) + (goto-char end))))) (defun js-syntax-propertize (start end) ;; JavaScript allows immediate regular expression objects, written /.../.