From: Pierre Neidhardt <ambrevar@gmail.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 29157@debbugs.gnu.org
Subject: bug#29157: 25.3; Eshell parsing fails sometimes, e.g. "date" and "sed"
Date: Sun, 05 Nov 2017 15:16:33 +0100 [thread overview]
Message-ID: <87lgjkoloe.fsf@gmail.com> (raw)
In-Reply-To: <87lgjk7rpd.fsf@users.sourceforge.net>
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> Pierre Neidhardt <ambrevar@gmail.com> writes:
>
>> - emacs -Q
>> - M-x eshell
>>
>> > date +%Z
>> Invalid time specification
>
> ~/src/emacs $ which date
> eshell/date is an alias for ‘current-time-string’ in ‘em-unix.el’.
> ~/src/emacs $ which *date
> /bin/date
> ~/src/emacs $ *date +%Z
> EST
Duh! That was stupid, sorry. Anyways, that might ring an alarm here:
maybe eshell/date should not exist. What's the point of having it? I'm
not sure. It is obviously less powerful than the system `date'.
>> > echo $PATH | sed "s/[^o]foo[^o]/bar/g"
>> Unknown predicate character ‘b’
>
> M-x toggle-debug-on-error gives more hints about this. Apparently this
> matches a "history reference":
>
> (defun eshell-history-reference (reference)
> "Expand directory stack REFERENCE.
> The syntax used here was taken from the Bash info manual.
> Returns the resultant reference, or the same string REFERENCE if none
> matched."
> ;; `^string1^string2^'
> ;; Quick Substitution. Repeat the last command, replacing
> ;; STRING1 with STRING2. Equivalent to `!!:s/string1/string2/'
>
> Debugger entered--Lisp error: (error "Unknown predicate character ‘b’")
> signal(error ("Unknown predicate character ‘b’"))
> error("Unknown predicate character `%c'" 98)
> eshell-parse-modifiers()
> eshell-hist-parse-modifier("printf '<<%s>>\\n' \"s/[^o]foo/\"" ":s/o]foo[/o]/bar/g\"/")
> eshell-history-reference("\"s/[^o]foo[^o]/bar/g\"")
> eshell-expand-history-references(#<marker at 43 in *eshell*> 81)
> run-hook-with-args(eshell-expand-history-references #<marker at 43 in *eshell*> 81)
> eshell-send-input(nil)
> funcall-interactively(eshell-send-input nil)
> call-interactively(eshell-send-input nil nil)
> command-execute(eshell-send-input)
>
>
> My suggestion for this is just to stop adding
> eshell-expand-history-references to eshell-expand-input-functions, and
> maybe even deprecate eshell-expand-history-references. I find the
> history expansion mechanism to be an annoyance in bash as well.
>
> --- i/lisp/eshell/em-hist.el
> +++ w/lisp/eshell/em-hist.el
> @@ -218,9 +218,6 @@ eshell-input-filter-initial-space
>
> (defun eshell-hist-initialize ()
> "Initialize the history management code for one Eshell buffer."
> - (add-hook 'eshell-expand-input-functions
> - 'eshell-expand-history-references nil t)
> -
> (when (eshell-using-module 'eshell-cmpl)
> (add-hook 'pcomplete-try-first-hook
> 'eshell-complete-history-reference nil t))
That does it for me. I did not even know this feature existed. I'd it
proves more useful in an environment with poor selection / editing
capabilities, i.e. a terminal shell. Emacs does not need that when you
can fuzzy-search your history and modify your prompt with arbitrary
bindings / Lisp code.
--
Pierre Neidhardt
There are more things in heaven and earth than any place else.
next prev parent reply other threads:[~2017-11-05 14:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 11:37 bug#29157: 25.3; Eshell parsing fails sometimes, e.g. "date" and "sed" Pierre Neidhardt
2017-11-05 13:58 ` Noam Postavsky
2017-11-05 14:16 ` Pierre Neidhardt [this message]
2017-11-23 3:13 ` Noam Postavsky
2017-11-23 6:55 ` Pierre Neidhardt
2017-11-23 12:59 ` Noam Postavsky
2017-11-23 16:26 ` Eli Zaretskii
2017-11-25 17:54 ` Pierre Neidhardt
2017-11-25 18:32 ` Michael Albinus
2017-11-25 18:35 ` Pierre Neidhardt
2017-11-25 18:50 ` Noam Postavsky
2017-11-25 19:50 ` Eli Zaretskii
2017-11-25 20:06 ` Noam Postavsky
2017-11-25 20:25 ` Eli Zaretskii
2017-11-25 21:41 ` Noam Postavsky
2017-11-26 3:35 ` Eli Zaretskii
2017-11-26 3:21 ` John Wiegley
2017-11-26 15:35 ` Eli Zaretskii
2017-11-26 21:44 ` John Wiegley
2017-11-25 19:29 ` Eli Zaretskii
2017-11-25 19:36 ` Pierre Neidhardt
2017-11-25 19:57 ` Eli Zaretskii
2017-11-26 9:17 ` Pierre Neidhardt
2017-11-26 15:53 ` Eli Zaretskii
2017-11-26 3:21 ` John Wiegley
2017-11-26 15:33 ` Eli Zaretskii
2017-11-26 21:45 ` John Wiegley
2017-11-27 3:32 ` Eli Zaretskii
2017-12-21 8:17 ` John Wiegley
2017-12-03 20:43 ` Noam Postavsky
2017-12-04 8:43 ` John Wiegley
2017-12-04 12:51 ` Noam Postavsky
2017-11-05 15:16 ` Andreas Schwab
2017-11-10 2:04 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgjkoloe.fsf@gmail.com \
--to=ambrevar@gmail.com \
--cc=29157@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).