From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29157: 25.3; Eshell parsing fails sometimes, e.g. "date" and "sed" Date: Sun, 05 Nov 2017 08:58:22 -0500 Message-ID: <87lgjk7rpd.fsf@users.sourceforge.net> References: <87tvy9rm5z.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1509890358 22260 195.159.176.226 (5 Nov 2017 13:59:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Nov 2017 13:59:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29157@debbugs.gnu.org To: Pierre Neidhardt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 05 14:59:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBLSC-0005Ya-Eu for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Nov 2017 14:59:12 +0100 Original-Received: from localhost ([::1]:44348 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBLSI-0007rq-AV for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Nov 2017 08:59:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBLS6-0007qS-38 for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 08:59:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBLS2-0005Ud-N8 for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 08:59:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42666) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBLS2-0005UZ-JT for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 08:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eBLS2-0007Ve-Ck for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 08:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Nov 2017 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29157-submit@debbugs.gnu.org id=B29157.150989031228807 (code B ref 29157); Sun, 05 Nov 2017 13:59:02 +0000 Original-Received: (at 29157) by debbugs.gnu.org; 5 Nov 2017 13:58:32 +0000 Original-Received: from localhost ([127.0.0.1]:51343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBLRY-0007UY-4k for submit@debbugs.gnu.org; Sun, 05 Nov 2017 08:58:32 -0500 Original-Received: from mail-it0-f49.google.com ([209.85.214.49]:51050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBLRW-0007UL-LJ for 29157@debbugs.gnu.org; Sun, 05 Nov 2017 08:58:30 -0500 Original-Received: by mail-it0-f49.google.com with SMTP id 72so2389061itl.5 for <29157@debbugs.gnu.org>; Sun, 05 Nov 2017 05:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=vV9i6f8ggnxA/g83ymOf8N9gpLapJiJ7rdXqYrkykXw=; b=JmSlDBHY1ErY/4QX5lBNSiYicks8w/sgIPFaVZ2qv5EAPKMz6jg4Cw04T0GlgwEIXx 9/Y9WOsTGOYrCbOzFu90GL4esvE/gm8aTllkHg8ufAndOyhT8zrQh2BnrVR8EDNbQh8E qOXUshD7n6oBGYqEL+krryOHSbqfKSUlIKOLp5HzKa8yfuzztkBrdBZGBX0oEg4ngRDC gZoxUNvl0IT/yWi/iGecKms7NhZ1KVXdq0/E0TcfGPtDE3Po/dPom5B2H5euBnTP7QZq 6iknLfdyw5ePnRSokHCxbG1ntlrf8Pxbd3ot0+zKVjBxaSQ7TTX4iYg2QNmQoEmdJJrJ nzxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=vV9i6f8ggnxA/g83ymOf8N9gpLapJiJ7rdXqYrkykXw=; b=IELfcoGHykpa98PqqccZzJy/+hvpLsMGDx6jqGWI30sPndj8IFd27Ol0fNYFlB3L4j ywoiFLrHZfOduhTZoohtDfa1Hp2S9HZQ0J8UfBRICfp19eKQMusKjXZrMnl/IGgdl0cM 9qj0KiBCWcNCqVS5WEj1Zu71kNLJzUocI6cTh9onzo/r3odXuzCsGXw9UgHJm0DEGLMp O26LKaCPaL0Y1gG6nWXdPXysoMQtJNfEOqgV7b0jyCdtNlgc0G75+gkMd/Eyjjx+Wv66 vvzF3V4aoOaN8pa+jthgaVvGP+yN93nmfAd9yyiHOHt/GMSbKt9zk8TojTtPM2jske00 5r4g== X-Gm-Message-State: AJaThX7lMTZEtbCM9CbXhr/aeMGgUqFGMKcH8lTh+6/lHre8Q/vgdWnG WatFiRLA8vPT5tpKbchTnpdyLA== X-Google-Smtp-Source: ABhQp+TUD83oe8xGDcQLl9ImJWPBoUBWv2+Dni6GNLC28mdgVXeMxJJgiBY6e+7aFeusfVVLrbQ5qA== X-Received: by 10.36.9.144 with SMTP id 138mr6071816itm.106.1509890304772; Sun, 05 Nov 2017 05:58:24 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e89sm4242390itd.3.2017.11.05.05.58.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Nov 2017 05:58:23 -0800 (PST) In-Reply-To: <87tvy9rm5z.fsf@gmail.com> (Pierre Neidhardt's message of "Sun, 05 Nov 2017 12:37:44 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139459 Archived-At: Pierre Neidhardt writes: > - emacs -Q > - M-x eshell > > > date +%Z > Invalid time specification ~/src/emacs $ which date eshell/date is an alias for =E2=80=98current-time-string=E2=80=99 in = =E2=80=98em-unix.el=E2=80=99. ~/src/emacs $ which *date /bin/date ~/src/emacs $ *date +%Z EST > > echo $PATH | sed "s/[^o]foo[^o]/bar/g" > Unknown predicate character =E2=80=98b=E2=80=99 M-x toggle-debug-on-error gives more hints about this. Apparently this matches a "history reference": (defun eshell-history-reference (reference) "Expand directory stack REFERENCE. The syntax used here was taken from the Bash info manual. Returns the resultant reference, or the same string REFERENCE if none matched." ;; `^string1^string2^' ;; Quick Substitution. Repeat the last command, replacing ;; STRING1 with STRING2. Equivalent to `!!:s/string1/string2/' Debugger entered--Lisp error: (error "Unknown predicate character =E2=80=98= b=E2=80=99") signal(error ("Unknown predicate character =E2=80=98b=E2=80=99")) error("Unknown predicate character `%c'" 98) eshell-parse-modifiers() eshell-hist-parse-modifier("printf '<<%s>>\\n' \"s/[^o]foo/\"" ":s/o]foo[= /o]/bar/g\"/") eshell-history-reference("\"s/[^o]foo[^o]/bar/g\"") eshell-expand-history-references(# 81) run-hook-with-args(eshell-expand-history-references # 81) eshell-send-input(nil) funcall-interactively(eshell-send-input nil) call-interactively(eshell-send-input nil nil) command-execute(eshell-send-input) My suggestion for this is just to stop adding eshell-expand-history-references to eshell-expand-input-functions, and maybe even deprecate eshell-expand-history-references. I find the history expansion mechanism to be an annoyance in bash as well. --- i/lisp/eshell/em-hist.el +++ w/lisp/eshell/em-hist.el @@ -218,9 +218,6 @@ eshell-input-filter-initial-space =20 (defun eshell-hist-initialize () "Initialize the history management code for one Eshell buffer." - (add-hook 'eshell-expand-input-functions - 'eshell-expand-history-references nil t) - (when (eshell-using-module 'eshell-cmpl) (add-hook 'pcomplete-try-first-hook 'eshell-complete-history-reference nil t))