From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#29303: 25.2; vc-git-grep should shell-escape FILES Date: Wed, 15 Nov 2017 21:36:09 +0100 Message-ID: <87lgj7nuti.fsf@gmail.com> References: <87efoz983o.fsf@gmail.com> <83d14jjv5y.fsf@gnu.org> <87375fpehr.fsf@gmail.com> <837eurjoue.fsf@gnu.org> <87tvxvnvog.fsf@gmail.com> <83y3n7i90b.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1510778243 22797 195.159.176.226 (15 Nov 2017 20:37:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Nov 2017 20:37:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29303@debbugs.gnu.org, gus@inodes.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 15 21:37:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eF4Qn-00056y-Q0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Nov 2017 21:37:09 +0100 Original-Received: from localhost ([::1]:37749 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eF4Qs-0003tK-9A for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Nov 2017 15:37:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eF4Qj-0003s9-0C for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2017 15:37:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eF4Qg-0005eD-C7 for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2017 15:37:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33510) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eF4Qg-0005e5-7o for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2017 15:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eF4Qg-0002jl-1O for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2017 15:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2017 20:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29303 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29303-submit@debbugs.gnu.org id=B29303.151077817910473 (code B ref 29303); Wed, 15 Nov 2017 20:37:01 +0000 Original-Received: (at 29303) by debbugs.gnu.org; 15 Nov 2017 20:36:19 +0000 Original-Received: from localhost ([127.0.0.1]:42191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eF4Pz-0002iq-Hi for submit@debbugs.gnu.org; Wed, 15 Nov 2017 15:36:19 -0500 Original-Received: from mail-wm0-f49.google.com ([74.125.82.49]:33994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eF4Px-0002ie-9c for 29303@debbugs.gnu.org; Wed, 15 Nov 2017 15:36:17 -0500 Original-Received: by mail-wm0-f49.google.com with SMTP id n74so23017375wmi.1 for <29303@debbugs.gnu.org>; Wed, 15 Nov 2017 12:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:user-agent:mime-version; bh=XdNsLVacgg3lD/yXrXrfSWO2IznWEGQFwsP0bnPBkEI=; b=eJuYEmplf42JWZqeQC3npWeUh7juLAQVN0h6ai58uAmMw7hUI61A5NpuGQv4UZbImR li4hepSP0mWlZ4ESmP9IrLeQtZnR3btBJ4udHUXGa2qgXBFbihHNcxeqpRSkXA9qjklo SFt8qWyJ0w/ZbZkamc4g9m2qQ88sGxU4rdkHlqSww77uT2zJPPN3Zd7FQPqUmhc6Xg+C FzXjQ5FuxklZ74o2ZLdG7bZoLLzt4n2/aobz90w2NN1o3V0ZqLKLH5A7t3zs/0BgRKHJ b3yGv9vd2rlPIG5sZiWN0Y97U6tGihX0IRtj5lmfU61NCQy3PkPiIQhIFXXFNmO1DaeL zPmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=XdNsLVacgg3lD/yXrXrfSWO2IznWEGQFwsP0bnPBkEI=; b=VEstHNdZu5wNlSudz0cMMBB5diMcYCXN+UqGCcgTyLH+OdrOLOjuwcSoT6WWMvJR1B XNRwezC6SKdk1W8KOevTh/bZEwSiplT7ZuUP+Sepa0U/7zvIEapyLrnPNPOoB0ExEZOe o+SyNq+d9JM2uPl6Jr9Qom6Wf6qU7/fPz8Rv0c8/M012ttovyOpr0QXxTW5SSt99eniR TWl2Ruzde7OKamjM0Pjs5v4nlGprrBwFEsXUz3zk2DKtmARibRAZUx/L5lGPc8cTj+Ip TOAI+7a8eW8kLKkT6QfLnI0sJdHpILSiZVDHk6UyvK0eBgkMs9noDKO9DV20LonjQgug glmw== X-Gm-Message-State: AJaThX6JZnp46l6tudLFN2yj6wM45rci06drZp4w1iQheIGT41d74JA8 Sz30dRzol/XUjpCC1Uhcb6Y= X-Google-Smtp-Source: AGs4zMaED/O54RngtRUgDAZa0rfuk6rAw/zG8XxwSWC/VA3uL5EyASc0xHcBrRDUfbzGF2a9RgdDkg== X-Received: by 10.80.221.199 with SMTP id x7mr17325839edk.180.1510778171401; Wed, 15 Nov 2017 12:36:11 -0800 (PST) Original-Received: from rpluim ([2a01:e34:ecfc:a090:1874:a2a8:70da:f879]) by smtp.gmail.com with ESMTPSA id x38sm18539216edd.94.2017.11.15.12.36.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Nov 2017 12:36:10 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <83y3n7i90b.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Nov 2017 22:26:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139941 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: 29303@debbugs.gnu.org, gus@inodes.org >> Date: Wed, 15 Nov 2017 21:17:35 +0100 >> >> > That's okay portability-wise, but why do you need split-string? >> > AFAIU, grep-read-files reads a single pattern, no? >> >> grep-read-files has support for grep-files-aliases which allows you to >> eg say 'cc' and have it expand to "*.cc *.cxx *.cpp *.C *.CC *.c++" > > Ah. So we lose support of patterns with embedded whitespace in order > to support the aliases? Is that desirable? That's a good question. Note that interactively entering patterns with a space is currently a pain, since grep-read-files uses read-file-name-internal, which attempts to do completion if you type . So this would presumably only affect people who have changed grep-files-aliases and have patterns with embedded whitespace. Robert