From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#29456: [PATCH] Add command for cycling between CSS color formats Date: Tue, 28 Nov 2017 19:33:30 +0100 Message-ID: <87lgiqmex1.fsf@gmail.com> References: <1511709711.2341.0@smtp.gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1511894165 7981 195.159.176.226 (28 Nov 2017 18:36:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Nov 2017 18:36:05 +0000 (UTC) Cc: 29456@debbugs.gnu.org, tom@tromey.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 28 19:36:01 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJkjf-0001Xq-Qp for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Nov 2017 19:36:00 +0100 Original-Received: from localhost ([::1]:39547 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJkjl-0000Co-A7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Nov 2017 13:36:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJkhq-0007Ka-OO for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 13:34:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJkhm-0002WI-Jn for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 13:34:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54605) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJkhm-0002W0-H6 for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 13:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJkhm-0007ja-5t for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 13:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Nov 2017 18:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29456 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29456-submit@debbugs.gnu.org id=B29456.151189402129698 (code B ref 29456); Tue, 28 Nov 2017 18:34:02 +0000 Original-Received: (at 29456) by debbugs.gnu.org; 28 Nov 2017 18:33:41 +0000 Original-Received: from localhost ([127.0.0.1]:35053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJkhR-0007iv-Ii for submit@debbugs.gnu.org; Tue, 28 Nov 2017 13:33:41 -0500 Original-Received: from mail-lf0-f49.google.com ([209.85.215.49]:41312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJkhP-0007ig-G3 for 29456@debbugs.gnu.org; Tue, 28 Nov 2017 13:33:39 -0500 Original-Received: by mail-lf0-f49.google.com with SMTP id f18so904109lfg.8 for <29456@debbugs.gnu.org>; Tue, 28 Nov 2017 10:33:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:date:message-id:mime-version; bh=moCTQ4g+b87/Ubu2g5Q0f/XFCeXSHJR27X/ommkmRBg=; b=gxhPm94jrNYhUwIb4LyQtEjMe2KyMX3Ldq2fkiU8JrahXYtntR++S4HHjCaUKkthZr IsjDvT3lCKecCZTArYDwSQXNOUmZW2bWzHM63G+6Nz/Vz6JvVsS1ZWvK86pXAnNc/1Ve zkQtscxMiJU4qnytmGggZ8XKskpkblj2RgE0J9XQHu9r6wMhEEq918xW9aD8rmyqjBxv U02vNvq7EjJ9mL9BbahbUHNnx4xLt0VD5eOpF24LRSvWfYuICN5ukkf1jAYlqrG3L0Ud x5kr0YDzDDApeFdOb1OaWQMlumtopILRaSAQUVtmB83eg64ZsRK7zPtRxNvpACizHRdm mU1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :mime-version; bh=moCTQ4g+b87/Ubu2g5Q0f/XFCeXSHJR27X/ommkmRBg=; b=HUg87mJkYlTvN26dSzjbVqI7znwFNEKrmsst0N/P7miTslabL5ay6YKfvn187cxrep UY7JiVawGwZuq9toyfXZkUcMmdzcmWKF3VoDd1VvjnI3bfTuW0YfhIcJxxAmwgyDwrPg MdnxwJpMqjn5aFHhY2QOuaf+voKqmlmVGArQ23vtN1APQZehfGCuCN/6EdtwOzvAtERr KxdwWA1XIS52RT/fg4YkOxL1KD5V89tJYJAccHcxpuFlnLOMVUTMESAlCck4yalHXj6x q4ZbTKXaZWFBN7/4otGykDQw/5td3LfSrovwbWzgQcHAo0nOyvB48gtiTTXzixU9NVbM yg/A== X-Gm-Message-State: AJaThX4uLoJqZb/UxvkfOk01d1J51OomGVLdcUpabkc4tg50hWP31P4j 4muDliz79VhaD0zRA6k6QFk= X-Google-Smtp-Source: AGs4zMbmayw9wtcs1NOfv71m8eu1U4zwFGQLoiM2FLvVnBv2BfkF0b9ypl+ZZNntFPMwciMQbk/2ZA== X-Received: by 10.25.151.206 with SMTP id z197mr24165lfd.139.1511894013565; Tue, 28 Nov 2017 10:33:33 -0800 (PST) Original-Received: from x240 (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id t16sm6676341lje.81.2017.11.28.10.33.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Nov 2017 10:33:32 -0800 (PST) In-Reply-To: <83bmjn5zr9.fsf@gnu.org> (message from Eli Zaretskii on Mon, 27 Nov 2017 20:43:06 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140498 Archived-At: Tom Tromey writes: > Nice feature! Glad you like it! > It seems to me that none of the functions handle alpha components. > css-color-4 added optional alpha to hex colors (and made rgb and rgba > synonyms), and there's been rgba for a while... Right, it makes sense to support that too. I haven't used alpha formats other than rgba(...) myself. Would it be useful for rgba(255, 0, 0, 0.5) to turn into #ff000088, for instance? Eli Zaretskii writes: > Then I think there should be a prominent remark in the doc strings of > css-mode not to mix these functions with those from color.el, due to > this incompatibility. That sounds like a good idea. I'll address the comments from both of you in an update to the patch, though it might be a while until I have the time to update it. Thanks for your comments so far. -- Simen