unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#30557: 25.2; rendering of label elements in shr
@ 2018-02-20 21:19 Alex Schroeder
  2018-04-12 23:51 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Schroeder @ 2018-02-20 21:19 UTC (permalink / raw)
  To: 30557

Hi all

When using eww to browse alexschroeder.ch, I noticed the paragraph
break between the labels and the input fields at the top the page and I
think the way shr handles label elements is wrong.

This is what the master branch has:

(defun shr-tag-label (dom)
  (shr-generic dom)
  (shr-ensure-paragraph))

I think it should be:

(defun shr-tag-label (dom)
  (shr-generic dom))

What do you think?

Cheers
Alex





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#30557: 25.2; rendering of label elements in shr
  2018-02-20 21:19 bug#30557: 25.2; rendering of label elements in shr Alex Schroeder
@ 2018-04-12 23:51 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2018-04-12 23:51 UTC (permalink / raw)
  To: Alex Schroeder; +Cc: 30557

Alex Schroeder <kensanata@gmail.com> writes:

> This is what the master branch has:
>
> (defun shr-tag-label (dom)
>   (shr-generic dom)
>   (shr-ensure-paragraph))
>
> I think it should be:
>
> (defun shr-tag-label (dom)
>   (shr-generic dom))
>
> What do you think?

Yup.  I've now done something similar in Emacs 27.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-12 23:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-20 21:19 bug#30557: 25.2; rendering of label elements in shr Alex Schroeder
2018-04-12 23:51 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).