From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#18764: 24.4; electric-indent in *scratch* signals an error Date: Sat, 16 Jun 2018 19:13:29 -0400 Message-ID: <87lgbetjdy.fsf@gmail.com> References: <83a94te85b.fsf@gnu.org> <8736xowzes.fsf@gmail.com> <83tvq3ynmv.fsf@gnu.org> <87d0wqvo4d.fsf@gmail.com> <83muvuzsc8.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529190730 5079 195.159.176.226 (16 Jun 2018 23:12:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 23:12:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 18764@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 17 01:12:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUKMX-00017I-56 for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jun 2018 01:12:05 +0200 Original-Received: from localhost ([::1]:53140 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUKOc-0000Gr-St for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jun 2018 19:14:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUKOT-0000Gj-PK for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 19:14:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUKOQ-00041h-J7 for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 19:14:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44394) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUKOQ-00041d-G0 for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 19:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fUKOQ-0004VS-5H for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 19:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jun 2018 23:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 18764-submit@debbugs.gnu.org id=B18764.152919081817282 (code B ref 18764); Sat, 16 Jun 2018 23:14:02 +0000 Original-Received: (at 18764) by debbugs.gnu.org; 16 Jun 2018 23:13:38 +0000 Original-Received: from localhost ([127.0.0.1]:52291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUKO1-0004Uf-P1 for submit@debbugs.gnu.org; Sat, 16 Jun 2018 19:13:37 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:39742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUKO0-0004UQ-0b for 18764@debbugs.gnu.org; Sat, 16 Jun 2018 19:13:36 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id p185-v6so7416212itp.4 for <18764@debbugs.gnu.org>; Sat, 16 Jun 2018 16:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nx3J5iXcGQe5DhdUgRPJvhhMkvEVdDbG01yGrOeO4q4=; b=efJG+YeG6MnQnEEAsH2kqjk8JLY+whVGBDi3SCiKounBgogt7viFsCrOFehm8x1SXX 2ODTUkWSowC7DRjibXy28EnCoYrbuZxkXp7vs5fLPvin3tcN7KlkbGC0jHslEeSaLOCk qjoX7Mc5EoeyJy2KFqH6yUicbshK+AgtGmrFHM6vWduW8NDZeaWQ/Gf55xC31Rj1m3rv xL++0N4DsdoLYjxiyDwEPWNIOebzmoGYAfq23MnnAqq+Bv5CEoMf8tOv9GBTu7Nvzjqx eIc2J6lq9WrYrIQLZmhUiQ6BdGH+Dg3R/rAisFry4yF+FQFCwHQV5GqoKfLA6qOG32YW hrcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nx3J5iXcGQe5DhdUgRPJvhhMkvEVdDbG01yGrOeO4q4=; b=gDz/PXU6auBZzkRQa3bIJBTnUy6x1y5wrZ9ngmq01OHe+Yt4mRIsstd8VflUuvjTiH qKvXjMwa/h0PcT4jtk8LTZvjYN/EILT0GrGv2sORKlLseki3l/2JsoUypdl6futqjijT g93nkVpyIA08V7yOrPKacbKOWyzNeqyMTj2A+mBwENTQa0kPr9fhmMbxf7uG1dxil1/1 fhTyK4USs4prI6BUU2bE7UoHhImsFBRhRR3WL7NXtDQu2MCPa7HzHx2k0qfkzE1XUqlI i0enwTykgAnRb8IeJs+NmZ+K1rQqFJKXs7/F4WicxMDr43QCJ+EeA6/u4BOyQe3wNFf/ D3jg== X-Gm-Message-State: APt69E2PVJo5b6IFC1AXd9X/dzi6Msl8kqsQr4sA4CxRCbiwIm01TNGH SY/IIXs2chQpHxFeMaIPzVJIzzv5 X-Google-Smtp-Source: ADUXVKI/yzSw/9j/jbJ/YRBALmCwNGqrSGmpYWqJTUyYpOkCuwCiqOw+iM6Ipe1cDd+MfNT/VRM55A== X-Received: by 2002:a02:a198:: with SMTP id n24-v6mr5570549jah.61.1529190810476; Sat, 16 Jun 2018 16:13:30 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z85-v6sm3741714ita.1.2018.06.16.16.13.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Jun 2018 16:13:30 -0700 (PDT) In-Reply-To: <83muvuzsc8.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Jun 2018 18:03:35 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147547 Archived-At: Eli Zaretskii writes: > Then let me rephrase: why are we signaling an error instead of > silently doing nothing? IOW, if something cannot be indented, let's > leave it unindented. Does that make sense? So just suppress the errors? Worries me a bit that some future problems could be harder to find because of that. --- i/lisp/electric.el +++ w/lisp/electric.el @@ -262,6 +262,7 @@ electric-indent-post-self-insert-function (unless (eq act 'do-indent) (nth 8 (syntax-ppss)))))))) ;; For newline, we want to reindent both lines and basically behave like ;; reindent-then-newline-and-indent (whose code we hence copied). + (ignore-errors (let ((at-newline (<= pos (line-beginning-position)))) (when at-newline (let ((before (copy-marker (1- pos) t))) @@ -285,7 +286,7 @@ electric-indent-post-self-insert-function (delete-horizontal-space t))))) (unless (and electric-indent-inhibit (not at-newline)) - (indent-according-to-mode)))))) + (indent-according-to-mode)))))))