bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups

bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups

[Basil L. Contovounesios]

X-Debbugs-Cc: Roland Winkler <winkler@gnu.org>
Severity: minor

The file lisp/textmodes/bibtex.el seems to use both custom group names
'bibtex' and 'BibTeX':

0. emacs -Q
1. M-x customize-group RET
2. bibtex TAB TAB
   => BibTeX, bibtex, bibtex-autokey

The name 'BibTeX' is only used once and is never defined via defgroup,
however, so I presume it's just a typo introduced in Emacs 24.1:

[2de69e00f3]: 2011-07-05 12:44:15 -0500
  lisp/textmodes/bibtex.el: add support for biblatex
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2de69e00f3991d554d37327a2afd71b981d4e488

Thanks,

-- 
Basil

In GNU Emacs 26.1.50 (build 4, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-08-14 built on thunk
Repository revision: f882de8b8095c3a42d1f6d22ed3f7aed57e9f5e0
Windowing system distributor 'The X.Org Foundation', version 11.0.12000000
System Description:	Debian GNU/Linux testing (buster)

bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups

[Basil L. Contovounesios]

[-- Attachment #1: Type: text/plain, Size: 23 bytes --]

tags 32436 patch
quit


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-duplicate-custom-group-names-in-bibtex.el.patch --]
[-- Type: text/x-diff, Size: 1016 bytes --]

From 74fd192fb752188e41560034faea7601fcde6c6b Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Tue, 14 Aug 2018 15:05:25 +0300
Subject: [PATCH] Fix duplicate custom group names in bibtex.el

* lisp/textmodes/bibtex.el (bibtex-BibTeX-entry-alist): Change
:group from BibTeX to bibtex.  Bump :version. (bug#32436)
---
 lisp/textmodes/bibtex.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
index efab9d8e3b..f0125e7b41 100644
--- a/lisp/textmodes/bibtex.el
+++ b/lisp/textmodes/bibtex.el
@@ -457,8 +457,8 @@ bibtex-BibTeX-entry-alist
 which is called to determine the initial content of the field.
 ALTERNATIVE if non-nil is an integer that numbers sets of
 alternatives, starting from zero."
-  :group 'BibTeX
-  :version "26.1"                       ; add Conference
+  :group 'bibtex
+  :version "26.2"
   :type 'bibtex-entry-alist)
 (put 'bibtex-BibTeX-entry-alist 'risky-local-variable t)
 
-- 
2.18.0


[-- Attachment #3: Type: text/plain, Size: 208 bytes --]


I attach a patch which the presumed typo and then bumps the user
option's :version.  Is a change of custom group significant enough to
justify this, or should the :version be left alone?

Thanks,

-- 
Basil

bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups

[Noam Postavsky]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> I attach a patch which the presumed typo and then bumps the user
> option's :version.  Is a change of custom group significant enough to
> justify this, or should the :version be left alone?

I'd say no, since there is no need for users to review their settings of
this option because of this.  And if we look at the associated *Help*
text:

    This variable was introduced, or its default value was changed, in
    version 26.2 of Emacs.

That wouldn't be correct, since you haven't introduced, nor changed the
default value of the variable in your patch.

bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups

[Basil L. Contovounesios]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-Fix-duplicate-custom-group-names-in-bibtex.el.patch --]
[-- Type: text/x-diff, Size: 975 bytes --]

From 1ae2f6cba8bd03d64892b6e3d9aeb0200d3d9054 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Wed, 15 Aug 2018 10:03:23 +0300
Subject: [PATCH] Fix duplicate custom group names in bibtex.el

* lisp/textmodes/bibtex.el (bibtex-BibTeX-entry-alist):
Change :group from BibTeX to bibtex. (bug#32436)
---
 lisp/textmodes/bibtex.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
index efab9d8e3b..6294b8026c 100644
--- a/lisp/textmodes/bibtex.el
+++ b/lisp/textmodes/bibtex.el
@@ -457,7 +457,7 @@ bibtex-BibTeX-entry-alist
 which is called to determine the initial content of the field.
 ALTERNATIVE if non-nil is an integer that numbers sets of
 alternatives, starting from zero."
-  :group 'BibTeX
+  :group 'bibtex
   :version "26.1"                       ; add Conference
   :type 'bibtex-entry-alist)
 (put 'bibtex-BibTeX-entry-alist 'risky-local-variable t)
-- 
2.18.0


[-- Attachment #2: Type: text/plain, Size: 774 bytes --]


Noam Postavsky <npostavs@gmail.com> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> I attach a patch which the presumed typo and then bumps the user
>> option's :version.  Is a change of custom group significant enough to
>> justify this, or should the :version be left alone?
>
> I'd say no, since there is no need for users to review their settings of
> this option because of this.  And if we look at the associated *Help*
> text:
>
>     This variable was introduced, or its default value was changed, in
>     version 26.2 of Emacs.
>
> That wouldn't be correct, since you haven't introduced, nor changed the
> default value of the variable in your patch.

Fair enough; I've removed the :version change from the attached patch.

Thanks,

-- 
Basil

bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups

[Noam Postavsky]

tags 32436 fixed
close 32436 26.2
quit

"Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
> Fair enough; I've removed the :version change from the attached patch.

Pushed to emacs-26.

[1: 7bc9ce7431]: 2018-08-17 15:22:06 -0400
  Fix duplicate custom group names in bibtex.el
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7bc9ce7431ae6ab4e6828015f75caf1f2196a97c