From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 32790@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#32790: 27.0.50; point jumps unexpectedly after delete-window
Date: Thu, 08 Nov 2018 23:38:08 +0200 [thread overview]
Message-ID: <87lg63ntbz.fsf@mail.linkov.net> (raw)
In-Reply-To: <5BE3F967.8080809@gmx.at> (martin rudalics's message of "Thu, 08 Nov 2018 09:52:55 +0100")
>> Shouldn't xref support a shorter and easier to type key sequence
>> ‘S-M-<right> M-.’ with the following patch:
>>
>> diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
>> index 6b1421a6f7..6aab174bcf 100644
>> --- a/lisp/progmodes/xref.el
>> +++ b/lisp/progmodes/xref.el
>> @@ -425,7 +425,7 @@ xref--pop-to-location
>> (xref-location-marker (xref-item-location item))))
>> (buf (marker-buffer marker)))
>> (cl-ecase action
>> - ((nil) (switch-to-buffer buf))
>> + ((nil) (pop-to-buffer-same-window buf))
>> (window (pop-to-buffer buf t))
>> (frame (let ((pop-up-frames t)) (pop-to-buffer buf t))))
>> (xref--goto-char marker))
>
> I think so. In particular because 'xref--goto-char' does not cohabit
> well with 'switch-to-buffer-preserve-window-point' in the first place.
> Dmitry should consent, though.
Dmitry, do you agree this is a change for the better?
>> Then maybe all unused code should be removed including
>> windmove-other-window-loc, windmove-reference-loc,
>> windmove-wrap-loc-for-movement, windmove-constrain-loc-for-movement,
>> etc.
>
> Citing from a discussion with Dmitry:
>
> > I thought you might go ahead and just port windmove to use
> > `window-in-direction'.
>
> windmove has an extra ARG to distinguish the upper left corner of a
> window and its position of point as reference points. I can't easily
> dismiss that.
>
> I'm not sure whether it's still relevant but if so we'd have to include
> it in 'window-in-direction'.
I see that an extra ARG when ‘C-u’ is not interpreted as a positive arg,
and ‘M--’ is not interpreted as a negative arg. So I propose to support
these prefix keys as well:
diff --git a/lisp/windmove.el b/lisp/windmove.el
index 598e495c7a..ea4506049b 100644
--- a/lisp/windmove.el
+++ b/lisp/windmove.el
@@ -512,7 +512,7 @@ windmove-left
If no window is at the desired location, an error is signaled
unless `windmove-create-window' is non-nil that creates a new window."
(interactive "P")
- (windmove-do-window-select 'left arg))
+ (windmove-do-window-select 'left (and arg (prefix-numeric-value arg))))
;;;###autoload
(defun windmove-up (&optional arg)
@@ -524,7 +524,7 @@ windmove-up
If no window is at the desired location, an error is signaled
unless `windmove-create-window' is non-nil that creates a new window."
(interactive "P")
- (windmove-do-window-select 'up arg))
+ (windmove-do-window-select 'up (and arg (prefix-numeric-value arg))))
;;;###autoload
(defun windmove-right (&optional arg)
@@ -536,7 +536,7 @@ windmove-right
If no window is at the desired location, an error is signaled
unless `windmove-create-window' is non-nil that creates a new window."
(interactive "P")
- (windmove-do-window-select 'right arg))
+ (windmove-do-window-select 'right (and arg (prefix-numeric-value arg))))
;;;###autoload
(defun windmove-down (&optional arg)
@@ -548,7 +548,7 @@ windmove-down
If no window is at the desired location, an error is signaled
unless `windmove-create-window' is non-nil that creates a new window."
(interactive "P")
- (windmove-do-window-select 'down arg))
+ (windmove-do-window-select 'down (and arg (prefix-numeric-value arg))))
;;; set up keybindings
next prev parent reply other threads:[~2018-11-08 21:38 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 23:33 bug#32790: 27.0.50; point jumps unexpectedly after delete-window Juri Linkov
2018-09-21 6:34 ` martin rudalics
2018-09-22 22:23 ` Juri Linkov
2018-09-23 5:44 ` Eli Zaretskii
2018-09-23 8:27 ` martin rudalics
2018-09-23 20:57 ` Juri Linkov
2018-09-24 8:33 ` martin rudalics
2018-09-24 18:49 ` Juri Linkov
2018-09-25 7:28 ` martin rudalics
2018-09-25 19:28 ` Juri Linkov
2018-09-26 8:51 ` martin rudalics
2018-09-26 23:05 ` Juri Linkov
2018-09-27 18:44 ` martin rudalics
2018-10-15 21:12 ` Juri Linkov
2018-10-16 8:46 ` martin rudalics
2018-10-16 22:20 ` Juri Linkov
2018-10-17 7:30 ` martin rudalics
2018-10-17 21:30 ` Juri Linkov
2018-10-18 8:05 ` martin rudalics
2018-10-18 22:49 ` Juri Linkov
2018-10-19 7:39 ` martin rudalics
2018-10-20 21:27 ` Juri Linkov
2018-10-21 8:22 ` martin rudalics
2018-10-21 18:17 ` Juri Linkov
2018-10-22 9:07 ` martin rudalics
2018-10-23 20:55 ` Juri Linkov
2018-10-24 9:45 ` martin rudalics
2018-10-25 20:48 ` Juri Linkov
2018-10-26 7:41 ` martin rudalics
2018-10-27 19:51 ` Juri Linkov
2018-10-28 8:59 ` martin rudalics
2018-10-28 19:36 ` Juri Linkov
2018-10-29 8:44 ` martin rudalics
2018-10-29 13:45 ` martin rudalics
2018-10-29 22:38 ` Juri Linkov
2018-10-30 9:00 ` martin rudalics
2018-10-30 21:42 ` Juri Linkov
2018-10-31 8:11 ` martin rudalics
2018-10-31 21:20 ` Juri Linkov
2018-11-01 9:03 ` martin rudalics
2018-11-01 22:42 ` Juri Linkov
2018-11-02 8:44 ` martin rudalics
2018-11-02 14:36 ` Drew Adams
2018-11-04 22:01 ` Juri Linkov
2018-11-05 9:35 ` martin rudalics
2018-11-04 22:21 ` Juri Linkov
2018-11-05 9:36 ` martin rudalics
2018-11-05 22:14 ` Juri Linkov
2018-11-06 8:48 ` martin rudalics
2018-11-06 22:22 ` Juri Linkov
2018-11-07 9:23 ` martin rudalics
2018-11-07 21:44 ` Juri Linkov
2018-11-08 8:52 ` martin rudalics
2018-11-08 21:38 ` Juri Linkov [this message]
2018-11-09 9:08 ` martin rudalics
2018-11-10 21:25 ` Juri Linkov
2018-12-26 2:04 ` Dmitry Gutov
2018-11-08 21:53 ` Juri Linkov
2018-11-09 9:13 ` martin rudalics
2018-11-10 21:37 ` Juri Linkov
2018-11-11 8:51 ` martin rudalics
2018-11-12 23:24 ` Juri Linkov
2018-11-13 9:08 ` martin rudalics
2018-11-13 23:20 ` Juri Linkov
2018-11-14 8:33 ` martin rudalics
2018-11-15 0:15 ` Juri Linkov
2018-11-15 9:13 ` martin rudalics
2018-11-15 22:59 ` Juri Linkov
2018-11-16 8:53 ` martin rudalics
2018-11-17 22:18 ` Juri Linkov
2018-11-18 9:24 ` martin rudalics
2018-11-18 22:52 ` Juri Linkov
2018-11-19 9:42 ` martin rudalics
2018-11-19 22:39 ` Juri Linkov
2018-11-20 9:28 ` martin rudalics
2018-11-21 0:12 ` Juri Linkov
2018-11-21 8:19 ` martin rudalics
2018-11-21 23:38 ` Juri Linkov
2018-11-22 7:40 ` martin rudalics
2018-11-22 22:45 ` Juri Linkov
2018-11-23 7:39 ` martin rudalics
2018-11-24 23:40 ` Juri Linkov
2018-11-25 8:23 ` martin rudalics
2018-11-25 21:01 ` Juri Linkov
2018-11-26 9:33 ` martin rudalics
2018-11-26 23:47 ` Juri Linkov
2018-11-27 6:00 ` Eli Zaretskii
2018-11-27 23:18 ` Juri Linkov
2018-11-28 8:33 ` martin rudalics
2018-11-28 23:25 ` Juri Linkov
2018-11-29 8:30 ` martin rudalics
2018-11-29 22:50 ` Juri Linkov
2018-11-30 8:22 ` martin rudalics
2018-12-01 22:43 ` Juri Linkov
2018-12-02 8:34 ` martin rudalics
2018-12-03 0:45 ` Juri Linkov
2018-12-03 7:45 ` martin rudalics
2018-12-20 23:28 ` Juri Linkov
2018-12-21 9:14 ` martin rudalics
2018-12-22 23:34 ` Juri Linkov
2018-12-23 9:40 ` martin rudalics
2018-11-27 8:08 ` martin rudalics
2018-11-04 22:07 ` Juri Linkov
2018-11-05 9:35 ` martin rudalics
2018-11-05 22:12 ` Juri Linkov
2018-11-06 8:47 ` martin rudalics
2018-11-21 23:35 ` Juri Linkov
2018-11-22 7:40 ` martin rudalics
2018-11-22 22:39 ` Juri Linkov
2018-11-23 7:40 ` martin rudalics
2018-11-24 23:20 ` Juri Linkov
2018-11-25 8:24 ` martin rudalics
2018-11-26 23:53 ` Juri Linkov
2018-11-27 8:08 ` martin rudalics
2018-11-27 23:28 ` Juri Linkov
2018-11-28 8:33 ` martin rudalics
2018-09-21 6:55 ` Eli Zaretskii
2018-09-22 22:34 ` Juri Linkov
2018-09-23 8:28 ` martin rudalics
2018-09-23 10:56 ` Eli Zaretskii
2018-09-23 20:49 ` Juri Linkov
2018-09-24 8:23 ` martin rudalics
2018-09-24 8:30 ` Eli Zaretskii
2018-09-24 12:25 ` martin rudalics
2018-09-24 18:53 ` Juri Linkov
2018-09-25 7:28 ` martin rudalics
2019-11-24 23:19 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg63ntbz.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=32790@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).