From: Noam Postavsky <npostavs@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: markusffm@fn.de, 32352@debbugs.gnu.org,
Katsumi Yamaoka <yamaoka@jpl.org>
Subject: bug#32352: 27.0.50; build error
Date: Mon, 12 Nov 2018 20:37:09 -0500 [thread overview]
Message-ID: <87lg5xhi62.fsf@gmail.com> (raw)
In-Reply-To: <3ein126rxn.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 12 Nov 2018 14:01:40 -0500")
Glenn Morris <rgm@gnu.org> writes:
> I seem to be able to reproduce it at will with (after a bootstrap):
>
> touch lisp/files.el src/emacs.c
> rm src/bootstrap-emacs
> make
Ah right, I missed removing bootstrap-emacs.
> which dies doing
>
> ./src/bootstrap-emacs -batch -f batch-byte-compile lisp/files.el
>
> at (alist-get class dir-locals-class-alist) when gv.elc loads.
> (It's fine if you load bytecomp.el instead of .elc.)
Not entirely sure about bytecomp.el vs elc, but the problem seems to be
that files.el binds read-circle over too much code, and gv.elc has some
circular structure in it. The following patch fixes it:
--- c/lisp/files.el
+++ i/lisp/files.el
@@ -4099,7 +4099,6 @@ dir-locals-read-from-dir
Return the new class name, which is a symbol named DIR."
(let* ((class-name (intern dir))
(files (dir-locals--all-files dir))
- (read-circle nil)
;; If there was a problem, use the values we could get but
;; don't let the cache prevent future reads.
(latest 0) (success 0)
@@ -4114,7 +4113,8 @@ dir-locals-read-from-dir
(insert-file-contents file)
(let ((newvars
(condition-case-unless-debug nil
- (read (current-buffer))
+ (let ((read-circle nil))
+ (read (current-buffer)))
(end-of-file nil))))
(setq variables
;; Try and avoid loading `map' since that also loads cl-lib
I guess this could go to emacs-26 (although I'm suddenly unable to build
it today, I get tons of "undefined reference to X" link errors
(including X=main!?)).
next prev parent reply other threads:[~2018-11-13 1:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 5:48 bug#32352: 27.0.50; build error Markus FFM
2018-08-03 6:07 ` Katsumi Yamaoka
2018-08-03 6:50 ` Eli Zaretskii
2018-08-03 12:40 ` Noam Postavsky
2018-11-12 19:01 ` Glenn Morris
2018-11-13 1:37 ` Noam Postavsky [this message]
2018-11-13 3:35 ` Eli Zaretskii
2018-11-13 13:54 ` Noam Postavsky
2018-11-13 13:58 ` Noam Postavsky
2018-11-13 18:10 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg5xhi62.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=32352@debbugs.gnu.org \
--cc=markusffm@fn.de \
--cc=rgm@gnu.org \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).