From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33799: 27.0.50; set-foreground-color completion shows background colors Date: Fri, 21 Dec 2018 00:37:18 +0200 Organization: LINKOV.NET Message-ID: <87lg4jesf5.fsf@mail.linkov.net> References: <875zvqz8om.fsf@mail.linkov.net> <5aftutcptc.fsf@fencepost.gnu.org> <87lg4lnvwp.fsf@mail.linkov.net> <4i7eg45brk.fsf@fencepost.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545345488 17961 195.159.176.226 (20 Dec 2018 22:38:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 20 Dec 2018 22:38:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33799@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 20 23:38:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga6x9-0004Yp-DZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Dec 2018 23:38:04 +0100 Original-Received: from localhost ([::1]:41297 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ga6zF-00020X-RZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Dec 2018 17:40:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ga6z9-00020R-6d for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 17:40:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ga6z4-0007vb-0X for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 17:40:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52616) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ga6z3-0007vH-Rr for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 17:40:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ga6z3-0006nX-LQ for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 17:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2018 22:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33799-submit@debbugs.gnu.org id=B33799.154534556326078 (code B ref 33799); Thu, 20 Dec 2018 22:40:01 +0000 Original-Received: (at 33799) by debbugs.gnu.org; 20 Dec 2018 22:39:23 +0000 Original-Received: from localhost ([127.0.0.1]:56874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga6yQ-0006mX-SV for submit@debbugs.gnu.org; Thu, 20 Dec 2018 17:39:23 -0500 Original-Received: from indri.birch.relay.mailchannels.net ([23.83.209.92]:63927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga6yO-0006mL-CG for 33799@debbugs.gnu.org; Thu, 20 Dec 2018 17:39:21 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id F3A11503491; Thu, 20 Dec 2018 22:39:18 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (unknown [100.96.30.62]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BEA9450338D; Thu, 20 Dec 2018 22:39:18 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Thu, 20 Dec 2018 22:39:18 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Tangy-Average: 53c28e1e2f365149_1545345558856_2720409336 X-MC-Loop-Signature: 1545345558856:2186489380 X-MC-Ingress-Time: 1545345558856 Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 7413F807A9; Thu, 20 Dec 2018 14:39:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=PS7000Bg/8EflblDp9UegBnmMjg=; b= FHhlNakgQkft6eFpU6KLba53cnsuB0PaMKwsqvUoqhWUKdc5kXnRDP9K2wPKePrH RMbvMf3nfYXs7JaeCzhEhHIJPSynaFYSBJtZqvv+ygjLxcSAJOFExNiMplE1M65M jAMcHGW9kq624ctepou8pgiJR1L0E3THcVAo0BU8Bkg= Original-Received: from mail.jurta.org (m91-129-106-79.cust.tele2.ee [91.129.106.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id C13628083D; Thu, 20 Dec 2018 14:39:16 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a6 In-Reply-To: <4i7eg45brk.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu, 20 Dec 2018 12:49:35 -0500") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudejfedgudeigecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdeirdejleenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdeirdejledprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehrghhmsehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153659 Archived-At: >> I don't know if readable background is needed for set-foreground-color >> like readable foreground is used for set-background-color. I think >> your change to not use readable background is more correct because >> then the user will see how the selected color will fit with the background. >> This helps to select a suitable combination of foreground/background >> colors. The same way maybe readable foreground should be removed >> from the completions of set-background-color. This would allow to see >> how the current foreground color will look on different backgrounds >> in the completion list. > > I think defined-colors-with-face-attributes probably needs yet another > argument, to control whether the non-varying component (be it foreground > or background) is a fixed value or a changing "readable" one. Yes, another argument (or maybe rename the new argument `foreground', but I have no idea for a good name and its values) is needed specially for set-foreground-color and set-background-color that should leave the default background/foreground color instead of replacing it with readable.