From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Tue, 25 Dec 2018 22:39:41 +0200 Organization: LINKOV.NET Message-ID: <87lg4ds5zi.fsf@mail.linkov.net> References: <878t18j4is.fsf@mail.linkov.net> <83a7lobemr.fsf@gnu.org> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> <87imzng7gn.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545771073 11910 195.159.176.226 (25 Dec 2018 20:51:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Dec 2018 20:51:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33567@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 25 21:51:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbtfQ-0002xs-Du for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Dec 2018 21:51:08 +0100 Original-Received: from localhost ([127.0.0.1]:42980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbthW-0002cc-V1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Dec 2018 15:53:19 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbthK-0002cJ-It for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:53:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbthH-0002Y4-EU for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:53:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45858) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gbthH-0002Xo-Ag for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:53:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gbthH-0002jH-9E for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:53:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Dec 2018 20:53:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154577116610428 (code B ref 33567); Tue, 25 Dec 2018 20:53:03 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 25 Dec 2018 20:52:46 +0000 Original-Received: from localhost ([127.0.0.1]:36460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbth0-0002i8-8x for submit@debbugs.gnu.org; Tue, 25 Dec 2018 15:52:46 -0500 Original-Received: from firebrick.maple.relay.mailchannels.net ([23.83.214.59]:12940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbtgu-0002hp-Ne for 33567@debbugs.gnu.org; Tue, 25 Dec 2018 15:52:41 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8F680501CA2; Tue, 25 Dec 2018 20:52:39 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a16.g.dreamhost.com (unknown [100.96.29.126]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4F955500AD9; Tue, 25 Dec 2018 20:52:39 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a16.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 25 Dec 2018 20:52:39 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Illegal-Occur: 3daffe2261181d5c_1545771159436_3625996529 X-MC-Loop-Signature: 1545771159436:2388524120 X-MC-Ingress-Time: 1545771159436 Original-Received: from pdx1-sub0-mail-a16.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a16.g.dreamhost.com (Postfix) with ESMTP id EE65C7F925; Tue, 25 Dec 2018 12:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=6QaD9/63iqAX9MxbxuSfmduPO8Q=; b= JFFAnvb7q7jzLLEqt5Kp2U0RknFBSrl91i7bXgJzbpMUXx/p2D+K28FLVe5MeXCM SRfYsJSFQyYBQEpc8Z3EBGxBNFpfqtetz2bBaT2gK6QXhsYzl92CYjlqBAfqGFF6 F19aXR3n/XiJ0UxA7RCKRKdEFtZBrtzpMSFEs4s/ijo= Original-Received: from mail.jurta.org (m91-129-108-193.cust.tele2.ee [91.129.108.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a16.g.dreamhost.com (Postfix) with ESMTPSA id D9D847F919; Tue, 25 Dec 2018 12:52:37 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a16 In-Reply-To: <87imzng7gn.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 21 Dec 2018 00:17:04 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudekfedgudegiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtkedrudelfeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdekrdduleefpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153840 Archived-At: > Your proposed new colors for added/removed are the same that are used > GitHub/GitLab, so this should be a good change. For refine-removed > better to use GitLab's color #ffcccc that is very close to the > color you proposed. But for refine-added GitLab made the same mistake > that GitHub already fixed. So the best color for refine-added is #bbffbb. After trying to use there colors, I see that their shade is too subtle. They might look better on large hunks, and I'm not sure why they look ok in the browser, but in Emacs refined colors for small changes are almost not noticeable. However, please change them if majority agrees.