From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Alex Branham <alex.branham@gmail.com>
Cc: 35123@debbugs.gnu.org
Subject: bug#35123: [PATCH] Use lexical-binding in bug-reference
Date: Wed, 03 Apr 2019 17:42:31 +0100 [thread overview]
Message-ID: <87lg0rrqfc.fsf@tcd.ie> (raw)
In-Reply-To: <87wokbb18k.fsf@gmail.com> (Alex Branham's message of "Wed, 03 Apr 2019 09:40:59 -0500")
Alex Branham <alex.branham@gmail.com> writes:
> diff --git a/.dir-locals.el b/.dir-locals.el
> index 9cd39920c2..506edfcf73 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -1,6 +1,7 @@
> ((nil . ((tab-width . 8)
> (sentence-end-double-space . t)
> - (fill-column . 70)))
> + (fill-column . 70)
> + (bug-reference-url-format . "https://debbugs.gnu.org/%s")))
> (c-mode . ((c-file-style . "GNU")
> (c-noise-macro-names . ("INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" "UNINIT" "CALLBACK" "ALIGN_STACK"))
> (electric-quote-comment . nil)
> @@ -12,7 +13,6 @@
> (log-edit-setup-add-author . t)))
> (change-log-mode . ((add-log-time-zone-rule . t)
> (fill-column . 74)
> - (bug-reference-url-format . "https://debbugs.gnu.org/%s")
> (mode . bug-reference)))
> (diff-mode . ((mode . whitespace)))
> (emacs-lisp-mode . ((indent-tabs-mode . nil)
While you're at it, why not also change (mode . bug-reference)
to (eval . (bug-reference-mode)) as per the recommended way to enable
minor modes described in (info "(emacs) Specifying File Variables")?
Apart from that, and FWIW, LGTM.
Thanks,
--
Basil
next prev parent reply other threads:[~2019-04-03 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 14:40 bug#35123: [PATCH] Use lexical-binding in bug-reference Alex Branham
2019-04-03 16:42 ` Basil L. Contovounesios [this message]
2019-04-04 14:33 ` Alex Branham
2019-04-09 21:31 ` Alex Branham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg0rrqfc.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=35123@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).