From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35362: 26.2; [debbugs.el] Automate commit -> debbugs flow (posting patches, closing bugs after pushing) Date: Thu, 25 Apr 2019 14:16:33 +0200 Message-ID: <87lfzy8ela.fsf@gmx.de> References: <874l6rtnjo.fsf@gmail.com> <871s1vtm9h.fsf@gmail.com> <87wojns7ia.fsf@gmail.com> <875zr7cepw.fsf@gmx.de> <87d0ldsu6w.fsf@gmail.com> <87tvep87xg.fsf@gmx.de> <87pnparg0j.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="106201"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35362@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 25 14:17:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJdJR-000RPq-6q for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Apr 2019 14:17:13 +0200 Original-Received: from localhost ([127.0.0.1]:56326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJdJP-0003N9-TB for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Apr 2019 08:17:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJdJH-0003Kx-EK for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 08:17:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJdJG-0002wR-DG for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 08:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44144) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJdJG-0002vw-9A for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 08:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJdJG-0001O9-0N for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 08:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 12:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35362-submit@debbugs.gnu.org id=B35362.15561946055297 (code B ref 35362); Thu, 25 Apr 2019 12:17:01 +0000 Original-Received: (at 35362) by debbugs.gnu.org; 25 Apr 2019 12:16:45 +0000 Original-Received: from localhost ([127.0.0.1]:57686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJdIz-0001NL-9r for submit@debbugs.gnu.org; Thu, 25 Apr 2019 08:16:45 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:35345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJdIv-0001N4-U4 for 35362@debbugs.gnu.org; Thu, 25 Apr 2019 08:16:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556194594; bh=g7QI878BIv5nJuxPBxWOUgJ5jKZnqvxPXn/GmX+3o6o=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=XYTusgmevIcCWjmRbq967NCoKw5hqNOqqZvGCpSMbdXrMbjz/OaVt+MYV8buSLNOl Oex33DzsFTsHEtB4ABGDj1zI6z2nSx4fsUdCYdTqFBOYs+ZU6rKBJJSaAuSP/Ye6tc HShxTDWaNd9rkluYiHvGc1xliqjlckA8EVnePGPs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.57.174]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LgYuT-1gyIdz2mGb-00nzKy; Thu, 25 Apr 2019 14:16:34 +0200 In-Reply-To: <87pnparg0j.fsf@gmail.com> (Noam Postavsky's message of "Wed, 24 Apr 2019 22:10:52 -0400") X-Provags-ID: V03:K1:n6BpwOXR9eV4adOy/FgF3Y5azmbGfGJcxYytSF6hXa4hu09Sj6M +PCfpokboqhL56IwM1FNZtY27DEnzYteQX544X03UkVBeHnVpcNiGcn2pNLWCbhcRBuSncq HT7abmLbyyoxGXVIHPfSm3dESIpnmM+8T06dwlwyC2kohgWf1dyG+XjYQ7t/KXAbZfk7DBG ADCYnrHMBK3CLk15OJqzQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:prd82jYIGVM=:q6b7cg86nxYTNBllTgya4Z Gt3ORLrRXxHNb1aqO2y1j8PsFxuElVIQQStSnZuvZ6vkx1+5WOa/VVxMVWm+M3+91Xw2nQrH2 re/EoniQWhdIt3Zk4APrx0APv5X3Eq4qGz+k46AYu1NzJizcsWkjHk3pvUItOfGX+QlVWw2n7 DcO+TLLIxNcu0Izjkf9uuuG1UQ4jPb93YPY4ddADOWEMNIFnXoeIh/7sr0GpmNJpdJXhK0nxh 35B5CPkgBUU7wWJuWEd2gmMaDbzizjDzZn0uNKqIm/1FQ5M8X6q3IGUyPs4T5MWu2j1+0Km0y /qHhCHZfXRXiYAxGHbuq68QMm6k0byoUFu+CPA87+xv064viVObTMV6b8d1RRPIakAvGB6mfp hIHhtVPAT+JBATpxFqvpnlC0YOBSiXB7DrkR+vqnSwQflS1EKeZgObSry4PK7xhSa+GyhQQ74 NR6htaxpJ55tpXVlCC1eK68YFu4E3cbBRnm3GKYICG0DaPZ4qaIhJpfqGnHk4IaTfWOstEIcE 5/ytUInVGUqz1sUuhvzojfELg2AQoLHiq/I1p7Zl5zDlgvhqRgQwV1ZMHqF8PKP/wI+wqlrTz Pipx67RoyBtZjU5GNKt32wTjTVva5ZBMjyQ0KvEvqAz0z8BvJunNW5iC7WgLf0etALpkQwWvk 25DKq80/SKF3Nh2ImIZStbEWOaRts991wLWSpk3In5Wb/8vhMcFyvD06T9e3MOw5TMnLb8z3+ JtxzwouKxBo2BySUYLKsqvHzQ1eXtNB5lfvyHvO/AVHy1Zi47u+oEYELN90nV5QXZ2IPLGtp X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158246 Archived-At: Noam Postavsky writes: Hi Noam, I believe your patch is almost OK, so let's apply it. But of course, I still have some few remarks :-) >>> Invoke the command @code{debbugs-gnu-pick-commits} and press >> >> Should we give this command a key binding? > > Maybe, but then the question is what map to bind it in. Is it okay to > start adding things into vc-git-log-view-mode-map? Yep. Maybe we bind "c" for it, because other candidates (d/D/p/P) seem to be bound already. Furthermore, we might mention debbugs-gnu-pick-commits in the ;;; Commentary section of debbugs-gnu.el. >> I don't understand (yet), how the description of this variable helps. Is >> the user expected to change the value herself, somehow? Otherwise, we >> might to keep this description out. > > The idea is you can add entries that can work with other packages, e.g., > magit. OK, this part I don't understand yet (I'm not a magit user, for example). But I don't mind. > --- a/packages/debbugs/debbugs-gnu.el > +++ b/packages/debbugs/debbugs-gnu.el > + (add-hook 'message-send-actions > + (lambda () (remhash bugid debbugs-cache-data)) > + nil t))) Do we need to declare message-send-actions? > +(defun debbugs-gnus-jump-to-bug (bugid) > + "Display buffer associated with BUGID with `pop-to-buffer'. > +Use `gnus-read-ephemeral-emacs-bug-group' instead if there is no such buffer." Maybe you could add at least a FIXME for the lack of rmail support. > +(defun debbugs-gnu--git-insert (&rest args) > + "Insert output of running git with ARGS. > +Throws error if git returns non-zero. Uses `vc-git-program'." Don't mention vc-git-program. > + (unless (eql 0 (apply #'vc-git--call '(t t) args)) Declare vc-git--call. > +(defun debbugs-gnu--git-remote-info () > + "Return (REMOTE . INFO-ALIST)." Say, that REMOTE is a string, which must be matched by REMOTE-REGEXP of debbugs-gnu-git-remote-info-alist. Refer to the docstring of that user option. > + (dir (make-temp-file (format "patches-for-bug%d-" bugnum) t)) I'm curious: Why a trailing "-" in the buffer name? > + (deldir (lambda () > + (delete-directory dir t) > + (remove-hook 'message-exit-actions deldir t) Do we need to declare message-exit-actions? > + (dolist (patch (directory-files dir t "\\`[^.]")) > + (mml-attach-file patch type "patch" disposition)) Do we need to declare mml-attach-file? > +`debbugs-gnu-pick-commits' and jump to read bug in prepration for Typo. > --- a/packages/debbugs/debbugs-ug.texi > +++ b/packages/debbugs/debbugs-ug.texi > +The string inserted to describe an announced commit is controlled by > +the variable @code{debbugs-gnu-commit-description-format}, it is a It is a user option. > +subitem is appended to the commit description. By default this > +variable is configured for the GNU Emacs and GNU ELPA repositories, That's also a user option. Best regards, Michael.