From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#14769: [PATCH] optimize `concat's literals Date: Wed, 19 Jun 2019 20:38:12 -0400 Message-ID: <87lfxxw0p7.fsf@gmail.com> References: <6BF130E1-F25B-4E1B-B55D-224F0CCEC133@acm.org> <87r27qwdrv.fsf@gmail.com> <43EF1EEA-BE3B-493A-9BDE-C8AE37B9696A@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="241729"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Lars Ingebrigtsen , Stefan Monnier , 14769@debbugs.gnu.org, shigeru.fukaya@gmail.com To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 20 02:42:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hdl9e-0010nC-LS for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Jun 2019 02:42:18 +0200 Original-Received: from localhost ([::1]:42704 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdl9d-0004Yf-8j for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Jun 2019 20:42:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35219) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdl9X-0004W8-8m for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 20:42:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdl6X-00065s-I8 for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 20:39:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34068) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hdl6U-00062i-6z for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 20:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hdl6U-0003Yk-2I for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 20:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2019 00:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14769-submit@debbugs.gnu.org id=B14769.156099110113608 (code B ref 14769); Thu, 20 Jun 2019 00:39:02 +0000 Original-Received: (at 14769) by debbugs.gnu.org; 20 Jun 2019 00:38:21 +0000 Original-Received: from localhost ([127.0.0.1]:47612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdl5o-0003XQ-Ne for submit@debbugs.gnu.org; Wed, 19 Jun 2019 20:38:20 -0400 Original-Received: from mail-io1-f41.google.com ([209.85.166.41]:40099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdl5n-0003XB-2d for 14769@debbugs.gnu.org; Wed, 19 Jun 2019 20:38:19 -0400 Original-Received: by mail-io1-f41.google.com with SMTP id n5so1095688ioc.7 for <14769@debbugs.gnu.org>; Wed, 19 Jun 2019 17:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=ZnWKQwKQLC8JxinDSNC+GyX8H/2c/M8qa5A+7k2UTfs=; b=MeD21bdVNrM9cW6upZdWKrmlGD858G/dxEmY4f9P2APcGmhwyBDb0xuwmI0/nKd+1Y sqJB7eJ0QdEVyy+HTmw+I/knNb881mjbLoktFtbbb0h+yv8RfMfH0Kl4EzTBJX4j8qON vNR1laDsbWuy8qfQTJdSaFgC2BXb2bsO5YjfR0SvCpQGcxWb8P9UlRF74Frgve9pTdZB J3voqc8tqoda+8OUp3U8BE6/qBXQRLGR+6CK32f3KZX9kzkr8QhuOhjVr0KEnZtvOC3r EHX8wj4JSD3Yb350iUXEivGn2NG7FpWJKQWmVZ3xtaA4SxR1rS4bJVJu+kKB9o4VGoHi C2BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ZnWKQwKQLC8JxinDSNC+GyX8H/2c/M8qa5A+7k2UTfs=; b=jsA6wxfI8c/yLIXTpoq3tmTpelaSj6AaMsCBKIv6OziwJu+bueI07bZCqi5tpwqqqr t8r8sVYUX/FW82AbyscoNgTocalvJGZHnSwV0QGydTlOpkpU1SqtpMRgVoyPsUg/0KAH nj4ZXbxpR9hpAp1ym1JkWpe7d02NwP7U7J4avfvFcvQCbMyrnl8nsYHokaeMzKiM95NQ cH4LaGIhV6bbNMG6sR01VslKDO7oFCxeabaD84gM5U89eKAZPQFirtYcMpqzkNf8ahrF Aq1wAIsRIbePGyX1maxKnqdgip+kRlbt9egHG0leFjRf84TDtatK27NrGZDvTUig2kiX jMQQ== X-Gm-Message-State: APjAAAWDpHKgF6nN84eKLHBOzHke8zmp+OsMkl0uAUjcEndlfQLgXyRP ryRm8SrLvlIIEtly7O9H3c4= X-Google-Smtp-Source: APXvYqzR0GnWS8HLoIkV4yI5bYfB87UhEf2MBhSsM7/Ey61PMWgV9+OANKZBtJF5U2MuzT+jbwZYrA== X-Received: by 2002:a02:b798:: with SMTP id f24mr97110423jam.97.1560991093453; Wed, 19 Jun 2019 17:38:13 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id t22sm17024725ioc.75.2019.06.19.17.38.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Jun 2019 17:38:12 -0700 (PDT) In-Reply-To: <43EF1EEA-BE3B-493A-9BDE-C8AE37B9696A@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Wed, 19 Jun 2019 14:54:16 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160868 Archived-At: Mattias Engdeg=C3=A5rd writes: > Yes, I thought it wouldn't matter but you are right. Updated patch attach= ed. Looks good to me. As a minor aesthetic nitpick, I would suggest using `pop', since you're already using `push'.