From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33237: 26.1, 7.3 emacs-mac: list order in C-h b Date: Wed, 10 Jul 2019 15:36:53 +0200 Message-ID: <87lfx63tai.fsf@mouse.gnus.org> References: <1905EAD6-8AD3-4ED2-A80B-26DAF98FF08C@scratch.space> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="49012"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33237@debbugs.gnu.org To: Van L Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 10 15:38:46 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlCo2-000CYK-63 for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 15:38:46 +0200 Original-Received: from localhost ([::1]:32986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlCnx-0005Kj-CQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 09:38:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54523) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlCnL-0005Is-DJ for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 09:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlCnK-00069G-9X for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 09:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54500) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlCnJ-00068w-Rl for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 09:38:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlCnJ-0007yd-Mx for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 09:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 13:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33237 X-GNU-PR-Package: emacs Original-Received: via spool by 33237-submit@debbugs.gnu.org id=B33237.156276582230577 (code B ref 33237); Wed, 10 Jul 2019 13:38:01 +0000 Original-Received: (at 33237) by debbugs.gnu.org; 10 Jul 2019 13:37:02 +0000 Original-Received: from localhost ([127.0.0.1]:35088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlCmM-0007ww-94 for submit@debbugs.gnu.org; Wed, 10 Jul 2019 09:37:02 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:37794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlCmK-0007wU-1f for 33237@debbugs.gnu.org; Wed, 10 Jul 2019 09:37:01 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlCmD-0000fZ-Q4; Wed, 10 Jul 2019 15:36:56 +0200 In-Reply-To: <1905EAD6-8AD3-4ED2-A80B-26DAF98FF08C@scratch.space> (Van L.'s message of "Fri, 2 Nov 2018 15:47:48 +1100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162629 Archived-At: Van L writes: > This is a suggestion. > > The ordering on the f-number keys listed in the help buffer looks to > me to be improvable. > > The numsort as applied after f but before the greater-thang(>) will look nicer. > > help-command > menu-bar-open > toggle-frame-fullscreen > clipboard-kill-ring-save > clipboard-yank > 2C-command > clipboard-kill-region > kmacro-start-macro-or-insert-counter > kmacro-end-or-call-macro With the patch below, I get: help-command 2C-command kmacro-start-macro-or-insert-counter kmacro-end-or-call-macro menu-bar-open toggle-frame-fullscreen clipboard-kill-ring-save clipboard-yank clipboard-kill-region Looks nicer to me. Does anybody object to this change? diff --git a/src/keymap.c b/src/keymap.c index 2ac3d33460..8c2c209e64 100644 --- a/src/keymap.c +++ b/src/keymap.c @@ -3098,8 +3098,8 @@ describe_map_compare (const void *aa, const void *bb) if (FIXNUMP (a->event) && !FIXNUMP (b->event)) return -1; if (SYMBOLP (a->event) && SYMBOLP (b->event)) - return (!NILP (Fstring_lessp (a->event, b->event)) ? -1 - : !NILP (Fstring_lessp (b->event, a->event)) ? 1 + return (!NILP (Fstring_version_lessp (a->event, b->event)) ? -1 + : !NILP (Fstring_version_lessp (b->event, a->event)) ? 1 : 0); return 0; } -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no