From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#22792: eshell-mode-map declaration Date: Thu, 15 Aug 2019 20:56:37 -0400 Message-ID: <87lfvuorlm.fsf@gmail.com> References: <56CDC6D3.1050106@boccaperta.com> <877e976nhx.fsf@gmail.com> <85pnmy6deq.fsf@gmail.com> <87woh5mvb7.fsf@gmail.com> <87v9wf4zss.fsf@gmail.com> <87ftm5uj0y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="32406"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: 22792@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 16 02:57:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyQYJ-0008Js-Sg for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 02:57:12 +0200 Original-Received: from localhost ([::1]:48168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyQYI-0002ST-7q for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Aug 2019 20:57:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52155) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyQYB-0002Rt-0r for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 20:57:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyQY9-00069E-Sg for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 20:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43919) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyQY9-000690-Pr for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 20:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hyQY9-0008Iy-Ho for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 20:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 00:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22792 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22792-submit@debbugs.gnu.org id=B22792.156591700631903 (code B ref 22792); Fri, 16 Aug 2019 00:57:01 +0000 Original-Received: (at 22792) by debbugs.gnu.org; 16 Aug 2019 00:56:46 +0000 Original-Received: from localhost ([127.0.0.1]:52740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyQXu-0008IU-GM for submit@debbugs.gnu.org; Thu, 15 Aug 2019 20:56:46 -0400 Original-Received: from mail-io1-f48.google.com ([209.85.166.48]:44089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyQXs-0008I8-Dk; Thu, 15 Aug 2019 20:56:44 -0400 Original-Received: by mail-io1-f48.google.com with SMTP id j4so2989994iop.11; Thu, 15 Aug 2019 17:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TlC1NVJxbj5C8+rGt8Vb/rcu8k5T0CflvFsoZPEbJD4=; b=RhXiAVuaeDKlLK/it0T0Kq+IEc/PsKmZQKdTNt1GA5WMnHIH/CQtEiv+HCQI7Sj6c5 +vqfQgaBDjBENE62wfhe8jmN8nr8k4Hdd96Y75VscWRcHWJqXn3qIZSiqJgJS7Y0IGUC K6cAzxAjdgUA10LLqDNKfhYCeK0BngUBuiKlevxyHqpZIezdq8KGM6ED+zzZjfh/mB4a IBtbK+7LyB6+WmJ1qJWTVGoHAECQZkHf3bLF0y7AFgGklHF1ep3oDDW0qJ/+dQRgjWMI uXgA/jj9rJ5E2sGk592B4CA+FDpaeb3LF/a7qHmXfx/NNdFQ2wqehS+m4p06yNTbXsHj 5Tug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TlC1NVJxbj5C8+rGt8Vb/rcu8k5T0CflvFsoZPEbJD4=; b=Lqz+/XejWS67aji3xgRb7zsLOejXRUYFgtfvABFmMA2mKGDwgVw5vFegBnOti8r5d3 Dn0+gPVgFr2CD7Jsgr9W8LtV2058NeJ8q2LkKVh9rTpU3mn5OEzn4J/70MQRklZprNAB nPZJrg0bGdIMhT5+Eu9PVJPt8mu9bKZUWMnUllu3fevGJoTQJd8+qgMLgOlDYywk+Cdl wohsRenvDZ4gPkQ1pQMUCLPtAzSwvpe7HSBmkK8HC1PVqpL2w+Gk87ozTTnMQRpmqJzd yTJJ7N0Z0QYyq5ZGl6v7pC2ZyHvYl82MnKMH0NEFaepIh7I18ZgRV4fNlK9JSJDGgwhS 0X3w== X-Gm-Message-State: APjAAAX00k8gS6j64CBnBeUnOtc+HsZk68WWl27M8xLnV9+FaOU7iE8i 60CZDrnD02x8Pc1ku56pawebWLlj X-Google-Smtp-Source: APXvYqwitfx3ihieCSGGuKMHu2DU3rEqjuMXscTlRbUXx286tDtBNJP/8f3tD2zLEoi0iRPqDm5hxQ== X-Received: by 2002:a6b:f002:: with SMTP id w2mr8799858ioc.104.1565916998653; Thu, 15 Aug 2019 17:56:38 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id s3sm4012829iob.49.2019.08.15.17.56.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Aug 2019 17:56:38 -0700 (PDT) In-Reply-To: <87ftm5uj0y.fsf@gmail.com> (Alex Branham's message of "Tue, 13 Aug 2019 11:28:29 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165167 Archived-At: tags 22792 fixed close 22792 27.1 quit Alex Branham writes: > I don't know of a straightforward way to keep those in C-h m since this > uses minor modes, but it's easy enough to add those into the docstring > of the minor mode. Alright, good enough for now, I think. Pushed to master. 1ee0192b79 2019-08-15T20:49:15-04:00 "Fix eshell-mode-map initialization" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1ee0192b792124663a0a40a729dd83c047d21535 > The more I think about this the more I wonder whether the whole > eshell-module framework should just be moved to minor modes, then we > could just call run-hooks on eshell-modules to set everything up. But > that's a question for a later day I suppose. Agreed on both counts. > * lisp/eshell/esh-mode.el (eshell-mode-map): > (eshell-command-map): Set up normal keymaps and prefix commands rather > than re-initializing them in each eshell buffer > > * lisp/eshell/em-cmpl.el (eshell-cmpl-mode-map): > (eshell-cmpl-mode): > (eshell-cmpl-initialize): > * lisp/eshell/em-hist.el (eshell-hist-mode-map): > (eshell-hist-mode): > (eshell-hist-initialize): > * lisp/eshell/em-pred.el (eshell-pred-mode-map): > (eshell-pred-mode): > (eshell-pred-initialize): > * lisp/eshell/em-prompt.el (eshell-prompt-mode-map): > (eshell-prompt-mode): > (eshell-prompt-initialize): > * lisp/eshell/em-rebind.el (eshell-rebind-mode-map): > (eshell-rebind-mode): > (eshell-rebind-initialize): > * lisp/eshell/esh-arg.el (eshell-arg-mode-map): > (eshell-arg-mode): > (eshell-arg-initialize): > * lisp/eshell/esh-proc.el (eshell-proc-mode-map): > (eshell-proc-mode): > (eshell-proc-initialize): > * lisp/eshell/esh-var.el (eshell-var-mode-map): > (eshell-var-mode): > (eshell-var-initialize): Create a new minor mode with a keymap and > call it in the module initialization function. By the way, the formatting of the ChangeLog entries is bit off here (there shouldn't be a colon between empty entries of the same file). But it's a nice use-case for the new log-edit-fill-entry: I can fix it with just two presses of M-q :)