From: Uwe Brauer <oub@mat.ucm.es>
To: 37025@debbugs.gnu.org
Subject: bug#37025: [found the culprit]
Date: Thu, 15 Aug 2019 09:38:37 +0200 [thread overview]
Message-ID: <87lfvukhdu.fsf@mat.ucm.es> (raw)
In-Reply-To: <87imr06o42.fsf@mat.ucm.es>
[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]
>>> "TL" == Teemu Likonen <tlikonen@iki.fi> writes:
> Glenn Morris [2019-08-14T21:39:37-04] wrote:
>> Teemu Likonen wrote:
>>> Thanks for the report and bisecting. I think we can fix the bug by
>>> including "--sender" option only with openpgp protocol (i.e. gpg).
> Because --sender is an OpenPGP thing (gpg) it is logical to narrow its
> use to that protocol only. Here's the first fix:
A couple of comments.
1. A quick fix. Since your patch is not applied. I tried to change
my setting. To my surprise
(mml-secure-smime-sign-with-sender nil)
*did not help*, although I am using smime not opengpg.
But
(mml-secure-openpgp-sign-with-sender nil)
*did help*.
This should be mentioned in the documentation (NEWS and in the
relevant doc strings)
2. I am not sure what will happen with older pgp versions. A quick
fix would be to set the above variable to nil
3. I think this issue should be discussed on the devel list.
4. Who and when your patch will be applied?
[Snip]...
>> gpg --sender
-> gpg: invalid option "--sender" # RHEL 7.6 with gpg 2.0.22
>>
>> The option seems to only by present since gpg 2.1.15.
>> https://gnupg.org/download/release_notes.html
>>
>> Ideally you should test if it is supported or not.
> So there should also be version checking in epg.el's epg-start-sign and
> epg-start-encrypt functions (or somewhere). Currently I don't know if
> there are useful infrastructure in epg for dealing with different
> versions of gpg.
Given that circumstance, is your change really worth the effort?
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5025 bytes --]
next prev parent reply other threads:[~2019-08-15 7:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 10:24 bug#37025: 27.0.50; smime signing and encryption does not work any longer Uwe Brauer
2019-08-14 18:54 ` bug#37025: [found the culprit] (was: bug#37025: 27.0.50; smime signing and encryption does not work any longer) Uwe Brauer
2019-08-14 19:14 ` Teemu Likonen
2019-08-15 1:39 ` bug#37025: [found the culprit] Glenn Morris
2019-08-15 4:48 ` Teemu Likonen
2019-08-15 7:38 ` Uwe Brauer [this message]
2019-08-15 16:08 ` Teemu Likonen
2019-08-15 16:12 ` Uwe Brauer
2019-08-18 15:13 ` Teemu Likonen
2019-08-26 5:53 ` Lars Ingebrigtsen
2019-08-26 6:57 ` Uwe Brauer
2019-08-26 7:31 ` bug#37025: [confirmed] (was: bug#37025: [found the culprit]) Uwe Brauer
2019-08-26 14:44 ` Teemu Likonen
2019-08-27 6:43 ` bug#37025: [confirmed] Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfvukhdu.fsf@mat.ucm.es \
--to=oub@mat.ucm.es \
--cc=37025@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).