From: Lars Ingebrigtsen <larsi@gnus.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 36945@debbugs.gnu.org, Fabrice Popineau <fabrice.popineau@gmail.com>
Subject: bug#36945: 27.0.50; read-library-name
Date: Tue, 27 Aug 2019 09:48:42 +0200 [thread overview]
Message-ID: <87lfvf2gmd.fsf@gnus.org> (raw)
In-Reply-To: <858srgj7sn.fsf@gmail.com> (Noam Postavsky's message of "Mon, 26 Aug 2019 10:55:04 -0400")
Noam Postavsky <npostavs@gmail.com> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> (locate-file-completion-table '("~/src/emacs/trunk/lisp/image")
>> '(".el$") "" nil t)
>> => ("compface.el" "compface.elc" "../" "gravatar.elc" "./" "gravatar.el")
>>
>> And as we can see, the output from that function isn't quite what you'd
>> expect. Isn't SUFFIXES supposed to limit the output?
>
> In the context of general file name completion, I guess the idea is that
> you might find files with any extension under a directory. Doesn't make
> so much sense for read-library-name though.
No, I wonder if whoever wrote the code in question thought that SUFFIXES
limited the results... which it doesn't seem to do. Those completion
functions are a bit under-documented, though.
I've now rewritten `read-library-name' to not use that function at all,
and instead just complete over all the .el/.el.gz files "manually".
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-08-27 7:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 9:48 bug#36945: 27.0.50; read-library-name Fabrice Popineau
2019-08-23 4:55 ` Lars Ingebrigtsen
2019-08-26 14:55 ` Noam Postavsky
2019-08-27 7:48 ` Lars Ingebrigtsen [this message]
2022-02-05 23:31 ` Lars Ingebrigtsen
2020-09-14 20:46 ` Stefan Monnier
2020-09-15 12:32 ` Lars Ingebrigtsen
2020-09-15 13:31 ` Stefan Monnier
2020-09-15 14:48 ` Eli Zaretskii
2020-09-17 14:40 ` Lars Ingebrigtsen
2020-09-17 16:41 ` Stefan Monnier
2020-09-15 15:32 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfvf2gmd.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=36945@debbugs.gnu.org \
--cc=fabrice.popineau@gmail.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).