From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33740: [PATCH] Customizable flymake mode-line indicator Date: Wed, 18 Sep 2019 15:40:44 +0200 Message-ID: <87lfullo2r.fsf@gnus.org> References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="261892"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 18 15:41:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAaCl-0015y1-An for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Sep 2019 15:41:11 +0200 Original-Received: from localhost ([::1]:59220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAaCk-0005S3-2S for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Sep 2019 09:41:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34776) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAaCd-0005Rf-Tb for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2019 09:41:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAaCc-0005Hv-Ku for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2019 09:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44950) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iAaCc-0005Hq-I4 for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2019 09:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iAaCc-0001oC-Ej for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2019 09:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Sep 2019 13:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33740 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33740-submit@debbugs.gnu.org id=B33740.15688140526929 (code B ref 33740); Wed, 18 Sep 2019 13:41:02 +0000 Original-Received: (at 33740) by debbugs.gnu.org; 18 Sep 2019 13:40:52 +0000 Original-Received: from localhost ([127.0.0.1]:53771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaCR-0001ng-KN for submit@debbugs.gnu.org; Wed, 18 Sep 2019 09:40:52 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:57456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaCN-0001nW-Kf for 33740@debbugs.gnu.org; Wed, 18 Sep 2019 09:40:50 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAaCK-00028Y-G8; Wed, 18 Sep 2019 15:40:46 +0200 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 17 Sep 2019 15:07:59 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166674 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Thanks, Lars. I'm away from my emacs dev machine so I can't read the > diff very carefully, but if you want to risk it, go ahead and push, > because I like the defcustom spec and I see you've kept the default. A > short entry in NEWS and the Flymake manual is probably worth it (but > you can skip the latter). Well, it doesn't quite work yet, so it's a bit premature. :-) > There are arbitrary errors levels in this flymake (not just error warning= =20 > and note). But those are the main ones and anyway we can always > add more format machinery later. Hm, is there a list of all the error levels? If not, I think the approach I took in the patch is probably misguided (what with %e for "error" and stuff).=20=20 > I see a lot of changed lines, but most of them are probably whitespace. Yes, it's mostly whitespace due to rearranging the way the strings are computed. > Is there some diff format which elides those? I'm not sure? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no