From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ingo Lohmar Newsgroups: gmane.emacs.bugs Subject: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing Date: Thu, 03 Oct 2019 20:21:00 +0200 Message-ID: <87lfu1zo4z.fsf@kenko.localhost.com> References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87zhiixliu.fsf@kenko.localhost.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="13866"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37563@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 03 20:22:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iG5jy-0003MJ-E6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 20:22:14 +0200 Original-Received: from localhost ([::1]:39230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG5jw-0003Zv-Rx for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 14:22:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41927) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG5jn-0003Zm-IG for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 14:22:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iG5jm-00060C-MH for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 14:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60540) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iG5jm-000606-A1 for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 14:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iG5jm-0007Kf-2s for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 14:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2019 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37563 X-GNU-PR-Package: emacs Original-Received: via spool by 37563-submit@debbugs.gnu.org id=B37563.157012687928133 (code B ref 37563); Thu, 03 Oct 2019 18:22:02 +0000 Original-Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 18:21:19 +0000 Original-Received: from localhost ([127.0.0.1]:41128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5j3-0007Jf-Us for submit@debbugs.gnu.org; Thu, 03 Oct 2019 14:21:18 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:33789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5j2-0007JP-Bk for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 14:21:17 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id DBA0D160061 for <37563@debbugs.gnu.org>; Thu, 3 Oct 2019 20:21:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1570126868; bh=6FOC5PCHyAqu9nPfSDslnW4qTObfY3IjNeOY9R3fxdU=; h=From:To:Cc:Subject:Date:From; b=cBmsBGXqsHTFGRMVL2xVgSm6lekVgen65HDjRKGvP3p+Tz6QnL7VRa0GYCrYz5UOs ahnpYRWRcoR5II34Z2EaVdYwpB2ls3OrMB1nvsqU0FqeF4bwd1MH8beGL0G+87cVvU jb2md2YbBg+Q+ocwhXzsHqmW+AqwHgs2YNFsSoOzIvOoKHzcMuJ678jbelvgNUehRq j5v23DDafwHlIoO1Oy26sJRm9nZiDA2v6Gk30MG/6CsU2mupyjr17pPR/Z4791i+H2 65uAHsCMb3BChIouOYeBKrFQxRD48nu0JNEixn6rpXVG7dJ2Z3zgW/aTWeRLGsINMW aRrC+oHtzuyQg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46khCJ2Jm2z6tmN; Thu, 3 Oct 2019 20:21:00 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168269 Archived-At: On Thu, Oct 03 2019 20:10 (+0200), martin rudalics wrote: > > 4) *My interpretation* of `frame-resize-pixelwise' is that the default > > value, nil, has a single intention: To make the frame height an exact > > multiple of lines (and char width), mainly because of aesthetic reasons. > > In that case, I suggest we change the doc-string (which has some > > inaccurate phrasing and is a bit wordy, anyway) to say that it nil will > > round to a multiple of the default line height (incl line spacing).. > > We cannot reliably do that. Suppose a frame has two windows with > different line heights. Which one would we choose for rounding the > frame size? 'frame-char-height' is canonical. > > martin Okay, then I truly don't know how to write that succinctly. I suggest to keep using the char-height (and the `frame-resize-pixelwise' docstring) for the time being, that is, not change the code in the last part of the function. Personally, I will simple set `frame-resize-pixelwise' to t.