From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#19064: bug#17272: bug#19064: 25.0.50; `message' overwrites `y-or-n-p' prompt, so user misses it Date: Sat, 16 Nov 2019 22:53:51 +0200 Message-ID: <87lfsfmtk0.fsf@mail.linkov.net> References: <8ea0a3fa-5169-4493-bd54-3ebe47836a35@default> <87r3i9nped.fsf@gnus.org> <87wps1m7co.fsf@web.de> <87y4chjdop.fsf@gnus.org> <87o8ys3131.fsf@gnus.org> <875zjx6hs6.fsf@mail.linkov.net> <87sgmy3x22.fsf@gnus.org> <871rugbqmy.fsf@mail.linkov.net> <87d0dxyh7z.fsf@gnus.org> <53c55db5-d623-4946-af2e-d141e7bc7acd@default> <87sgmrpir5.fsf@web.de> <87mucya2a7.fsf@web.de> <87mucy4cb2.fsf@web.de> <621b98dc-0fe9-4eef-9e11-7580fb446e97@default> <87k1822ocn.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="39733"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 17272@debbugs.gnu.org, 19064@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 16 22:09:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iW5Jm-000ACg-57 for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2019 22:09:18 +0100 Original-Received: from localhost ([::1]:50098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iW5Jk-00016A-CD for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2019 16:09:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55994) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iW5JY-000120-6g for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 16:09:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iW5JX-0001oX-2r for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 16:09:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59209) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iW5JX-0001oP-0H for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 16:09:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iW5JW-0005mF-Qp for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 16:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Nov 2019 21:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19064 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 19064-submit@debbugs.gnu.org id=B19064.157393849322125 (code B ref 19064); Sat, 16 Nov 2019 21:09:02 +0000 Original-Received: (at 19064) by debbugs.gnu.org; 16 Nov 2019 21:08:13 +0000 Original-Received: from localhost ([127.0.0.1]:39792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iW5Ij-0005km-Fk for submit@debbugs.gnu.org; Sat, 16 Nov 2019 16:08:13 -0500 Original-Received: from azure.elm.relay.mailchannels.net ([23.83.212.7]:46073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iW5Ie-0005kR-D3; Sat, 16 Nov 2019 16:08:08 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4256E141730; Sat, 16 Nov 2019 21:08:07 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a75.g.dreamhost.com (100-96-89-221.trex.outbound.svc.cluster.local [100.96.89.221]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C057F1411C4; Sat, 16 Nov 2019 21:08:06 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a75.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 16 Nov 2019 21:08:07 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Imminent-Glossy: 54e8be703485e954_1573938487025_4138393681 X-MC-Loop-Signature: 1573938487025:4031513100 X-MC-Ingress-Time: 1573938487024 Original-Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id 76EA17F705; Sat, 16 Nov 2019 13:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=+pf0fb0CEAqGBkduS7O51B8dvFE=; b= YOr8bcQzjCI1U37QyXZ81y4dCmYcr+9Hz/jgrpxc9lryplYCchHoKRNZkJE5033N uNDKA1hYt60WqgMAs6s0GFFdhQjvEfqEr5esTNf7MfSNBX6/JpkNibGKmk3nyCD3 SQIC3p5mgxflfZibnw9uW/ae9JO9lvUBc8X2Slf31wo= Original-Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id 83D527F702; Sat, 16 Nov 2019 13:07:56 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a75 In-Reply-To: <87k1822ocn.fsf@web.de> (Michael Heerdegen's message of "Thu, 14 Nov 2019 21:29:44 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171739 Archived-At: >> That's easy to do. But the statement wasn't just >> about the minibuffer when echo area was meant, or >> vice versa. The claim was that _user input_ (not >> a prompt) became permanently hidden. > > I don't know if that was also a mistake or really meant like that. This is not a mistake. Permanently hidden user input is a serious problem and security threat. Today I started compilation, then in a Dired buffer requested files deletion that displayed the prompt: Delete D [54 files] (y or n) But before I had a chance to answer the prompt, compilation finished and obscured the prompt with this message permanently: Compilation finished So I forgot about what was in the prompt :-( Since Drew doesn't want to improve safety to cover all such cases, we need to address these issues one by one, so here is the next patch: diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 5a3386f227..101e294557 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -2265,7 +2265,8 @@ compilation-handle-exit (msg (format "%s %s" mode-name (replace-regexp-in-string "\n?$" "" (car status))))) - (message "%s" msg) + (with-current-buffer (window-buffer (old-selected-window)) + (minibuffer-message "%s" msg)) (propertize out-string 'help-echo msg 'face (if (> exit-status 0)