From: Michael Heerdegen <michael_heerdegen@web.de>
To: Pieter van Oostrum <pieter-l@vanoostrum.org>
Cc: "積丹尼 Dan Jacobson" <jidanni@jidanni.org>, 38818@debbugs.gnu.org
Subject: bug#38818: Dired: mention deleting buffers, not just windows
Date: Thu, 02 Jan 2020 05:14:15 +0100 [thread overview]
Message-ID: <87lfqqebqg.fsf@web.de> (raw)
In-Reply-To: <lx7e2bp1j7.fsf@cochabamba.vanoostrum.org> (Pieter van Oostrum's message of "Wed, 01 Jan 2020 17:46:52 +0100")
Pieter van Oostrum <pieter-l@vanoostrum.org> writes:
> > Slightly better version:
> >
> > (add-hook
> > 'dired-load-hook
> > (defun my-dired-load-hook-fun ()
> > (require 'dired-x)
> > (define-key dired-mode-map "q" #'kill-current-buffer)))
>
> The documentation of defun says that its result is undefined. So either
> it should not be relied upon, or (if the result is reliably the defined
> function) it should be documented as such.
Indeed: the return value of `defun' even changed recently (from
returning the definition to returning the defined symbol). Same for
defalias.
I think I'll file another bug report: adding user defined functions to
hooks not only has the common pitfall which is not warned about - the
alternative, using named functions, is also quite inconvenient since
defun's return value is unspecified. I guess most users currently do it
wrong. Or do I miss something?
Thanks,
Michael.
next prev parent reply other threads:[~2020-01-02 4:14 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 16:09 bug#38818: Dired: mention deleting buffers, not just windows 積丹尼 Dan Jacobson
2019-12-30 17:53 ` martin rudalics
2019-12-30 18:11 ` 積丹尼 Dan Jacobson
2019-12-31 7:59 ` martin rudalics
2019-12-31 17:33 ` Michael Heerdegen
2020-01-01 2:14 ` 積丹尼 Dan Jacobson
2020-01-01 2:47 ` Michael Heerdegen
2020-01-01 3:07 ` 積丹尼 Dan Jacobson
2020-01-01 3:45 ` Michael Heerdegen
2020-01-01 3:59 ` 積丹尼 Dan Jacobson
2020-01-01 4:53 ` Michael Heerdegen
2020-01-01 5:11 ` 積丹尼 Dan Jacobson
2020-01-01 5:31 ` Michael Heerdegen
2020-01-01 6:53 ` Drew Adams
2020-01-01 14:38 ` Noam Postavsky
2020-01-01 23:18 ` Richard Stallman
2020-01-02 3:29 ` Drew Adams
2020-01-02 21:59 ` Richard Stallman
2020-01-11 9:40 ` Eli Zaretskii
2020-01-01 16:46 ` Pieter van Oostrum
2020-01-02 4:14 ` Michael Heerdegen [this message]
2020-01-03 15:10 ` 積丹尼 Dan Jacobson
2020-01-03 23:18 ` Pieter van Oostrum
2020-01-03 23:31 ` 積丹尼 Dan Jacobson
2020-01-03 23:51 ` Pieter van Oostrum
2020-01-04 0:13 ` 積丹尼 Dan Jacobson
2020-01-04 13:58 ` Pieter van Oostrum
2020-01-04 23:48 ` Richard Stallman
2020-01-05 7:39 ` Pieter van Oostrum
2020-01-05 22:18 ` Richard Stallman
2020-01-05 8:06 ` Pieter van Oostrum
2020-01-05 15:31 ` Eli Zaretskii
2020-01-05 18:19 ` 積丹尼 Dan Jacobson
2020-01-05 18:48 ` Eli Zaretskii
2020-01-05 19:09 ` bug#38818: jidanni's mail headers not perfect?! 積丹尼 Dan Jacobson
2020-01-05 19:33 ` Eli Zaretskii
2020-01-05 20:48 ` Pieter van Oostrum
2020-01-06 3:26 ` Eli Zaretskii
2020-01-06 9:56 ` Pieter van Oostrum
2020-01-06 10:09 ` Eli Zaretskii
2020-01-06 10:16 ` Andreas Schwab
2020-01-06 8:30 ` Andreas Schwab
2020-01-06 8:50 ` Eli Zaretskii
2020-01-06 9:23 ` Andreas Schwab
2020-01-06 10:02 ` Eli Zaretskii
2020-01-06 10:13 ` Andreas Schwab
2020-01-05 22:19 ` bug#38818: Dired: mention deleting buffers, not just windows Richard Stallman
2020-01-05 23:30 ` 積丹尼 Dan Jacobson
2020-01-06 3:32 ` Eli Zaretskii
2020-01-06 23:08 ` Richard Stallman
2020-01-22 12:47 ` Lars Ingebrigtsen
2020-01-22 13:17 ` 積丹尼 Dan Jacobson
2020-01-22 13:19 ` Lars Ingebrigtsen
2020-01-04 6:16 ` Michael Heerdegen
2020-01-04 13:57 ` Pieter van Oostrum
2020-01-05 18:20 ` 積丹尼 Dan Jacobson
2020-01-04 13:26 ` Noam Postavsky
2020-01-01 6:47 ` Drew Adams
2020-01-22 12:51 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfqqebqg.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=38818@debbugs.gnu.org \
--cc=jidanni@jidanni.org \
--cc=pieter-l@vanoostrum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).