From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.bugs Subject: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el Date: Sun, 21 Jun 2020 17:44:24 +0000 Message-ID: <87lfkg48lr.fsf@thornhill.no> References: <87sgeo7ixe.fsf@thornhill.no> <87h7v4ip1g.fsf@tcd.ie> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_cUJKzeT8uERN30KjqPRvt1qxaHkw9gQVFVM9qvZbpQ" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="7184"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41977@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 21 19:45:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jn426-0001qO-4k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 19:45:30 +0200 Original-Received: from localhost ([::1]:45562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jn425-0007Xr-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 13:45:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jn41e-0007XW-OP for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 13:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49327) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jn41e-00029l-FE for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 13:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jn41e-0002Sl-DF for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jun 2020 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41977-submit@debbugs.gnu.org id=B41977.15927614769417 (code B ref 41977); Sun, 21 Jun 2020 17:45:02 +0000 Original-Received: (at 41977) by debbugs.gnu.org; 21 Jun 2020 17:44:36 +0000 Original-Received: from localhost ([127.0.0.1]:60873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn41D-0002Rp-QT for submit@debbugs.gnu.org; Sun, 21 Jun 2020 13:44:36 -0400 Original-Received: from mail-40134.protonmail.ch ([185.70.40.134]:41963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn41B-0002RW-Np for 41977@debbugs.gnu.org; Sun, 21 Jun 2020 13:44:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592761467; bh=V6qDdl4BBtgkXXt7gjw/K01UJWBSjtRmh0zbmd5tRGo=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=vmLDKyfyTsdXbSZbkBLRtnV9n0SyKoD1LoPd5mInZmpRrw+yikLhXl58jl2YI7BOT SUN6yU4SKBvViTJNrsjpi2+ww7JlvtRT59Jf8rNb3RtSC9sIPka79OBTfmt0rut5ND rQ75Wj1QfIuytvWAaYSBMC/vPEEt1fXTYmKa35X6ZMPsb+tnkM8Vajmprx8468AODd c5MJ4LuWyUie/4ZJiEDFGOibrONwXnCD1x1+9KOYppeamOu9V+q4oQx9P5ZEM1lpl9 H1mCz1D8qGIgvd77JmNZr04bSlTaIw0nnD2W65/cvJuAGpZ2xBJcJlyEw7Hd2LARGC TUra1SqpTZymQ== In-Reply-To: <87h7v4ip1g.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182252 Archived-At: This is a multi-part message in MIME format. --b1_cUJKzeT8uERN30KjqPRvt1qxaHkw9gQVFVM9qvZbpQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Basil L. Contovounesios" writes: > Since eshell-buffer-name is a variable, eval-when-compile is not the > right thing to do here. Instead, there should be a > (defvar eshell-buffer-name) inside project-eshell declaring the symbol > as special. Right? You are absolutely correct, and TIL - thanks :) Below is another patch doing this. Works fine in emacs -Q Theo --b1_cUJKzeT8uERN30KjqPRvt1qxaHkw9gQVFVM9qvZbpQ Content-Type: text/x-patch; name=0001-Forward-declare-eshell-buffer-name-in-project-eshell.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Forward-declare-eshell-buffer-name-in-project-eshell.patch RnJvbSAyYzE2YWI4N2UzNjlhYjMxNWQ0M2Q1ZTFkNjk2NWYxMjc4YzJjMjQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGVvZG9yIFRob3JuaGlsbCA8dGhlb0B0aG9ybmhpbGwubm8+ CkRhdGU6IFN1biwgMjEgSnVuIDIwMjAgMTk6MTU6MzcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBG b3J3YXJkIGRlY2xhcmUgZXNoZWxsLWJ1ZmZlci1uYW1lIGluIHByb2plY3QtZXNoZWxsCgoqIGxp c3AvcHJvZ21vZGVzL3Byb2plY3QuZWw6IEZvcndhcmQgZGVjbGFyZXMgJ2VzaGVsbC1idWZmZXIt bmFtZScgc28KdGhhdCAncHJvamVjdC1lc2hlbGwnIGNhbiB1c2UgdGhlIHNwZWNpYWwgdmFyaWFi bGUgaW4gZXNoZWxsLgotLS0KIGxpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgfCAxICsKIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3By b2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9wcm9qZWN0LmVsCmluZGV4IDc0NDk1Y2YwN2EuLjcx NWYwNDgwYmIgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlz cC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAtNzQwLDYgKzc0MCw3IEBAIHByb2plY3QtZXNoZWxs CiBXaXRoIFxcW3VuaXZlcnNhbC1hcmd1bWVudF0gcHJlZml4LCBjcmVhdGUgYSBuZXcgRXNoZWxs IGJ1ZmZlcgogd2l0aCB1bmlxdWlmaWVkIG5hbWUuIgogICAoaW50ZXJhY3RpdmUpCisgIChkZWZ2 YXIgZXNoZWxsLWJ1ZmZlci1uYW1lKQogICAobGV0KiAoKGRlZmF1bHQtZGlyZWN0b3J5IChwcm9q ZWN0LXJvb3QgKHByb2plY3QtY3VycmVudCB0KSkpCiAgICAgICAgICAoZXNoZWxsLWJ1ZmZlci1u YW1lCiAgICAgICAgICAgIChjb25jYXQgIioiIChmaWxlLW5hbWUtbm9uZGlyZWN0b3J5Ci0tIAoy LjI3LjAKCg== --b1_cUJKzeT8uERN30KjqPRvt1qxaHkw9gQVFVM9qvZbpQ--