From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#41030: [PATCH] Make EWW respect XDG download directory by default Date: Fri, 17 Jul 2020 15:09:21 +0200 Message-ID: <87lfjinv9a.fsf@gnus.org> References: <20200502165842.8564-1-philip@warpmail.net> <874ksu3i9e.fsf@bulbul> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38599"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: contovob@tcd.ie, stefan@marxist.se, 41030@debbugs.gnu.org To: philip@warpmail.net (Philip K.) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 17 15:10:31 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwQ8E-0009v3-3P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jul 2020 15:10:30 +0200 Original-Received: from localhost ([::1]:37158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwQ8D-0001Vm-3H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jul 2020 09:10:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwQ7m-0001Px-MH for bug-gnu-emacs@gnu.org; Fri, 17 Jul 2020 09:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jwQ7m-0002WK-Ao for bug-gnu-emacs@gnu.org; Fri, 17 Jul 2020 09:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jwQ7l-0000NQ-RP for bug-gnu-emacs@gnu.org; Fri, 17 Jul 2020 09:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jul 2020 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41030 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41030-submit@debbugs.gnu.org id=B41030.15949913751410 (code B ref 41030); Fri, 17 Jul 2020 13:10:01 +0000 Original-Received: (at 41030) by debbugs.gnu.org; 17 Jul 2020 13:09:35 +0000 Original-Received: from localhost ([127.0.0.1]:56869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwQ7L-0000Mg-MS for submit@debbugs.gnu.org; Fri, 17 Jul 2020 09:09:35 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:43244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwQ7I-0000MP-Ev for 41030@debbugs.gnu.org; Fri, 17 Jul 2020 09:09:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9UUvKWr271CayM5Ce38VsdvXep/DqjlU+NhXjSCd74s=; b=EvM5a9pS9t+t7290tkk4fIlRo+ 9bDMXQ9zfNtpXl927Iuh135mVNwRZjE9XNaLenGtvggy/HGTeTv3pT9LHe/SPx9mz4bmdN3dJnICz zlpX+nT3WfC+ueO34ZTumbbQV+H3idl608YkvIqsJ4rlAeuNNxGb/NkhtsftRyJssRtE=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwQ78-0004Ae-Nl; Fri, 17 Jul 2020 15:09:25 +0200 In-Reply-To: <874ksu3i9e.fsf@bulbul> (Philip K.'s message of "Tue, 05 May 2020 10:20:29 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183143 Archived-At: philip@warpmail.net (Philip K.) writes: >> I think that is ~/Downloads/ exists, it's a good hint that the user >> wants to use ~/Downloads/, no matter what xdg-user-dir says. > > So should it check for "~/Downloads/" first (and maybe perhaps a few > other popular directory names in other languages), and unless that > hasn't been found load xdg.el and call xdg-user-dir? Yes, perhaps something like that. But we don't want to do that checking at load time, I think? And the same goes for the call to xdg-user-dir -- that doesn't be done at load time, either. (And the patch isn't correct as is, either, because xdg-user-dir returns the directory without a trailing slash.) So perhaps eww-download-directory should default to a function that does all this checking and calling? Any opinions? And... as far as I can see, xdg-user-dir isn't used anywhere else in Emacs? What's up with that? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no