unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: philip@warpmail.net (Philip K.)
Cc: contovob@tcd.ie, stefan@marxist.se, 41030@debbugs.gnu.org
Subject: bug#41030: [PATCH] Make EWW respect XDG download directory by default
Date: Fri, 17 Jul 2020 15:09:21 +0200	[thread overview]
Message-ID: <87lfjinv9a.fsf@gnus.org> (raw)
In-Reply-To: <874ksu3i9e.fsf@bulbul> (Philip K.'s message of "Tue, 05 May 2020 10:20:29 +0200")

philip@warpmail.net (Philip K.) writes:

>> I think that is ~/Downloads/ exists, it's a good hint that the user
>> wants to use ~/Downloads/, no matter what xdg-user-dir says.
>
> So should it check for "~/Downloads/" first (and maybe perhaps a few
> other popular directory names in other languages), and unless that
> hasn't been found load xdg.el and call xdg-user-dir?

Yes, perhaps something like that.

But we don't want to do that checking at load time, I think?  And the
same goes for the call to xdg-user-dir -- that doesn't be done at load
time, either.

(And the patch isn't correct as is, either, because xdg-user-dir returns
the directory without a trailing slash.)

So perhaps eww-download-directory should default to a function that does
all this checking and calling?

Any opinions?

And... as far as I can see, xdg-user-dir isn't used anywhere else in
Emacs?  What's up with that?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-07-17 13:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02 16:58 bug#41030: [PATCH] Make EWW respect XDG download directory by default Philip K
2020-05-03 22:52 ` Stefan Kangas
2020-05-03 23:28   ` Basil L. Contovounesios
2020-05-05  8:02     ` Lars Ingebrigtsen
2020-05-05  8:20       ` Philip K.
2020-07-17 13:09         ` Lars Ingebrigtsen [this message]
2020-07-29  5:14           ` Lars Ingebrigtsen
2020-05-05 21:32     ` Stefan Kangas
2020-05-06  0:04       ` Noam Postavsky
2020-05-06  0:17         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfjinv9a.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=41030@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=philip@warpmail.net \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).