From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39349: browse-url-of-dired-file should respect directory symlinks Date: Sun, 19 Jul 2020 21:48:36 +0200 Message-ID: <87lfjfl20b.fsf@gnus.org> References: <87lfpqveo7.5.fsf@jidanni.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5438"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39349@debbugs.gnu.org To: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 19 21:49:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxFJ6-0001Dw-UF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jul 2020 21:49:08 +0200 Original-Received: from localhost ([::1]:33868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxFJ5-00087S-Pd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jul 2020 15:49:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxFIz-000864-T3 for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2020 15:49:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxFIz-0000WN-K6 for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2020 15:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxFIz-0003ZL-Ir for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2020 15:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jul 2020 19:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39349 X-GNU-PR-Package: emacs Original-Received: via spool by 39349-submit@debbugs.gnu.org id=B39349.159518813113702 (code B ref 39349); Sun, 19 Jul 2020 19:49:01 +0000 Original-Received: (at 39349) by debbugs.gnu.org; 19 Jul 2020 19:48:51 +0000 Original-Received: from localhost ([127.0.0.1]:33085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxFIo-0003Yw-PR for submit@debbugs.gnu.org; Sun, 19 Jul 2020 15:48:50 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxFIn-0003Yj-C9 for 39349@debbugs.gnu.org; Sun, 19 Jul 2020 15:48:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GLqrvE4s9yyOZ4/k0VTE6RC79YhVtGteH/550vFO0Ow=; b=UCWa3z2sg71U6DeScksW57ktR6 hTzvM28WwBWc5MzhDX5Vv8Z+LhyuH7qurlAGQ58cCpT3H2240Slof/IKLNp0YrAPt2dt4UvSvbmbV 1oP2FwAxNdc7ezkYiQncufSX1ov01xmAZpFDd2uo6RHR/pmXvV3RFGj8mKZvKbwkK33c=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxFIc-0004Ed-3r; Sun, 19 Jul 2020 21:48:42 +0200 In-Reply-To: <87lfpqveo7.5.fsf@jidanni.org> ("=?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson"'s message of "Wed, 29 Jan 2020 16:40:24 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183261 Archived-At: =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson writes: > browse-url-of-dired-file should respect directory symlinks. > E.g., > $ emacs -q > C-x d /cf/updates/ > SPC SPC SPC > M-x browse-url-of-dired-file > should call the browser on > file:///cf/updates/52.html > not the absolute path > file:///mnt/usb/cf/updates/52.html So /cf is a symlink in your setup? The reason for this behaviour is a patch from 2011 which attempted to make this command work on the "." and ".." directories: (let ((tem (dired-get-filename t t))) (if tem (browse-url-of-file (expand-file-name tem)) So we want to call with (browse-url-of-file "/") instead of (browse-url-of-file "/tmp/.."), for instance, and use expand-file-name to achieve that. However, that function also resolves any symlinks... This function just needs to do the ../. thing. Does Emacs have a function that just does the right thing the ".." and "/" and does absolutely nothing else? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no