From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#19032: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Date: Thu, 10 Sep 2020 21:51:34 +0300 Organization: LINKOV.NET Message-ID: <87lfhh8nyh.fsf@mail.linkov.net> References: <8736433l4c.fsf@iris.silentflame.com> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> <87ft7qvc0j.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23114"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 19032@debbugs.gnu.org, Stefan Monnier , 43120@debbugs.gnu.org, Lars Ingebrigtsen , OGAWA Hirofumi , Sean Whitton To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 10 20:57:57 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGRlc-0005rb-R2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 20:57:56 +0200 Original-Received: from localhost ([::1]:35460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGRlb-0001el-Rz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 14:57:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGRhq-0004NV-K6 for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57895) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGRhq-0008FZ-BQ for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGRhq-0005Hc-8E for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2020 18:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 19032-submit@debbugs.gnu.org id=B19032.159976400120252 (code B ref 19032); Thu, 10 Sep 2020 18:54:02 +0000 Original-Received: (at 19032) by debbugs.gnu.org; 10 Sep 2020 18:53:21 +0000 Original-Received: from localhost ([127.0.0.1]:41206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRhB-0005GY-22 for submit@debbugs.gnu.org; Thu, 10 Sep 2020 14:53:21 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:60387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRh9-0005GF-1X; Thu, 10 Sep 2020 14:53:20 -0400 Original-Received: from mail.gandi.net (m91-129-97-241.cust.tele2.ee [91.129.97.241]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id D8CF2200002; Thu, 10 Sep 2020 18:53:07 +0000 (UTC) In-Reply-To: <87ft7qvc0j.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 09 Sep 2020 23:08:44 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187753 Archived-At: > Though I'm starting to think that when require-match is nil, an > icomplete user wouldn't want the new icomplete-show-matches-on-no-input > behaviour anyway. This is confusing, I don't understand why behaviour of icomplete-show-matches-on-no-input should depend on require-match. Here are two examples that produce a different result. The first example is from hi-lock-read-face-name: (defvar hi-history nil) (icomplete-mode) (let ((icomplete-show-matches-on-no-input t) (defaults '("hi-yellow" "hi-green")) (hi-history '("hi-blue"))) (completing-read (format-prompt "Highlight using face" (car defaults)) obarray 'facep t nil 'hi-history defaults)) displays this prompt: Highlight using face (default hi-yellow): {link | menu | bold ... Typing RET returns "link" (and sometimes returns "hi-blue" from the history), but never returns the expected default value "hi-yellow". Whereas the second example from tab-bar-switch-to-tab works correctly since its arg require-match is nil: (let ((icomplete-show-matches-on-no-input t) (defaults '("yellow" "green")) (hi-history '("blue"))) (completing-read (format-prompt "Switch to tab by name" (car defaults)) defaults nil nil nil 'hi-history defaults)) displays this prompt: Switch to tab by name (default yellow): {green | yellow} Typing RET returns the default value "yellow", not the first candidate "green". This makes the behaviour of icomplete-show-matches-on-no-input unpredictable, and thus in some cases dangerous.