unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: dmoncayo@gmail.com, 9917@debbugs.gnu.org,
	monnier@iro.umontreal.ca, 5042@debbugs.gnu.org
Subject: bug#5042: bug#9917: 24.0.90; Make `goto-line' consistent with the line number from the minibuffer
Date: Mon, 21 Sep 2020 22:03:44 +0300	[thread overview]
Message-ID: <87lfh3dtoj.fsf@mail.linkov.net> (raw)
In-Reply-To: <87wo0osspd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 20 Sep 2020 11:28:14 +0200")

> However, if people have a narrowed buffer, and are looking at (say) the
> compilation output that says "error on like 45" in a shell, then `M-g g
> 45' will definitely do the wrong thing is we change the command to start
> counting from the start of the narrowed region.

In this case another option is to widen the buffer before going to that line.
This is what for example help-function-def--button-function does:

            ;; Widen the buffer if necessary to go to this position.
            (when (or (< position (point-min))
                      (> position (point-max)))
              (widen))
            (goto-char position)

Unfortunately, xref doesn't provide such nice feature,
so 'M-.' fails to navigate in a narrowed buffer.

For 'M-g M-g' this means removing 'save-restriction' from 'goto-line'.

> So a new command and keystroke seems warranted.  How about...
> `M-g M-v'?   (The mnemonic is "goto visual line".)

Or to add a new key to narrow-map 'C-x n' that currently
contains only 4 keys:

  C-x n d         narrow-to-defun
  C-x n n         narrow-to-region
  C-x n p         narrow-to-page
  C-x n w         widen

where a new key could be:

  C-x n g         go to narrowed line





  reply	other threads:[~2020-09-21 19:03 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 14:31 bug#9917: 24.0.90; Make `goto-line' consistent with the line number from the minibuffer Dani Moncayo
2011-11-01  9:35 ` Juri Linkov
2011-11-01 17:56   ` Stefan Monnier
2011-11-01 22:35     ` Juri Linkov
2011-11-01 23:22       ` Drew Adams
2011-11-02  9:48         ` Juri Linkov
2011-11-02 12:59           ` Drew Adams
2011-11-02  9:46     ` Juri Linkov
2020-09-19 17:42 ` bug#5042: " Lars Ingebrigtsen
2020-09-19 18:01   ` Stefan Monnier
2020-09-19 19:27     ` bug#9917: bug#5042: " Drew Adams
2020-09-19 19:56       ` Eli Zaretskii
2020-09-19 18:33   ` Eli Zaretskii
2020-09-20  9:28     ` Lars Ingebrigtsen
2020-09-21 19:03       ` Juri Linkov [this message]
2020-09-22 14:37         ` Lars Ingebrigtsen
2020-09-22 18:08           ` Juri Linkov
2020-09-22 20:10             ` Drew Adams
2020-09-23 14:14               ` bug#5042: bug#9917: " Eli Zaretskii
2020-09-23 13:18             ` Lars Ingebrigtsen
2020-09-23 17:58               ` Drew Adams
2020-09-24  7:39                 ` Robert Pluim
2020-09-24 17:31                   ` bug#9917: " Drew Adams
2020-10-29  9:19           ` Juri Linkov
2020-10-29 14:31             ` Eli Zaretskii
2020-10-30  7:27               ` Juri Linkov
2020-10-30  8:19                 ` Eli Zaretskii
2020-10-29 16:44             ` bug#5042: " Drew Adams
2020-10-30  9:49             ` Lars Ingebrigtsen
2020-10-31 19:28               ` Juri Linkov
2020-10-31 20:00                 ` bug#5042: " Eli Zaretskii
2020-10-27 20:52         ` Juri Linkov
2020-10-28  9:48           ` bug#5042: " Lars Ingebrigtsen
2020-10-28 11:58             ` Dmitry Gutov
2020-10-30  9:44               ` Lars Ingebrigtsen
     [not found] <<CAH8Pv0jBbJoyJfW+Xh-m3kqGQnVc0eO2+kM40SJ23JOKiBrx-A@mail.gmail.com>
     [not found] ` <<877dspmzo3.fsf@gnus.org>
     [not found]   ` <<jwv4kntbqep.fsf-monnier+emacs@gnu.org>
     [not found]     ` <<28534d1c-6652-4cfe-acb4-f0a30624f878@default>
     [not found]       ` <<83tuvt1qwq.fsf@gnu.org>
2020-09-19 20:22         ` Drew Adams
2020-09-19 20:27           ` bug#9917: " Eli Zaretskii
     [not found]   ` <<83zh5l1uqw.fsf@gnu.org>
     [not found]     ` <<87wo0osspd.fsf@gnus.org>
     [not found]       ` <<87lfh3dtoj.fsf@mail.linkov.net>
     [not found]         ` <<878sd1j2rv.fsf@gnus.org>
     [not found]           ` <<871ritbs6t.fsf@mail.linkov.net>
     [not found]             ` <<cd8f2969-6705-46c8-b090-03e284b0ba0c@default>
     [not found]               ` <<83zh5gvauy.fsf@gnu.org>
2020-09-23 18:09                 ` bug#5042: " Drew Adams
2020-09-23 19:40                   ` Juri Linkov
     [not found] <<<CAH8Pv0jBbJoyJfW+Xh-m3kqGQnVc0eO2+kM40SJ23JOKiBrx-A@mail.gmail.com>
     [not found] ` <<<877dspmzo3.fsf@gnus.org>
     [not found]   ` <<<jwv4kntbqep.fsf-monnier+emacs@gnu.org>
     [not found]     ` <<<28534d1c-6652-4cfe-acb4-f0a30624f878@default>
     [not found]       ` <<<83tuvt1qwq.fsf@gnu.org>
     [not found]         ` <<1cfba469-3adf-4287-a1fa-647e4e5e83e2@default>
     [not found]           ` <<83pn6h1pie.fsf@gnu.org>
2020-09-19 21:10             ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfh3dtoj.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=5042@debbugs.gnu.org \
    --cc=9917@debbugs.gnu.org \
    --cc=dmoncayo@gmail.com \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).