From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43450: 28.0.50; Python shell doesn't echo if shebang Date: Fri, 02 Oct 2020 05:40:37 +0200 Message-ID: <87lfgpz45m.fsf@gnus.org> References: <87362z2oqf.fsf@gnus.org> <87r1qhz4i7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34413"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43450@debbugs.gnu.org To: Gunnar Horrigmo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 02 05:41:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOBwZ-0008ql-38 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Oct 2020 05:41:15 +0200 Original-Received: from localhost ([::1]:42248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOBwX-0005Yn-J1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 23:41:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOBwN-0005YX-UJ for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 23:41:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOBwM-0002xG-25 for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 23:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kOBwL-0000O4-Va for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 23:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Oct 2020 03:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43450 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 43450-submit@debbugs.gnu.org id=B43450.16016100521465 (code B ref 43450); Fri, 02 Oct 2020 03:41:01 +0000 Original-Received: (at 43450) by debbugs.gnu.org; 2 Oct 2020 03:40:52 +0000 Original-Received: from localhost ([127.0.0.1]:38956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOBwC-0000NZ-Ei for submit@debbugs.gnu.org; Thu, 01 Oct 2020 23:40:52 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOBw8-0000NI-E7 for 43450@debbugs.gnu.org; Thu, 01 Oct 2020 23:40:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=B3Lfd0yzF8mkFrJx1sBxbf37b5rJqrhsylLgbS8Z6ko=; b=LTSAsuLfNQeAzX1bmJ3R2Uic0z VYsDSFCdHWu9sf9X/UxZdTRlBSOcJhBFRJ7Ix4UAb3Sq2bfPpEiAeTx562VZVJmkKZzhRB8+U+Zbo lnmRudHTk2C0qK6jgxSUQxLkvz5BOE2Vr9Zm8yj6dpSRmzLRK4URxNH3aFA0H+z+TGrg=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOBvy-00077C-Vn; Fri, 02 Oct 2020 05:40:41 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEW9va6Kh3hkWVZH PDr///+UfqoJAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QKAgMkHTEQEDgAAAGaSURBVDjLZZOLtQMh CERhKxAqWLQD7b+3N4MafYl7ogl3B+QTERGvc1kdo4holbUSeA3zkbZaFngIohrXP+D0gsci7Xor wgxbqPy4AhjcpVwKpa9SW4+vGEuRwApBuW6VQK18BUd0gFfp6wCbebRe09WtCK/d6UrU7gSjhro3 7AVAr8wLPsxQca9iF8BlOyrirNYGKuXBXZw55FaWKxPDixoJNFMjUMEbnnkQZOIATAdANzAvsyRC TdhTX6SCqPakCbViMfFzKwIAR32pw1eC4tkodtFqvMKalWeWaoKK6wZuOptMMNoCcKVqG2CkRmXZ GQNDoQe0bNQEUg7obRA4HuRhB8BXzyoi37KavoN3nuhIzfw+ADFSlRcTO6AukEUUPzEI2gbFLgDj 0z1YcDmu0PJe48E4sEhygnOCAiDH6QZoEsNE/rGo39OOEXVbsXItQUuRsSsN1g6QowCA4voMleeQ j7qnbtYFBgJmDHXb7vOUE27ss48Fxja0cZYcOwEjwFVrAOO8NwGbmWBc4ArevkDvg3kNGb+KXH8p Hmz33toaLQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMC0wMlQwMzozNjoyOCswMDowMLanS0UA AAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTAtMDJUMDM6MzY6MjgrMDA6MDDH+vP5AAAAAElFTkSu QmCC X-Now-Playing: Stephan Mathieu's _On Tape_: "(untitled)" In-Reply-To: <87r1qhz4i7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 02 Oct 2020 05:33:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189612 Archived-At: Lars Ingebrigtsen writes: > I have to admit that I don't understand the reason for the coding cookie > at all -- we bind coding-system-for-write to utf-8 before writing the > temp file anyway, and on the Python side, we specify the coding system > explicitly there, too. OK, I think this is basically the point of it all: (defun python-shell--save-temp-file (string) (let* ((temporary-file-directory (if (file-remote-p default-directory) (concat (file-remote-p default-directory) "/tmp") temporary-file-directory)) (temp-file-name (make-temp-file "py")) (coding-system-for-write (python-info-encoding))) (with-temp-file temp-file-name (insert string) (delete-trailing-whitespace)) temp-file-name)) If the current buffer has a coding cookie, we use that in the temp files we load, too. That's logical (er, somewhat, why not just use the current buffer coding system?), but if there's no coding cookie, we still add one, which isn't. Anyway, I think the change I made is unlikely to break anything... possibly... unless you have a Python file with a coding system cookie, and you're eval-ing a non-ASCII string, and it's not all utf-8. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no