From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45748: [PATCH] * test/src/xdisp-tests.el Fix tests to work in batch mode Date: Sat, 16 Jan 2021 17:57:56 +0000 Message-ID: <87lfcsydaz.fsf@tcd.ie> References: <20210116171245.89807-1-aaronjensen@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32925"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45748@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 16 18:59:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0pqx-0008SG-DP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jan 2021 18:59:11 +0100 Original-Received: from localhost ([::1]:50282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0pqw-0002E8-9C for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jan 2021 12:59:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0pqo-0002E0-KX for bug-gnu-emacs@gnu.org; Sat, 16 Jan 2021 12:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60644) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0pqo-0001wk-DY for bug-gnu-emacs@gnu.org; Sat, 16 Jan 2021 12:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0pqo-0001TU-D3 for bug-gnu-emacs@gnu.org; Sat, 16 Jan 2021 12:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jan 2021 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45748 X-GNU-PR-Package: emacs Original-Received: via spool by 45748-submit@debbugs.gnu.org id=B45748.16108198875584 (code B ref 45748); Sat, 16 Jan 2021 17:59:02 +0000 Original-Received: (at 45748) by debbugs.gnu.org; 16 Jan 2021 17:58:07 +0000 Original-Received: from localhost ([127.0.0.1]:43957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0ppu-0001Rz-UT for submit@debbugs.gnu.org; Sat, 16 Jan 2021 12:58:07 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:46490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0pps-0001RV-M3 for 45748@debbugs.gnu.org; Sat, 16 Jan 2021 12:58:05 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id d13so12429257wrc.13 for <45748@debbugs.gnu.org>; Sat, 16 Jan 2021 09:58:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=35YbgjQAD8g1y2iWp3BHoQ6d7GGurxLlbJA2Mub7l2k=; b=JS+nvo5R7vi5tTNptzbwBjONs9OiZk8Og7EY8RxxgKCC77KEDi/uCJDld7qttyLT7V cIZMcK0GUi4S1+uneizpkzEBTtdagsjrSBpF1Bx0kq0PD76DCGI7VBdE7hIpQARJ+WW3 qR+ZaA4dOeZB6Hy0mbae1Cp+dhF1k1ltWSP9Y61+vee3JQEtgXqeVpEbC2qniu/bpLPq pMboUAjdlMJ7oQi6FnNvYBBawE/tsYuV1FEBPa2oKUpzs1e/5r9LcQNf0GroRlLQz9W2 1Qucjt6TNGK8Ndkmx7dtI+nQ41sXhkhxkeYejOeiCbdXbt3utruubCECgsHT94tcQjCi k1qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=35YbgjQAD8g1y2iWp3BHoQ6d7GGurxLlbJA2Mub7l2k=; b=Ye7AZznAm15QPwTYPBkZednDpigHyGyIefVraYI0Bae7f/ahIDLXVG4jIegt/38G3i Hu6ZdkeL/hO82zn0Y66a7WAH/enwUF10T4KEdjyEB7r2TVpPbEjv8Xt3OhVcITH5g5Ej HTWR/OKUUDoGmRrdKa0pp57/Emyg3Ag779MJ2lTME7ZvEe4fbHiXLsToU6F2b95tixCK rIoxvQyJ4qa18CaoB3YFzjp88WySoc5luPhZT4yapqtWWzYUKL1Dbhz0Ok3kFYp9+xqj rk+v30xfKCOIdkDGriWs4i7QURutFkI9DUBxinEgyF8c4WS4vNOV9ReMXVb9H8LB/ch8 1wbQ== X-Gm-Message-State: AOAM53091o96LNd9NqC7u+cwHc0xU5NFIiXXxwrSBvAI7tNYdEF1kzkd Y9QoEhzYxqC6th9gxczZLgjR6A== X-Google-Smtp-Source: ABdhPJxxC/HAoWy3dwSnfiqCRHopblqY+La5p1xdcJPWXS9RWCM+vrj686AueAG+rlA3Y9v6qYrJxg== X-Received: by 2002:a5d:4f10:: with SMTP id c16mr18494277wru.398.1610819878822; Sat, 16 Jan 2021 09:57:58 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id u14sm6060680wmq.45.2021.01.16.09.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jan 2021 09:57:58 -0800 (PST) In-Reply-To: <20210116171245.89807-1-aaronjensen@gmail.com> (Aaron Jensen's message of "Sat, 16 Jan 2021 11:12:45 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198027 Archived-At: Aaron Jensen writes: > diff --git a/test/src/xdisp-tests.el b/test/src/xdisp-tests.el > index ec96d777ff..09c2fa83b3 100644 > --- a/test/src/xdisp-tests.el > +++ b/test/src/xdisp-tests.el > @@ -73,33 +73,36 @@ xdisp-tests--minibuffer-scroll > (should (equal (nth 1 posns) (nth 2 posns))))) > > (ert-deftest xdisp-tests--window-text-pixel-size () ;; bug#45748 FWIW, you can also include the bug number in the test's docstring, if you prefer. > - (with-temp-buffer > + (with-current-buffer-window "*test*" 'display-buffer-reuse-window nil Ideally the tests wouldn't leave this buffer lying around after they have run; see (info "(ert) Tests and Their Environment"). Also, why does this test not use with-current-buffer like the other ones? > + (erase-buffer) > (insert "xxx") > - (let* ((window > - (display-buffer (current-buffer) '(display-buffer-in-child-frame . nil))) > - (char-width (frame-char-width)) > - (size (window-text-pixel-size nil t t))) > - (delete-frame (window-frame window)) > + (let* ((char-width (frame-char-width)) Nit: this and subsequent let* can also be let. > + (size (window-text-pixel-size (get-buffer-window) t t))) Is get-buffer-window necessary? > + (message "Size: %S" size) This debugging leftover should probably be removed. > + (should (equal (/ (car size) char-width) 3))))) Thanks, -- Basil