bug#6221: 23.1; checkdoc-ispell-lisp-words when ispell already running

bug#6221: 23.1; checkdoc-ispell-lisp-words when ispell already running

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

When using the spell-checking feature of M-x checkdoc, if flyspell-mode
is enabled then the checkdoc-ispell-lisp-words are not recognised as
correct.  For example with the foo.el below

    (progn
      (setq checkdoc-spellcheck-documentation-flag t)
      (find-file "foo.el")
      (turn-on-flyspell)
      (checkdoc))

    => asks to correct spelling of "keymap"

It looks like checkdoc-ispell-init assumes that if an ispell-process
exists then it was checkdoc-ispell-init which started it and therefore
doesn't need the checkdoc-ispell-lisp-words sent again.  Of course
that's not the case if using flyspell, and presumably also not if you
use ispell.el directly and still have the process running.

Perhaps a flag meaning "checkdoc-ispell-lisp-words already sent" could
to be attached to the process object, to send just once.  Does it hurt
to send the words more than once?  The simplest thing could be to just
send them every time.


[-- Attachment #2: foo.el --]
[-- Type: application/emacs-lisp, Size: 203 bytes --]

[-- Attachment #3: Type: text/plain, Size: 1076 bytes --]



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

bug#6221: 23.1; checkdoc-ispell-lisp-words when ispell already running

[Lars Ingebrigtsen]

Kevin Ryde <user42@zip.com.au> writes:

> Perhaps a flag meaning "checkdoc-ispell-lisp-words already sent" could
> to be attached to the process object, to send just once.  Does it hurt
> to send the words more than once?  The simplest thing could be to just
> send them every time.

I've now changed this as you suggest in Emacs 28, but after committing
I'm not 100% sure that this is the correct thing to do, since this means
that "keymap" etc will now be valid in other buffers you use flyspell
in, too?  I think?

Should checkdoc kill the ispell process and start a new one?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#6221: 23.1; checkdoc-ispell-lisp-words when ispell already running

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I've now changed this as you suggest in Emacs 28, but after committing
> I'm not 100% sure that this is the correct thing to do, since this means
> that "keymap" etc will now be valid in other buffers you use flyspell
> in, too?  I think?
>
> Should checkdoc kill the ispell process and start a new one?

Indeed.  The comment says:

;;   There is a list of Lisp-specific words which checkdoc will
;; install into Ispell on the fly, but only if Ispell is not already
;; running.  Use `ispell-kill-ispell' to make checkdoc restart it with
;; these words enabled.

So I've reverted the change, and instead added this text to the
checkdoc-spellcheck-documentation-flag doc string.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no