bug#47080: 28.0.50; Spurious variable left uninitialized compiler warning

[Lars Ingebrigtsen <larsi@gnus.org>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Indeed, it's a useless binding: you could just use nil instead wherever
> you use that var, so the warning is working as intended.  And indeed, it
> found a few places where we bound a var to nil and then just
> returned its value (and it's thanks to this warning that I discovered
> that those var needed to be declared as dynamically scoped).

Oh, is that what the warning means.  :-)  It's not immediately
obvious -- could it be changed to something like...  er...  "Variable
bound to constant value and not changed"?

> But the above `pcase` and `syntax-propertize-rules` show that it can be
> quite inconvenient.  I can probably fix `pcase` to work around the
> issue, but ... it's probably better to tone down the warning so it's
> only issued if the nil binding is implicit rather than explicit.

Right.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no