From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#47572: 27.1; (setf (map-elt m key) value) should return value but does not Date: Sun, 04 Apr 2021 19:31:48 +0100 Message-ID: <87lf9x52az.fsf@tcd.ie> References: <87eefsfl8f.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29725"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47572@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 04 20:33:55 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lT7ZL-0007cl-4m for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 20:33:55 +0200 Original-Received: from localhost ([::1]:41522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT7ZK-0004BQ-6C for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 14:33:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT7YY-00049a-Gm for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 14:33:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lT7YU-0000xD-Bn for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 14:33:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lT7YU-0005Vi-96 for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 14:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Apr 2021 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47572 X-GNU-PR-Package: emacs Original-Received: via spool by 47572-submit@debbugs.gnu.org id=B47572.161756112321118 (code B ref 47572); Sun, 04 Apr 2021 18:33:02 +0000 Original-Received: (at 47572) by debbugs.gnu.org; 4 Apr 2021 18:32:03 +0000 Original-Received: from localhost ([127.0.0.1]:36446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT7XX-0005UT-Hr for submit@debbugs.gnu.org; Sun, 04 Apr 2021 14:32:03 -0400 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:44745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT7XQ-0005Tl-EW for 47572@debbugs.gnu.org; Sun, 04 Apr 2021 14:31:58 -0400 Original-Received: by mail-wr1-f50.google.com with SMTP id c8so9115657wrq.11 for <47572@debbugs.gnu.org>; Sun, 04 Apr 2021 11:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=fBFYHMTPmH/MwW6SWtky8OOUVoT91wkybqc3Us35GkQ=; b=AxhuSmRxbg7/kBVTFzoMDbOoFgkLhSCGA+lAxotmrCmouY3DRYvyJIn36TJDhGQ6Y9 GBrR1N2b0GxvQNse65ILf0kulfW1dEiuKsViYqVtb+OHvUh8ogw3SuQBDD88Ro+0hjWb b/7J6T8HFk5C36xaQD6RotccZsHfV/m+Z5lu8nzj3OUO30CX1MgfCyheJi2b29HdmA9Q EHksOk01DHuqwss5uLmGvUJ/0auWlh/6msM2BgXSD1PWwMOLLmCCd9FiwuBfhfSciwvU tIbwXDT9VdqRjEDjVbAj0/ZSlZ1ov9U/O6r7B+ZGw9K1aaknTcnmpRDPWAwoj8CwAY23 cnHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=fBFYHMTPmH/MwW6SWtky8OOUVoT91wkybqc3Us35GkQ=; b=WS4vjW0nHsuw0Xy6v2N61gYp1rxz5HhWOAIRnp+yX8ocYIHjkfOUFxQ+UWz93QHDUe xK83V9OwgolT1O6Nb9Mz7Q8s5vNiSHqeLiK/BF1NGJDLDNFrsqQsbteBoowFW/TRLMx3 rKUDETnaLd1dy60OtZ/shtcxwEBHso6GWiX7oO4JRYxY9JnJ3u0IZmo4TiuaUiRukaUr IQ6TUyCiO9WldeRLQnYAXLMYnydVeMU+KiyNYFF/eiSjrWgJ3n1KfhxolfSnwQdN2sjT nA1uncPqNaQ6wN1dm6plFmxk6Ehi2o6N0VU98YYyBsFoQQwYaFAZuYqV6wIXdlfXHXa6 BW+Q== X-Gm-Message-State: AOAM531rL+jxalkUjhAv99XlYd07OHYDkFGZna/PQ91/8LyZ+1lKeyZN 7Pq4qD6OIb9KtkOuBIsd2JkA6w== X-Google-Smtp-Source: ABdhPJy4s4Os4g4BimrwPYqBTyuimIgHGv/Tw5pKTo9o45UC77Zx8iUXrG6i0rHajUlErvf8HJcUgA== X-Received: by 2002:adf:fa0a:: with SMTP id m10mr12804533wrr.147.1617561110401; Sun, 04 Apr 2021 11:31:50 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id o14sm14482772wrh.88.2021.04.04.11.31.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Apr 2021 11:31:49 -0700 (PDT) In-Reply-To: <87eefsfl8f.fsf@rfc20.org> (Matt Armstrong's message of "Fri, 02 Apr 2021 14:08:16 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203553 Archived-At: found 47572 25.3.1 quit Matt Armstrong writes: > Attached is an ert test that demonstrates the problem. The crux is > that: > > (require 'map) > (setf (map-elt m key) value) > > returns VALUE only in the hash table implementation. `setf' should > return VALUE in all cases. > > For alists it returns either nil or (key . value) depending on whether a > key is inserted or udpated in place. Indeed, this bug seems to be present since map.el was introduced in Emacs 25. > For plists it returns similarly variable things. > > Here is the output I get from the attached test. The .el is attached afterwards. Would you be interested in also providing a patch for map.el? Thanks, -- Basil