From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45474: Icomplete exhibiting in recursive minibuffer when it =?UTF-8?Q?shouldn=E2=80=99t?= Date: Tue, 20 Apr 2021 22:01:31 +0300 Organization: LINKOV.NET Message-ID: <87lf9cepqw.fsf@mail.linkov.net> References: <3ed97a9c53e0a5d4fef8@heytings.org> <87fszrz21d.fsf@mail.linkov.net> <3ed97a9c530093aca93d@heytings.org> <7dee3f4235d331cab291@heytings.org> <87r1jatd34.fsf@mail.linkov.net> <7dee3f423551aaf318cb@heytings.org> <87im4kzlfm.fsf@mail.linkov.net> <1869622e16546eafd9df@heytings.org> <871rb6np5j.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5545"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , Dario Gjorgjevski , 45474@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 20 21:15:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYvq4-0001Kr-L0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Apr 2021 21:15:12 +0200 Original-Received: from localhost ([::1]:37530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYvq3-00070I-OR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Apr 2021 15:15:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYvpu-000709-RS for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2021 15:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44483) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYvpu-0006XL-Jl for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2021 15:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYvpu-000680-DQ for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2021 15:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Apr 2021 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45474 X-GNU-PR-Package: emacs Original-Received: via spool by 45474-submit@debbugs.gnu.org id=B45474.161894607823508 (code B ref 45474); Tue, 20 Apr 2021 19:15:02 +0000 Original-Received: (at 45474) by debbugs.gnu.org; 20 Apr 2021 19:14:38 +0000 Original-Received: from localhost ([127.0.0.1]:56029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYvpV-000676-T1 for submit@debbugs.gnu.org; Tue, 20 Apr 2021 15:14:38 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:51377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYvpT-00066r-Eb for 45474@debbugs.gnu.org; Tue, 20 Apr 2021 15:14:36 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 054B0FF806; Tue, 20 Apr 2021 19:14:26 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Mon, 19 Apr 2021 17:42:02 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204542 Archived-At: >> but then later you posted a different patch. Anyway FWIW here is >> a safer workable workaround that implements your first suggestion >> and sets a new explicit buffer-local variable in completing minibuffers, >> so modes that need to distinguish such minibuffers could check it. > > I combined your idea with that of Gregory for the patch below. > It's far from perfect, but I think it strikes a good balance of > simplicity, preserving compatibility, and moving in the right direction. > > WDYT? I tested your patch and discovered that it fails when two nested minibuffers both use completion, e.g. C-x C-f C-h v raises the error: Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argument symbolp The value of minibuffer-completion-table is 'read-file-name-internal' in the C-x C-f minibuffer that is correct. But the same value is also in the nested C-h v minibuffer instead of the correct help--symbol-completion-table.