From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#9609: Excessive transient region highlighting with highlight-nonselected-windows Date: Thu, 03 Jun 2021 01:02:25 +0300 Organization: LINKOV.NET Message-ID: <87lf7sc4cu.fsf@mail.linkov.net> References: <87fsy0g11m.fsf@gnus.org> <83wnrcxwr6.fsf@gnu.org> <83pmx4xudf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27879"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: rgm@gnu.org, larsi@gnus.org, 9609@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 03 00:59:06 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loZpJ-00076z-Jd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Jun 2021 00:59:05 +0200 Original-Received: from localhost ([::1]:37484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loZpI-00064a-NJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 18:59:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loZnK-0002xi-3V for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 18:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58232) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loZnJ-0005Mq-Qp for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 18:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loZnJ-0003Ht-Mx for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 18:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Jun 2021 22:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9609 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 9609-submit@debbugs.gnu.org id=B9609.162267460612615 (code B ref 9609); Wed, 02 Jun 2021 22:57:01 +0000 Original-Received: (at 9609) by debbugs.gnu.org; 2 Jun 2021 22:56:46 +0000 Original-Received: from localhost ([127.0.0.1]:41545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loZn3-0003HP-R3 for submit@debbugs.gnu.org; Wed, 02 Jun 2021 18:56:46 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:3097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loZn1-0003HC-SW for 9609@debbugs.gnu.org; Wed, 02 Jun 2021 18:56:44 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 98F83240006; Wed, 2 Jun 2021 22:56:36 +0000 (UTC) In-Reply-To: <83pmx4xudf.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Jun 2021 16:34:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207887 Archived-At: >> > > emacs -Q --eval '(progn (setq highlight-nonselected-windows t) (transient-mark-mode -1))' -f make-frame >> > > >> > > Two frames open showing the *scratch* buffer, once frame has focus. >> > > >> > > With the mouse, click on the "n" of "notes" in the focused frame. Do >> > > not release the mouse. In the other frame, a region starting or ending >> > > at "n" is now selected. >> > >> > I can confirm that this is still present in Emacs 28. >> > >> > Pretty weird behaviour. >> >> Probably we decided that the mouse was dragged because the coordinates >> in the other window are different. Or something like that. > > Btw, you don't need another frame to demonstrate the issue. You could > do this instead: > > emacs -Q --eval '(progn (setq highlight-nonselected-windows t) (transient-mark-mode -1))' > C-x 2 > Click and hold the mouse button on some character The problem is that currently the mark is not window-local. I tried such workaround, that fixes the above problem, but it has other issues. A proper fix needs to be in some low-level function. #+begin_src emacs-lisp ;; Make the mark buffer-and-window-local. (defvar-local mark-active-window nil) (add-hook 'activate-mark-hook (lambda () (setq mark-active-window (selected-window)))) (advice-add 'activate-mark :after (lambda (&rest _args) (setq mark-active-window (selected-window))) '((name . mark-active-window))) ;; Can't use deactivate-mark-hook because when clicking mouse in another window ;; with the same buffer it calls both activate-mark and deactivate-mark, ;; but deactivate-mark checks if the region is active (region-active-p), ;; and doesn't advance further because mark-active was set to nil in the redisplay ;; hook below. OTOH, the advice is used unconditionally. (add-hook 'deactivate-mark-hook (lambda () (setq mark-active-window nil))) (advice-add 'deactivate-mark :after (lambda (&rest _args) (setq mark-active-window nil)) '((name . mark-active-window))) (defun redisplay--update-mark-active-window (window) (when mark-active-window (setq mark-active (eq mark-active-window window)))) ;; Problem: when compiled without optimization CFLAGS='-O0' then ;; quick region selection experiences lags that results in wrong selection. ;; Another problem is that in ‘follow-mode’ ‘set-mark-command’ messes up windows. (add-hook 'pre-redisplay-functions #'redisplay--update-mark-active-window) #+end_src