From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#48916: 28.0.50; allow windmove to select windows with the 'no-other-window parameter Date: Wed, 09 Jun 2021 23:13:04 +0300 Organization: LINKOV.NET Message-ID: <87lf7ibxxf.fsf@mail.linkov.net> References: <878s3kzm66.fsf@riseup.net> <83czswfunl.fsf@gnu.org> <87zgw0xxya.fsf@riseup.net> <83y2bke98n.fsf@gnu.org> <878s3k76pe.fsf@gmail.com> <87mtryj28g.fsf@riseup.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1459"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Robert Pluim , 48916@debbugs.gnu.org To: pillule Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 09 22:15:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lr4bg-00006r-L2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 22:15:20 +0200 Original-Received: from localhost ([::1]:57578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lr4be-0002ml-KS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 16:15:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr4bQ-0002lT-N0 for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 16:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lr4bP-0000bO-CP for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 16:15:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lr4bO-0007ct-7H for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 16:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Jun 2021 20:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48916 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48916-submit@debbugs.gnu.org id=B48916.162326969329288 (code B ref 48916); Wed, 09 Jun 2021 20:15:02 +0000 Original-Received: (at 48916) by debbugs.gnu.org; 9 Jun 2021 20:14:53 +0000 Original-Received: from localhost ([127.0.0.1]:34737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lr4bF-0007cJ-9t for submit@debbugs.gnu.org; Wed, 09 Jun 2021 16:14:53 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:37705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lr4bD-0007c6-23 for 48916@debbugs.gnu.org; Wed, 09 Jun 2021 16:14:51 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 066F31C0004; Wed, 9 Jun 2021 20:14:43 +0000 (UTC) In-Reply-To: <87mtryj28g.fsf@riseup.net> (pillule@riseup.net's message of "Wed, 09 Jun 2021 19:37:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208305 Archived-At: >> You could try using new option in all functions that call >> window-in-direction: >> in windmove-display-in-direction, in windmove-delete-in-direction, >> in windmove-swap-states-in-direction. > > Done. > I am in terra incognita for theses commands, The opportunity to add new > keybindings in my configuration is always nice :p > > It was really simple and my tests seems to works fine with > 'windmove-allow-all-windows' for all functions. > > See the patch attached. Thanks, now it's much better. > As a side note, while reading these commands, > > I think 'windmove-display-same-window', 'windmove-display-new-frame', > 'windmove-display-new-tab' are not really at they own place in windmove. > > We have already "C-x 4 1" (same-window-prefix) and "C-x 5 5" > (other-frame-prefix) and (other-tab-prefix) --that is not bound to any > key on my system but would eventually have its place in the "C-x t" map. It's very strange that your configuration has unbound other-tab-prefix. By default, it's bound to 'C-x t t'. > Should we --for these windmove-commands : > 1. keep them as they are > 2. make aliases and clean-up 'windmove-display-in-direction' > 3. delete them and clean-up 'windmove-display-in-direction' > ? Please keep them as they are. It's very convenient to bind these commands to use the same prefix keys that are configured by windmove customization (that was greatly improved recently!)