From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gustavo Barros Newsgroups: gmane.emacs.bugs Subject: bug#48936: 27.2; pulse-reset-face and extend attribute of pulse-highligh-face Date: Sun, 13 Jun 2021 10:20:02 -0300 Message-ID: <87lf7d9a0t.fsf@gmail.com> References: <878s3j86pc.fsf@gmail.com> <87k0my2ale.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19654"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.15; emacs 27.2 Cc: 48936@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 13 15:21:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lsQ3G-0004mU-8b for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Jun 2021 15:21:22 +0200 Original-Received: from localhost ([::1]:37438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsQ3E-0003hd-I9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Jun 2021 09:21:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsQ2w-0003g5-7f for bug-gnu-emacs@gnu.org; Sun, 13 Jun 2021 09:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lsQ2v-00010r-Rw for bug-gnu-emacs@gnu.org; Sun, 13 Jun 2021 09:21:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lsQ2v-0003Js-IU for bug-gnu-emacs@gnu.org; Sun, 13 Jun 2021 09:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gustavo Barros Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Jun 2021 13:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48936 X-GNU-PR-Package: emacs Original-Received: via spool by 48936-submit@debbugs.gnu.org id=B48936.162359041512695 (code B ref 48936); Sun, 13 Jun 2021 13:21:01 +0000 Original-Received: (at 48936) by debbugs.gnu.org; 13 Jun 2021 13:20:15 +0000 Original-Received: from localhost ([127.0.0.1]:42997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsQ2A-0003Ih-OP for submit@debbugs.gnu.org; Sun, 13 Jun 2021 09:20:14 -0400 Original-Received: from mail-qv1-f43.google.com ([209.85.219.43]:34670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsQ28-0003IP-Ro for 48936@debbugs.gnu.org; Sun, 13 Jun 2021 09:20:13 -0400 Original-Received: by mail-qv1-f43.google.com with SMTP id 5so8823479qvf.1 for <48936@debbugs.gnu.org>; Sun, 13 Jun 2021 06:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:references:user-agent:from:to:cc:subject:in-reply-to :message-id:date:mime-version; bh=idaYJEFhhIfMpU13QAUpuyPDJf7JRvPgsTGtmmcedZE=; b=FqwuOUhtev7V8wEhyoyKB7QBrGOVrod0AbQi+2XcS5245XvWIxTclQCj1Q32VwZLUt xv2825l79vtrXC9mQHTNA2DoNrFLRokRAszv4Uhxa08wSSrrucywCddOUUg/g/oQjAoG AZIC0LKWK1gimxCsljuJzW+ONe2ieILLWXflt28nTwlA1cNk4YWbK3vG/xqDFYYPHMEs rdC+jYOuESnzMVxqoShC5VbbqxJbfBSAsuL3o2WGKKXefh64fd0xpnhBdrIK0Y00nuRa 94Ctn24Ltvg8wK0rqX+Yyx9JotJL3LhVT/8A/WlymECM79tK13iSVOMT55P0yMh2Bdh+ 2qpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=idaYJEFhhIfMpU13QAUpuyPDJf7JRvPgsTGtmmcedZE=; b=t8KfuGhN7qsPkZD+JMuYsPMAQrHCc7cguGrqE8yOzAGGfdgWC3soxPOEazUzza0S27 bQaAAqFTVTYZateylTKr6lLck8eww7CWFcmf9E0rCpxhZoetB7r6+6r9+1mz5XaRX+4/ 9Nn0ouvrSe5EJDaUQZFiCGEt/yNQzm4dCAp/BwuBrkASCeK9yF+cIcrQ7y4wLsMlMCbH A1453mh9k73KuKnEL8zFj7FhfE5Lw9uKFm2KATtFzJIYa529j3ijMCMgNLnXkbG8yCAM ZRhc16QeTgdxwJuyKrw4KlgdLJ5lBt9SXBPfHv0LbmcAHGClEP+5HKc4sKo1bfg+/203 qSdA== X-Gm-Message-State: AOAM532UykQP7H3F7OzWsqDSc48p9M8h2dqAxN0IvyRq15X9H4u3FzEO zY7X4F0QdJwbKkAM1AP5OLobtUQK9Gw= X-Google-Smtp-Source: ABdhPJwMSA6922jDRhXV/yYiYwjRffnMVP75b3O61hm0pM0w+j9RknPXRBNbIVL01PrtpN/FzM2znQ== X-Received: by 2002:a0c:ba0c:: with SMTP id w12mr13897131qvf.41.1623590406727; Sun, 13 Jun 2021 06:20:06 -0700 (PDT) Original-Received: from gusbrs-laptop ([102.129.152.117]) by smtp.gmail.com with ESMTPSA id x28sm8296988qtm.71.2021.06.13.06.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Jun 2021 06:20:05 -0700 (PDT) In-reply-to: <87k0my2ale.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208432 Archived-At: Hi Lars, On Sun, 13 Jun 2021 at 09:49, Lars Ingebrigtsen wrote: > Gustavo Barros writes: > >> Considering the role `pulse-highlight-face' plays in the way `pulse' >> works, it would be expected that this resetting should also be done >> for >> the `:extend' attribute when the function is called without an >> argument, > > I think that sounds correct, so I've now made this change in Emacs 28. Thank you for looking into this. But my suggestion was more the one to use the `:extend' attribute of `pulse-highlight-start-face' to reset `pulse-highlight-face'. Like: #+begin_src emacs-lisp (set-face-extend 'pulse-highlight-face (if face (face-extend-p face nil t) (face-extend-p 'pulse-highlight-start-face))) #+end_src Because `pulse-highlight-start-face' is the default face `pulse' uses when the `pulse-momentary-highlight-...' functions are called without argument. This makes `pulse-highlight-start-face' the only possible handle for setting the `:extend' attribute for calls of `pulse' functions without argument. If you just set it to nil when a call with no argument is made, we can still only get a pulse to work with `:extend' by explicitly passing the argument. Btw, this is the same treatment `:background' receives. Why should we treat both face attributes differently? Best regards, Gustavo.