unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#38519: minibuffer-depth-indicate-mode with enable-recursive-minibuffers
@ 2019-12-07 23:27 Juri Linkov
  2019-12-08 17:00 ` Drew Adams
  0 siblings, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2019-12-07 23:27 UTC (permalink / raw)
  To: 38519

A recent discussion about enable-recursive-minibuffers reminded
that minibuffer-depth-indicate-mode should be enabled when
enable-recursive-minibuffers is non-nil.  It's unusable
without the depth indication that is more error-prone.

It simultaneously enabling minibuffer-depth-indicate-mode
after enable-recursive-minibuffers becomes non-nil is not easy
to implement, then at least these two should mention each other
in the manual.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#38519: minibuffer-depth-indicate-mode with enable-recursive-minibuffers
  2019-12-07 23:27 bug#38519: minibuffer-depth-indicate-mode with enable-recursive-minibuffers Juri Linkov
@ 2019-12-08 17:00 ` Drew Adams
  2019-12-08 22:48   ` Juri Linkov
  0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2019-12-08 17:00 UTC (permalink / raw)
  To: Juri Linkov, 38519

> A recent discussion about enable-recursive-minibuffers reminded
> that minibuffer-depth-indicate-mode should be enabled when
> enable-recursive-minibuffers is non-nil.  It's unusable
> without the depth indication that is more error-prone.
> 
> It simultaneously enabling minibuffer-depth-indicate-mode
> after enable-recursive-minibuffers becomes non-nil is not easy
> to implement, then at least these two should mention each other
> in the manual.

It's a good question.

1. I agree that the docs should mention each other.
And the doc strings already do that:

`C-h v enable-recursive-minibuffers' says:
  Also see `minibuffer-depth-indicate-mode',
  which may be handy if this variable is non-nil.

`C-h f minibuffer-depth-indicate-mode' says:
  This is only useful if
  `enable-recursive-minibuffers' is non-nil.

But this hasn't yet been done in the manuals:
(elisp) `Recursive Mini' and (emacs) `Minibuffer
Edit' cover `enable-recursive-minibuffers', but
`minibuffer-depth-indicate-mode' is mentioned
nowhere, so far.

2. I agree that `minibuffer-depth-indicate-mode'
is useful when `enable-recursive-minibuffers'
is non-nil (generally and only).

3. I think I disagree that there should be
some kind of hard coupling between the two,
which would prevent users from getting
`enable-recursive-minibuffers' without
`minibuffer-depth-indicate-mode'.

It would be OK to automatically turn OFF
`minibuffer-depth-indicate-mode' when
`enable-recursive-minibuffers' is nil.  But
that's not necessary (it has no effect), so
it's not useful.

I don't think we should turn `m-d-i-m' ON
systematically when `e-r-m' is non-nil.  
That might be OK as a default behavior, but
we shouldn't impose it in a hard-coded way,
so that users have no recourse.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#38519: minibuffer-depth-indicate-mode with enable-recursive-minibuffers
  2019-12-08 17:00 ` Drew Adams
@ 2019-12-08 22:48   ` Juri Linkov
  2021-06-14 14:34     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2019-12-08 22:48 UTC (permalink / raw)
  To: Drew Adams; +Cc: 38519

> 1. I agree that the docs should mention each other.
> And the doc strings already do that:
>
> `C-h v enable-recursive-minibuffers' says:
>   Also see `minibuffer-depth-indicate-mode',
>   which may be handy if this variable is non-nil.
>
> `C-h f minibuffer-depth-indicate-mode' says:
>   This is only useful if
>   `enable-recursive-minibuffers' is non-nil.
>
> But this hasn't yet been done in the manuals:
> (elisp) `Recursive Mini' and (emacs) `Minibuffer
> Edit' cover `enable-recursive-minibuffers', but
> `minibuffer-depth-indicate-mode' is mentioned
> nowhere, so far.

So I added mention of `minibuffer-depth-indicate-mode' to
(emacs) `Minibuffer Edit'.  Not sure about
(elisp) `Recursive Mini', probably not needed in (elisp).

> 2. I agree that `minibuffer-depth-indicate-mode'
> is useful when `enable-recursive-minibuffers'
> is non-nil (generally and only).
>
> 3. I think I disagree that there should be
> some kind of hard coupling between the two,
> which would prevent users from getting
> `enable-recursive-minibuffers' without
> `minibuffer-depth-indicate-mode'.
>
> It would be OK to automatically turn OFF
> `minibuffer-depth-indicate-mode' when
> `enable-recursive-minibuffers' is nil.  But
> that's not necessary (it has no effect), so
> it's not useful.

Actually turning `m-d-i-m' OFF when `e-r-m' is nil
is not needed because `m-d-i-m' has no visual effect
when `e-r-m' is nil - there is nothing to show
as an indication of the recursive minibuffer
when recursive minibuffers are not enabled.

> I don't think we should turn `m-d-i-m' ON
> systematically when `e-r-m' is non-nil.
> That might be OK as a default behavior, but
> we shouldn't impose it in a hard-coded way,
> so that users have no recourse.

If turning `m-d-i-m' ON when `e-r-m' is non-nil
will be the default behavior, then users could
easily to turn `m-d-i-m' OFF.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#38519: minibuffer-depth-indicate-mode with enable-recursive-minibuffers
  2019-12-08 22:48   ` Juri Linkov
@ 2021-06-14 14:34     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-06-14 14:34 UTC (permalink / raw)
  To: Juri Linkov; +Cc: 38519

Juri Linkov <juri@linkov.net> writes:

>> But this hasn't yet been done in the manuals:
>> (elisp) `Recursive Mini' and (emacs) `Minibuffer
>> Edit' cover `enable-recursive-minibuffers', but
>> `minibuffer-depth-indicate-mode' is mentioned
>> nowhere, so far.
>
> So I added mention of `minibuffer-depth-indicate-mode' to
> (emacs) `Minibuffer Edit'.  Not sure about
> (elisp) `Recursive Mini', probably not needed in (elisp).

If I understand correctly, this should be a sufficient fix here, so I'm
closing this bug report.  If I misunderstood, please respond to the
debbugs address and we'll reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-14 14:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-07 23:27 bug#38519: minibuffer-depth-indicate-mode with enable-recursive-minibuffers Juri Linkov
2019-12-08 17:00 ` Drew Adams
2019-12-08 22:48   ` Juri Linkov
2021-06-14 14:34     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).