From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#26486: 25.1.91; unused var warning from cconv.el can't be suppressed Date: Tue, 06 Jul 2021 16:48:24 +0200 Message-ID: <87lf6jts5j.fsf@gnus.org> References: <87mtr0x025.fsf_-_@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36003"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: John Williams , 26486@debbugs.gnu.org, Noam Postavsky To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 06 16:50:02 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0mOf-00098B-Vg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Jul 2021 16:50:02 +0200 Original-Received: from localhost ([::1]:34780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0mOe-0003V8-T2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Jul 2021 10:50:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0mNi-0002uF-HD for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 10:49:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0mNi-0004ab-8s for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 10:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m0mNi-0006it-6b for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 10:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Jul 2021 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26486 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed moreinfo Original-Received: via spool by 26486-submit@debbugs.gnu.org id=B26486.162558291925804 (code B ref 26486); Tue, 06 Jul 2021 14:49:02 +0000 Original-Received: (at 26486) by debbugs.gnu.org; 6 Jul 2021 14:48:39 +0000 Original-Received: from localhost ([127.0.0.1]:49650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mNL-0006i7-CT for submit@debbugs.gnu.org; Tue, 06 Jul 2021 10:48:39 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:40934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mNJ-0006ho-KX for 26486@debbugs.gnu.org; Tue, 06 Jul 2021 10:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/Mo50/di4sW5cWdRoQEZpjlxPEOvrruODm0HVnabC6s=; b=mNW+GMp6GHhhEgRdgVDix5QONu GGmrHssRILNRPAJQRnW/5kuaVQbLVHqYgI/y93Gmkk57ThMhekJ6bNzaUf/sYgq8l7px1o2bb0kM4 wqkzV97wHVgIPbU9pqc4D/N2ylJe0yMq40+CygOBQFI3OdRD6SNR+EtnEPGFnY4yOPa0=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0mN7-00024e-Cb; Tue, 06 Jul 2021 16:48:27 +0200 X-Now-Playing: David Allred's _Alone on Friendship Island_: "The Hermit and the Fly" In-Reply-To: (Stefan Monnier's message of "Mon, 05 Jul 2021 11:29:40 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209521 Archived-At: Stefan Monnier writes: > LGTM, thank you. Thanks; applied. > This said, I suspect that it may fail to correctly > heed `with-suppressed-warnings`. More specifically, I think we may want > to add a "category" argument to `macroexp-warn-and-return` which is then > matched against `byte-compile-warnings` (either directly inside > `macroexp-warn-and-return` or within the subsequent handling of > `macroexp--funcall-if-compiled`). Right. Could you fix that? :-) > We already discussed the use(ful|less)ness of this empty-body warning, > and I don't think it's useful enough to justify adding a new warning > category for it. > > When `byte-compile-warnings` is nil, arguably `macroexp-warn-and-return` > should just silence all warnings. Right... but it feels kinda hackish to add the check for just `byte-compile-warnings' there, since we don't have access to the category at that point, so I altered the call site instead. But perhaps `macroexp-warn-and-return` should just be extended with a category parameter and then the check moved into the function instead... I dunno... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no