From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: John Williams <jrw@pobox.com>,
26486@debbugs.gnu.org,
Noam Postavsky <npostavs@users.sourceforge.net>
Subject: bug#26486: 25.1.91; unused var warning from cconv.el can't be suppressed
Date: Tue, 06 Jul 2021 16:48:24 +0200 [thread overview]
Message-ID: <87lf6jts5j.fsf@gnus.org> (raw)
In-Reply-To: <jwvczrwyedo.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 05 Jul 2021 11:29:40 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> LGTM, thank you.
Thanks; applied.
> This said, I suspect that it may fail to correctly
> heed `with-suppressed-warnings`. More specifically, I think we may want
> to add a "category" argument to `macroexp-warn-and-return` which is then
> matched against `byte-compile-warnings` (either directly inside
> `macroexp-warn-and-return` or within the subsequent handling of
> `macroexp--funcall-if-compiled`).
Right. Could you fix that? :-)
> We already discussed the use(ful|less)ness of this empty-body warning,
> and I don't think it's useful enough to justify adding a new warning
> category for it.
>
> When `byte-compile-warnings` is nil, arguably `macroexp-warn-and-return`
> should just silence all warnings.
Right... but it feels kinda hackish to add the check for just
`byte-compile-warnings' there, since we don't have access to the
category at that point, so I altered the call site instead. But perhaps
`macroexp-warn-and-return` should just be extended with a category
parameter and then the check moved into the function instead... I dunno...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-07-06 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 18:59 bug#26486: 25.1.91; spurious warnings from cconv.el John Williams
2017-04-13 19:28 ` Noam Postavsky
2021-07-05 15:17 ` bug#26486: 25.1.91; unused var warning from cconv.el can't be suppressed Lars Ingebrigtsen
2021-07-05 15:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-06 14:48 ` Lars Ingebrigtsen [this message]
2021-07-06 19:53 ` Basil L. Contovounesios
2021-07-06 20:03 ` Lars Ingebrigtsen
2021-07-06 20:04 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf6jts5j.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=26486@debbugs.gnu.org \
--cc=jrw@pobox.com \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).