From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50777: Dropping EIEIO from xref (for performance) Date: Sat, 25 Sep 2021 03:42:52 +0200 Message-ID: <87lf3lqvkz.fsf@gnus.org> References: <6b5b14d5-b2ca-8add-f4bf-a3405270c07a@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17845"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 50777@debbugs.gnu.org, Stefan Monnier , Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 03:44:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mTwjZ-0004Ra-3B for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 03:44:09 +0200 Original-Received: from localhost ([::1]:58948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTwjY-0002YZ-05 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Sep 2021 21:44:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTwjS-0002YD-0T for bug-gnu-emacs@gnu.org; Fri, 24 Sep 2021 21:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48219) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTwjR-000390-PC for bug-gnu-emacs@gnu.org; Fri, 24 Sep 2021 21:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTwjR-0006a7-JT for bug-gnu-emacs@gnu.org; Fri, 24 Sep 2021 21:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 01:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50777 X-GNU-PR-Package: emacs Original-Received: via spool by 50777-submit@debbugs.gnu.org id=B50777.163253418925215 (code B ref 50777); Sat, 25 Sep 2021 01:44:01 +0000 Original-Received: (at 50777) by debbugs.gnu.org; 25 Sep 2021 01:43:09 +0000 Original-Received: from localhost ([127.0.0.1]:59765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTwib-0006Yc-4l for submit@debbugs.gnu.org; Fri, 24 Sep 2021 21:43:09 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTwiY-0006YA-Ac for 50777@debbugs.gnu.org; Fri, 24 Sep 2021 21:43:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ioh9ms9EPnjwv7KCmoynMYwFe2Nc8hU2L+EXBkB1gAE=; b=vEeShKisNi1TY+bHzVQNbxV8r2 pwBp31yreVdk9c2w/hhblymc1mcooqSRmyuJnmWBss3ZpzK0s5aACV2/cgVhlVu+VQe2IIL3FMIQL t3uPVfQW+v+1UEpL5gpt/TFy1F9Ef3M0zliGGuCB1HLEuJasbCJniNm28NuotKj2CW14=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mTwiL-00085y-Jj; Sat, 25 Sep 2021 03:42:55 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEU+RoM3R4Uscq4n hsItS41TWpOwr8o1iL7///9ogBk0AAAAAWJLR0QIht6VegAAAAd0SU1FB+UJGQEHAOTfpgUAAAGs SURBVDjLdZNLcoMwDIbJDWJad49c2nWtCex7A+iYPcngrBtm8PUr+QFOQkVMHH2W5N+xikI824FG sQfYikMJoJAGBNNK00sciwO8VgDvJXxDJQDKqvScQPVcgdLQgL0KIPIIabp9YITMAUgjDZuggI6/ AxBgognZmYknlFCJwtTR3wljhlGGKQNng9E6Y6eYlXQMGRjsFLNSDbusgFLR43MxaLaIt8EOIabc wEQChxX4VBd7ZUDirJkGS+6+zoCVspNm9AA8aC6uZeAPy1jeWAAfF2xjcSKSgTqFiBk9CEc7rGC5 IPpdxTM3D0AkQARjKpy9jPX/6vHU+4gZFzvmQNes3HrQZeBH16lGY/Ob0OsoEPFj+ge0d8Ak0GI7 5qBOOtoZfzN/qTOQ39MXDAKXc3vDrwyoFSCizgAmQLtCteUq6ecqMA9R92AN4QCsVRTIVm1+ijim CDLuoFJl4KxQaepP1BCXRHDzLas2N6Vl0MzeC/TB1jlHY44ANT6YB8uVlrlb7P8KPmnaMXDpTse2 5A7rWaDzpoC2xbVoD5omfBlSd6zd7ht3H3RH8QdZYeMm+rfuuwAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMS0wOS0yNVQwMTowNzowMCswMDowMFTYEMIAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDkt MjVUMDE6MDc6MDArMDA6MDAlhah+AAAAAElFTkSuQmCC X-Now-Playing: Brigid Mae Power's _Head Above the Water_: "Head Above The Water" In-Reply-To: (Dmitry Gutov's message of "Fri, 24 Sep 2021 16:37:25 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215379 Archived-At: Dmitry Gutov writes: > The ones that do can be updated to rely on the recommended public > interface: the xref-make-* constructors and the generic functions to > access the data. This will keep the code compatible with both new and > previous versions of Xref. > > I'd like to push it soon, so users of Emacs 28 can enjoy the speedup. > > What do people think? Speedups would be nice, but I think this sounds like a very big change to make to such a central system (that I think many third-party packages rely on) at this point, so I'm leaning towards it being in Emacs 29 instead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no