From: Robert Pluim <rpluim@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Andy Moreton <andrewjmoreton@gmail.com>, 50985@debbugs.gnu.org
Subject: bug#50985: Merging gnulib for Emacs 28.1?
Date: Wed, 06 Oct 2021 09:23:53 +0200 [thread overview]
Message-ID: <87lf36wr92.fsf@gmail.com> (raw)
In-Reply-To: <beffdfbd-6f83-0339-7315-b96ab7daf7c6@cs.ucla.edu> (Paul Eggert's message of "Tue, 5 Oct 2021 09:16:13 -0700")
>>>>> On Tue, 5 Oct 2021 09:16:13 -0700, Paul Eggert <eggert@cs.ucla.edu> said:
Paul> On 10/5/21 7:11 AM, Robert Pluim wrote:
>> Probably. When it comes to gnulib I prefer to leave it to people who
>> know what theyʼre doing :-)
Paul> We can't wait for *that* (:-), so I charged ahead and installed the
Paul> attached patches into the emacs-28 branch. This fixed the md5_stream
Paul> issue for me.
Your patch just proves my point: mine was less minimal than it could
have been because I made a mistake in adding crypto/af_alg, then
removing it, and thus having an excessive addition to AVOIDED_MODULES.
Paul> The key issue here is whether Emacs wants to use cryptography
Paul> algorithms supported by the Linux kernel, if available. I expect that
Paul> Emacs doesn't want to bother, because its use of md5_stream is not
Paul> that performance- or security-relevant and because if we wanted Emacs
Paul> to use the kernel stuff that'd drag in a lot more Gnulib modules which
Paul> would be more trouble than it's worth. Comments welcome of course,
Paul> since this is a judgment call.
Seems sound to me. --with-native-compilation works for me now on
GNU/Linux.
Paul> I hadn't run into this earlier because I was doing a default
Paul> configure+build, which on my platform didn't use native compilation.
I donʼt think any platform does native compilation by default (yet?).
Robert
--
next prev parent reply other threads:[~2021-10-06 7:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 3:42 bug#50985: Merging gnulib for Emacs 28.1? Stefan Kangas
2021-10-03 19:37 ` Paul Eggert
2021-10-04 6:37 ` Paul Eggert
2021-10-04 12:19 ` Eli Zaretskii
2021-10-04 22:26 ` Paul Eggert
2021-10-04 23:18 ` Andy Moreton
2021-10-04 23:44 ` Andy Moreton
2021-10-05 12:44 ` Ken Brown
2021-10-05 12:59 ` Eli Zaretskii
2021-10-05 12:58 ` Eli Zaretskii
2021-10-05 13:44 ` Robert Pluim
2021-10-05 14:09 ` Ken Brown
2021-10-05 14:11 ` Robert Pluim
2021-10-05 16:16 ` Paul Eggert
2021-10-05 18:15 ` Andy Moreton
2021-10-06 7:23 ` Robert Pluim [this message]
2021-10-05 16:19 ` Paul Eggert
2021-10-07 9:14 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf36wr92.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=50985@debbugs.gnu.org \
--cc=andrewjmoreton@gmail.com \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).